You have worst problems to deal with first, so I'll explain what you have noticed last.
1) Never concatenate strings to build a SQL command. It leaves you wide open to accidental or deliberate SQL Injection attack which can destroy your entire database. Always use Parameterized queries instead.
When you concatenate strings, you cause problems because SQL receives commands like:
SELECT * FROM MyTable WHERE StreetAddress = 'Baker's Wood'
The quote the user added terminates the string as far as SQL is concerned and you get problems. But it could be worse. If I come along and type this instead: "x';DROP TABLE MyTable;--" Then SQL receives a very different command:
SELECT * FROM MyTable WHERE StreetAddress = 'x';DROP TABLE MyTable;
Which SQL sees as three separate commands:
SELECT * FROM MyTable WHERE StreetAddress = 'x';
A perfectly valid SELECT
DROP TABLE MyTable;
A perfectly valid "delete the table" command
And everything else is a comment.
So it does: selects any matching rows, deletes the table from the DB, and ignores anything else.
So ALWAYS use parameterized queries! Or be prepared to restore your DB from backup frequently. You do take backups regularly, don't you?
And on a LOGIN SCREEN? That's positively suicidal as I don't even have to be a user to destroy your DB!
2) Never store passwords in clear text - it is a major security risk. There is some information on how to do it here:
Password Storage: How to do it.[
^]
And remember: if you have any European Union users then GDPR applies and that means you need to handle passwords as sensitive data and store them in a safe and secure manner. Text is neither of those and the fines can be .... um ... outstanding. In December 2018 a German company received a relatively low fine of €20,000 for just that.
3) You don't check if the DB returned any rows: if you mistype, it will throw an "index out of range" error and your app will crash.
4) You only close the connection for Admins. Instead on manually closing the connection, surround the whole DB code in
using
blocks and the system will automatically tidy up for you.
5) The problem you have noticed ... Look at your code:
if (dt1.Rows[0][0].ToString() == "Admin")
con.Close();
{
Hide();
Admin ad = new Admin();
ad.Show();
}
If the condition matches it closes the connection.Then it always executes the code in the curly brackets even if the condition didn't match ...