RangeValidator Error when loading page

Question

0.00/5 (No votes)

See more:

I have a form that has 5 rangevalidators on it. When the page loads this error comes up:

HTML

Input string was not in a correct format.
Line 82:         RangeValidatorLYTNFUG.MinimumValue = Convert.ToString(Convert.ToInt32(TextBoxLYTNFUG.Text) - Convert.ToInt32(TextBoxLYTNFUG.Text) * 20 / 100);

So I made sure that the database the textboxes was populating from had data in it which it does. I have these codes in place for all 5 rangevalidators:

C#

protected void Page_Load(object sender, EventArgs e)
{
 RangeValidatorLYTNFUG.MinimumValue = Convert.ToString(Convert.ToInt32(TextBoxLYTNFUG.Text) - Convert.ToInt32(TextBoxLYTNFUG.Text) * 20 / 100);
        RangeValidatorLYTNFUG.MaximumValue = Convert.ToString(Convert.ToInt32(TextBoxLYTNFUG.Text) + Convert.ToInt32(TextBoxLYTNFUG.Text) * 20 / 100);

        RangeValidatorLYTNFG.MinimumValue = Convert.ToString(Convert.ToInt32(TextBoxLYTNFG.Text) - Convert.ToInt32(TextBoxLYTNFG.Text) * 20 / 100);
        RangeValidatorLYTNFG.MaximumValue = Convert.ToString(Convert.ToInt32(TextBoxLYTNFG.Text) + Convert.ToInt32(TextBoxLYTNFG.Text) * 20 / 100);

        RangeValidatorLYTNCPUG.MinimumValue = Convert.ToString(Convert.ToInt32(TextBoxLYTNCPUG.Text) - Convert.ToInt32(TextBoxLYTNCPUG.Text) * 20 / 100);
        RangeValidatorLYTNCPUG.MaximumValue = Convert.ToString(Convert.ToInt32(TextBoxLYTNCPUG.Text) + Convert.ToInt32(TextBoxLYTNCPUG.Text) * 20 / 100);

        RangeValidatorLYTNCPG.MinimumValue = Convert.ToString(Convert.ToInt32(TextBoxLYTNCPG.Text) - Convert.ToInt32(TextBoxLYTNCPG.Text) * 20 / 100);
        RangeValidatorLYTNCPG.MaximumValue = Convert.ToString(Convert.ToInt32(TextBoxLYTNCPG.Text) + Convert.ToInt32(TextBoxLYTNCPG.Text) * 20 / 100);

        RangeValidatorLYTNNCC.MinimumValue = Convert.ToString(Convert.ToInt32(TextBoxLYTNNCC.Text) - Convert.ToInt32(TextBoxLYTNNCC.Text) * 20 / 100);
        RangeValidatorLYTNNCC.MaximumValue = Convert.ToString(Convert.ToInt32(TextBoxLYTNNCC.Text) + Convert.ToInt32(TextBoxLYTNNCC.Text) * 20 / 100);
}

The code works but I also add another textbox populated code to populate the other textboxes on the form of the data that the user just submitted. There is nothing in that database yet until the user submits it. What am I doing wrong to get this error?

Here is the TextBox_TextChange Code:

C#

protected void TextBoxTNNCC_TextChanged(object sender, EventArgs e)
    {
        int a = Convert.ToInt32(TextBoxTNFUG.Text);
        int b = Convert.ToInt32(TextBoxTNFG.Text);
        int c = Convert.ToInt32(TextBoxTNCPUG.Text);
        int d = Convert.ToInt32(TextBoxTNCPG.Text);
        int f = Convert.ToInt32(TextBoxTNNCC.Text);
        TextBoxTHCAS.Text = Convert.ToString(a + b + c + d + f);

    }

Posted 4-Dec-13 2:34am

Computer Wiz99

Updated 4-Dec-13 7:37am

v2

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

thatraja · Accepted Answer · 2013-12-04T04:50:00

This error occurs because of conversion. The value is non-numeric or blank string.
Check this similar question with answer to solve your issue.
Conversion from string to int[^]

Few suggestions:
Don't put massive code in Page_Load(), create a function/sub procedure for that & call it in Page_Load() like below.

C#

protected void Page_Load(object sender, EventArgs e)
{
    InitRangeValidations();
}
protected void InitRangeValidations()
{
 RangeValidatorLYTNFUG.MinimumValue = Convert.ToString(Convert.ToInt32(TextBoxLYTNFUG.Text) - Convert.ToInt32(TextBoxLYTNFUG.Text) * 20 / 100);
        RangeValidatorLYTNFUG.MaximumValue = Convert.ToString(Convert.ToInt32(TextBoxLYTNFUG.Text) + Convert.ToInt32(TextBoxLYTNFUG.Text) * 20 / 100);

/*
Remaining massive code blah blah blah
*/
}

And try to simplify your code, the below one is simpler than yours, agree? It's more readable one. I could simplify even more than this(like reducing 2 or 3 lines).

C#

protected void InitRangeValidations()
{
int itxtVal = Convert.ToInt32(TextBoxLYTNFUG.Text);//Modify this line based on above link as I'm giving you as exercise for you
int iMinVal = (itxtVal - itxtVal * 20 / 100);
int iMaxVal = (itxtVal + itxtVal * 20 / 100);
RangeValidatorLYTNFUG.MinimumValue = iMinVal.ToString();
RangeValidatorLYTNFUG.MaximumValue = iMaxVal.ToString();
}

I know you're posting questions here with clear details regularly, keep doing this. Here suggestions for you to optimize your code.
Some practices to write better C#/.NET code[^]
Some Best Practices for C# Application Development (Explained)[^]