Optimize,Stored proc has 34 left join,18 subquery

Question

2.33/5 (4 votes)

See more:

Below Stored procedure has 34 left join , 18 subquery which goes dead in production server which have lakhs of records. Any
suggestion / tips / opinion regarding optimization

Posted 12-Feb-14 6:11am

anbujeremiah

Updated 16-Feb-14 14:40pm

v3

Add a Solution

Comments

Maciej Los 12-Feb-14 15:43pm

What a bad design!!!

Matt T Heffron 12-Feb-14 21:26pm

Upvoted the question...we don't know that the poster WROTE this vs. INHERITED it.
It might not be their fault, so the question could be reasonable.

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Andrius Leonavicius · Answer 1 · 2014-02-12T08:24:00

Hi,

Does it really have to be so complex?

You need to simplify things. Think about what could be unnecessary and get rid of that. I don't know the business requirements, but maybe you could split this into parts?

You should read and learn about query optimization. I would recommend to read this (if you're using SQL Server):
SQL SERVER – Tips for SQL Query Optimization by Analyzing Query Plan[^]

BTW, are you not missing a WHERE statement at the end of this select?

Dave Kreskowiak · Answer 2 · 2014-02-12T15:22:00

Solution 2

One word: Horrifying! I'm glad I'm not following in your footsteps and don't have to support that piece of sh*t.

If you've got a query like this, something tells me your entire database design is seriously flawed! No amount of "optimization" is going to shorten that query.

Posted 12-Feb-14 15:22pm

Dave Kreskowiak