Click here to Skip to main content
15,176,980 members

Comments by FZelle (Top 7 by date)

FZelle 12-Nov-12 9:33am View
Reason for my vote of 2
Good start, bad end.
Against SqlInjections you don't download whole databases and do the select in code, but you use SqlParameters.
FZelle 18-Apr-12 7:31am View
Reason for my vote of 2
While it might be neccessary to do such a thing, but unsafe is not needed here.
Use a StringBuilder
FZelle 15-Jan-12 17:23pm View
Why don't you use the widely accepted Dispose Pattern instead of creating your own names?
FZelle 27-Sep-11 5:41am View
Yes you are missing alot.
UI Elements normally function by sending windows messages and this only works in the main UI Thread.
And because of that MS has implemented a crossthreadexception whenever you do what you are doing.
But this topic is discussed in so many articles here that it is virtually impossible not to read about it.
FZelle 21-Sep-11 6:07am View
Reason for my vote of 1
This exactly how you shouldn't implement this.
ShowDialog and every UI Related task has to be done in the UI Thread.
It is the action that belongs in the seperate thread
FZelle 22-Feb-11 5:35am View
Reason for my vote of 1
1. Access is not needed for this, the Jet Engine does the Access access.
2. If you would know the basics of ADO.NET you would not create the Connection beforehand. The Adapter can use a connectionstring and then it opens and closes the Connection itself.
3. If you want to fill a datatable, do it, don't use a dataset if you don't need one.
4. After a new on DS/DT you don't need to clear it, it is not "dirty".
5. Because of 2, you only need a global variable for the connectionstring
6. There is a reason why a function can have parameters, not to missuse global variables, so use a parameter for Execute
7. We are not in VB6 anymore, get rid of those ToString() and use string.Format
8. Do not catch Exceptions in the dal ( even if it is located in your form ). Catch the exceptions where it makes sence, in the caller.
FZelle 10-Nov-10 5:00am View
My Solution has nothing to do with esoterics.
It came from the need that it should work in XP and W7.
Tried your version on both?