problem to update a data in vb.net

Question

0.00/5 (No votes)

See more:

i have only one colum in back end database that is roll. ..
Now i want to update a particular data ..
how can i do this
My code is---

VB

dim s1 as integer=TextBox1.Text
  str = "UPDATE  Table1 SET roll=" & TextBox1.Text & "  WHERE roll= " & s1 & " "
        cmd = New SqlCommand(str, cn)
        cmd.ExecuteNonQuery()

Posted 30-Jul-11 22:04pm

Neeil

Add a Solution

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

walterhevedeich · Answer 1 · 2011-07-30T22:11:00

Solution 1

If roll is a string type, I don't think your query will work, unless you place single quotes around the values. In addition, one way to improve your code is to use parameters. See below for example.

VB

str = "UPDATE Table1 SET roll=@rollVal1 WHERE roll=@rollVal2"
cmd = New Sqlommand(str, cn)
cmd.Parameters.AddWithValue("@rollVal1", TextBox1.Text)
cmd.Parameters.AddWithValue("@rollVal2", sl)
cmd.ExecuteNonQuery()

[Edit]
See here[^] for reference.

Posted 30-Jul-11 22:11pm

walterhevedeich

Updated 30-Jul-11 22:42pm

v2

Comments

OriginalGriff 31-Jul-11 4:13am

Much better!

walterhevedeich 31-Jul-11 4:44am

Thanks.

Neeil 31-Jul-11 4:21am

no it is not a string,,,it is numbar data type..(integer)

walterhevedeich 31-Jul-11 4:43am

As far as I know, AddWithValue method converts the data type automatically, so the code I provided should be able to convert the parameters to Int type. You can try that out. Also, see my updated answer for reference.

Bhatt Aniruddh · Answer 2 · 2011-08-14T18:21:00

Solution 2

Try These code, it is working.

dim s1 as integer=TextBox1.Text
str = "UPDATE Table1 SET roll=" & TextBox1.Text & ""
cmd = New SqlCommand(str, cn)
cmd.ExecuteNonQuery()

Posted 14-Aug-11 18:21pm

Bhatt Aniruddh