using @@Identity in sql server 2008

Question

0.00/5 (No votes)

See more:

How do you fill a linking table with the primary key of the main tables using the @@IDENTITY

I am trying to get the autoincremnt id from the PhysicalTest table and save it in my linking table called PatientRecord

CREATE PROCEDURE procAddPhysicalTestCheck
@Height float,
@Weight float,
@BodyMass float,
@BloodPressure nvarchar(10),
@Temperature float,
@RespiratoryRate nvarchar(10),
@HeartRate float
AS
		INSERT INTO PhysicalTest(Height,Weight,BodyMass,BloodPressure,Temprature,RespiratoryRate,HeartRate)
		VALUES(@Height,@Weight,@BodyMass,@BloodPressure,@Temperature,@RespiratoryRate,@HeartRate)
		
		SELECT @@IDENTITY AS 'Identity'
		DECLARE @PhysicalID AS int
		SET @PhysicalID = @@IDENTITY
		
		INSERT INTO PatientRecord(PhysicalTestID)
		VALUES(@PhysicalID)

Posted 14-Sep-11 4:16am

Elrick007

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

fjdiewornncalwe · Answer 1 · 2011-09-14T04:22:00

No need for the SELECT @@IDENTIY row.

DECLARE @PhysicalID AS int
SET @PhysicalID = @@IDENTITY

I would suggest using SCOPE_IDENTITY instead, however.
Scope Identity[^]

I personally don't like this approach, however,
It would make more stable to perform a SELECT FROM the PhysicalTest table on all the input values to guarantee that the row wrote and that you have the ID for that row.

SQL

INSERT INTO PhysicalTest(Height,Weight,BodyMass,BloodPressure,Temprature,RespiratoryRate,HeartRate)
VALUES(@Height,@Weight,@BodyMass,@BloodPressure,@Temperature,@RespiratoryRate,@HeartRate)
		
DECLARE @PhysicalID AS int
SELECT @PhysicalID = [IdFieldName] 
FROM PhysicalTest WHERE Height = @Height AND Weight = @Weight ... AND HeartRate = @HeartRate

IF @PhysicalID IS NOT NULL 
BEGIN
    INSERT INTO PatientRecord(PhysicalTestID) VALUES(@PhysicalID)
END