any correct this queue program

Question

1.00/5 (1 vote)

See more:

C#

#include<stdio.h>
#include<conio.h>

// creating structure
struct node
  {
  int data;
  struct node *next;  // this variable is refering the struct node
  }*front=NULL,*temp,*get,*last=NULL;

int main()
  {
  //front = NULL;
  clrscr();
  // insert the queue element
  // insert function declaration
  add(&front,&last,56);
  add(&front,&last,88);
  add(&front,&last,44);
  add(&front,&last,99);
  add(&front,&last,100);
  add(&front,&last,23);
  
  // display the queue element
  display(front);
  
  //pop function
  pop(&front);
  pop(&front);
  
  getch();
  return 0;
  }

//definition of the insert function
add(struct node *temp,struct node *last,int val)
  {
  temp = (struct node *)malloc(sizeof(struct node));
  //ne = (temp *) malloc(40*sizeof(temp));
  
  if(front == NULL)
    {
    temp->data = val;
    temp->next = NULL;
    front = temp;
    printf("added stack value is %d\n",temp->data);
    }
  else
    //struct node *p;
    {
    get = temp;
    get->data = val;
    last->next = temp;
    printf("added stack value is %d\n",get->data);
    }
  last = temp;
  }

display(front)
  {
  int count=0;
  while(front->next != NULL)
    {
    printf("%d\n",front -> data);
    count++;
    }
  printf("No of Nodes: %d\n",count);
  }


/* pop()
  {
  struct node *del;
  del = front;
  if(front->next == NULL)
    {
    printf("Deleted node value: %d",front->data);
    free(front);
    front = NULL;
    }
  else
    {
    while(del->next != NULL)
      {
      temp = del;
      del = del->next;
      }
    printf("deleted element is: %d\n",del->data);
    temp->next = NULL;
    free(del);
    }
  }
*/

pop(struct node *front)
  {
  struct node *del;
  int d;
  del = front;
  if(del->next == NULL)
    {
    printf("\n\nDeleted node value: %d",del->data);
    free(del);
    del = NULL;
    }
  else
    {
    //temp = del;
    d= del->data;
    //front = del->next;
    front = del->next;
    printf("\n\ndeleted : %d\n",d);
    //temp->next = NULL;
    free(del);
    }
  }

[edit]Code block indented - OriginalGriff[/edit]

Posted 6-Oct-11 20:28pm

kschandru

Updated 6-Oct-11 22:30pm

OriginalGriff

v2

Add a Solution

Comments

CodingLover 7-Oct-11 2:34am

What is your problem here?

OriginalGriff 7-Oct-11 4:33am

Rules of posting questions (and indeed of programming):
1) INDENT YOUR CODE. Do you see how much easier it is to work out what is happening in your code when the blocks are indented as above? It makes it easier for you, it makes it easier for us. Win-win.
2) When you want help, it is a very, very good idea to describe what the problem is. Just going "fix this" doesn't help - we don't know what you consider to be the problem.
Use the "Improve question" widget to edit your question and provide better information.

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

CPallini · Accepted Answer · 2011-10-07T00:00:00

Your code is messy.
Try:

C

#include <stdio.h>
#include <stdlib.h>
#include <assert.h>
struct node;
void add(int val);

void display();
void pop();

// creating structure
struct node
{
  int data;
  struct node *next;  // this variable is refering the struct node
} *front=NULL;

int main()
{
  // insert the queue element
  // insert function declaration

  add(56);
  add(88);
  add(44);
  add(99);
  add(100);
  add(23);

  // display the queue element
  display();

  pop();
  pop();

  printf("after 2 pops\n");
  display();

  // cleanup
  while (front) pop();

  getchar();
  return 0;
}

//definition of the insert function
void add(int val)
{
  struct node * temp = (struct node *)malloc(sizeof(struct node));

  assert(temp);

  temp->data = val;
  temp->next = NULL;
  if ( ! front )
  {
    front = temp;
  }
  else
  {
    struct node * p = front;
    while ( p->next )
    {
      p = p->next;
    }
    p->next = temp;
  }
}

void display()
{
  int count=0;
  struct node * temp = front;
  while(temp)
  {
    printf("%d\n", temp->data);
    count++;
    temp = temp->next;
  }
  printf("No of Nodes: %d\n",count);
}

void pop()
{
  struct node *temp;
  temp = front;
  if ( temp )
  {
    front = temp->next;
    printf("\nDeleting node value: %d\n", temp->data);
    free(temp);
  }
  else
  {
    printf("\nEmpty queue\n");
  }
}