For Loop subtotal becoming double

Question

1.00/5 (1 vote)

See more:

Hi
Below is my C# code to find total and subtotal of dynamic textbox in gridview

as per my code the subtotal value is becoming double,example for 500 i am getting 1000 ..

please correct me

Thanks

for (int i = 1; i <= dtCurrentTable.Rows.Count; i++)
                {
 TextBox box3  =   (TextBox)ItemGv.Rows[rowIndex].Cells[2].FindControl("qtytb");
 TextBox box4 =     (TextBox)ItemGv.Rows[rowIndex].Cells[3].FindControl("upricetb");
 TextBox box5 =     (TextBox)ItemGv.Rows[rowIndex].Cells[4].FindControl("amounttb");

                    drCurrentRow = dtCurrentTable.NewRow();

                    
                    drCurrentRow["Qty"] = box3.Text;
                    drCurrentRow["UnitPrice"] = box4.Text;                   
                    drCurrentRow["TotalAmount"] = box5.Text;
 //Total


                    for (int j = 0; j < ItemGv.Columns.Count; j++)
                    {
                        total = Convert.ToInt32(box3.Text) * Convert.ToSingle(box4.Text);
                        box5.Text = total.ToString();

                    }
//subtotal

                    for (int k = 0; k < ItemGv.Rows.Count; k++)
                    {
                       
                            subtotal = subtotal + Convert.ToSingle(box5.Text);
                            subtotaltb.Text = subtotal.ToString();
                        
                    
                    }


                    
                    rowIndex++;

[complete code]
Could you pls have a look i have posted complete code

C#

private void AddNewRowToGrid()
    {
        int rowIndex = 0;
        float total;
        float subtotal = 0;

      
        if (ViewState["CurrentTable"] != null)
        {
            DataTable dtCurrentTable = (DataTable)ViewState["CurrentTable"];

            DataRow drCurrentRow = null;

            if (dtCurrentTable.Rows.Count > 0)
            {
                for (int i = 1; i <= dtCurrentTable.Rows.Count; i++)
                {
                    //extract the TextBox values

                    TextBox box1 = (TextBox)ItemGv.Rows[rowIndex].Cells[0].FindControl("itemNotb");

                    TextBox box2 = (TextBox)ItemGv.Rows[rowIndex].Cells[1].FindControl("desctb");
                    TextBox box3 = (TextBox)ItemGv.Rows[rowIndex].Cells[2].FindControl("qtytb");
                    TextBox box4 = (TextBox)ItemGv.Rows[rowIndex].Cells[3].FindControl("upricetb");
                    TextBox box5 = (TextBox)ItemGv.Rows[rowIndex].Cells[4].FindControl("amounttb");

                    drCurrentRow = dtCurrentTable.NewRow();

                    drCurrentRow["ItemNo"] = box1.Text;
                    drCurrentRow["Description"] = box2.Text;
                    drCurrentRow["Qty"] = box3.Text;
                    drCurrentRow["UnitPrice"] = box4.Text;                   
                    drCurrentRow["TotalAmount"] = box5.Text;

                    for (int j = 0; j < ItemGv.Columns.Count; j++)
                    {
                        total = Convert.ToInt32(box3.Text) * Convert.ToSingle(box4.Text);
                        box5.Text = total.ToString();

                    }


                    for (int k = 0; k < ItemGv.Rows.Count; k++)
                    {
                       
                            subtotal = subtotal + Convert.ToSingle(box5.Text);
                            subtotaltb.Text = subtotal.ToString();
                        
                    
                    }


                    
                    rowIndex++;

                }

Posted 10-Dec-11 20:20pm

Lancy.net

Updated 10-Dec-11 22:15pm

Monjurul Habib

v2

Add a Solution

Comments

Sergey Alexandrovich Kryukov 11-Dec-11 2:25am

Relevant part of code is not show. It's apparent that the problem is outside. Where is the declaration of "subtotal"? Where is the method of the shown code? Also, just run it all under debugger and you will see.
--SA

Lancy.net 11-Dec-11 2:33am

Thanks...
Could you pls have a look i have posted complete code

private void AddNewRowToGrid()
{
int rowIndex = 0;
float total;
float subtotal = 0;

if (ViewState["CurrentTable"] != null)
{
DataTable dtCurrentTable = (DataTable)ViewState["CurrentTable"];

DataRow drCurrentRow = null;

if (dtCurrentTable.Rows.Count > 0)
{
for (int i = 1; i <= dtCurrentTable.Rows.Count; i++)
{
//extract the TextBox values

TextBox box1 = (TextBox)ItemGv.Rows[rowIndex].Cells[0].FindControl("itemNotb");

TextBox box2 = (TextBox)ItemGv.Rows[rowIndex].Cells[1].FindControl("desctb");
TextBox box3 = (TextBox)ItemGv.Rows[rowIndex].Cells[2].FindControl("qtytb");
TextBox box4 = (TextBox)ItemGv.Rows[rowIndex].Cells[3].FindControl("upricetb");
TextBox box5 = (TextBox)ItemGv.Rows[rowIndex].Cells[4].FindControl("amounttb");

drCurrentRow = dtCurrentTable.NewRow();

drCurrentRow["ItemNo"] = box1.Text;
drCurrentRow["Description"] = box2.Text;
drCurrentRow["Qty"] = box3.Text;
drCurrentRow["UnitPrice"] = box4.Text;
drCurrentRow["TotalAmount"] = box5.Text;

for (int j = 0; j < ItemGv.Columns.Count; j++)
{
total = Convert.ToInt32(box3.Text) * Convert.ToSingle(box4.Text);
box5.Text = total.ToString();

}

for (int k = 0; k < ItemGv.Rows.Count; k++)
{

subtotal = subtotal + Convert.ToSingle(box5.Text);
subtotaltb.Text = subtotal.ToString();

}

rowIndex++;

}

2 solutions

Solution 1

I can't help thinking that you need to go back a step, and re-think what you are doing.
I'm not sure what you expect that code to do, but I don't think it is quite what you expect.

The reason I say this is that you have two inner loops, both working on a external object ItemGv, buit inthe first loop you do the same code each time you go round, and in the second you just effectively multiply the result of the first loop but the rows count of the ItemGv. This seems odd - and not what I would expect given the variable names.

Have a think about what your code should be doing, and try to work out why you put the loops in in the first place! If that doesn't sort it out, put a breakpoint at the start of the routine, and single step through it - I don't think it does what you expect.

Posted 10-Dec-11 20:56pm

OriginalGriff

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Lancy.net · Accepted Answer · 2011-12-11T05:22:00

for (int i = 1; i <= dtCurrentTable.Rows.Count; i++)
                {
 TextBox box3  =   (TextBox)ItemGv.Rows[rowIndex].Cells[2].FindControl("qtytb");
 TextBox box4 =     (TextBox)ItemGv.Rows[rowIndex].Cells[3].FindControl("upricetb");
 TextBox box5 =     (TextBox)ItemGv.Rows[rowIndex].Cells[4].FindControl("amounttb");
 
                    drCurrentRow = dtCurrentTable.NewRow();
                    
                    drCurrentRow["Qty"] = box3.Text;
                    drCurrentRow["UnitPrice"] = box4.Text;                   
                    drCurrentRow["TotalAmount"] = box5.Text;
                    
                        total = Convert.ToInt32(box3.Text) * Convert.ToSingle(box4.Text);
                        box5.Text = total.ToString();                

                       
                            subtotal = subtotal + Convert.ToSingle(box5.Text);
                            subtotaltb.Text = subtotal.ToString();
                        
                    
                   

                    
                    rowIndex++;