I have to join two tables in c#,the query is working in sql but not in c#

Question

0.00/5 (No votes)

See more:

The error is that "Incorrect syntax near Order"

C#

private void Window_Loaded(object sender, RoutedEventArgs e)
        {
         
 string ID = textBox1.text;
            string Contact = textBox2.Text;
            string Nme = textBox3.Text;
            string Cab = textBox3.Text;

            SqlConnection con = new SqlConnection(@"Data Source=.\SQLEXPRESS;AttachDbFilename=D:\BingMap\WpfApplication1\WpfApplication1\Database1.mdf;Integrated Security=True;User Instance=True");
            con.Open();
            SqlCommand cmd = new SqlCommand("Select u.Phone,u.Name,o.CabType from Customer u join Order o on u.ID=o.OrderID where ID='" + lbid + "'", con);
            cmd.CommandType = CommandType.Text;
            SqlDataReader dr = cmd.ExecuteReader();
            if (dr.Read())
            {
                textBox2.Text = dr[1].ToString();
                textBox3.Text = dr[2].ToString();
                textBox3.Text = dr[1].ToString();

            }
            else
            {
                MessageBox.Show("Data not found");
            }
            con.Close();
        }

Posted 1-Aug-13 19:23pm

Apoorva from Baroda

Updated 1-Aug-13 20:18pm

Maciej Los

v4

Add a Solution

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Apoorva from Baroda · Answer 1 · 2013-08-07T00:34:00

Solution 2

I did one mistake,i have named my table name as Order and Order is a system variable in SQL.
So what i have to do is just change the table name.

Posted 7-Aug-13 0:34am

Apoorva from Baroda

Comments

[no name] 7-Aug-13 6:51am

+5. From me.

Harshil_Raval · Answer 2 · 2013-08-01T19:32:00

Solution 1

Hi,
You are not getting any connection error right? Then check below code
Try this,

SQL

SqlCommand cmd = new SqlCommand("Select u.Phone,u.Name,o.CabType from Customer u join Order o on u.ID=o.OrderID where ID=@ID", con);
cmd.CommandType = CommandType.Text;
cmd.Parameters.AddWithValue("@ID",lbid);
//code to fetch

Posted 1-Aug-13 19:32pm

Harshil_Raval

Comments

Adarsh chauhan 2-Aug-13 1:44am

I agree... as such nothing seems wrong in Apoorva's code. so s/he can try using parametrized query. it will also protect application from sql injection..
+5 Harshil

Apoorva from Baroda 7-Aug-13 6:38am

Thanks Harshil,I found my mistake.My table name was Order and that is system variable in SQL.I have to just change the table name.