Java Help; too many Lines

Question

1.00/5 (3 votes)

See more:

//I need the program to do what it is doing right now, but with less Print lines.

Java

public class AssignmentFour
{
    public static void main(String[] args)
    {
        final int MONDAY = 1;
        final int TUESDAY = 2;
        final int WEDNESDAY = 3;
        final int THURSDAY = 4;
        final int FRIDAY = 5;
        final int SATURDAY = 6;
        final int SUNDAY = 7;
        int day_of_week = 4;

        switch (day_of_week)
        {
        case MONDAY:
            System.out.println("Today's Monday!");
            break;
        case TUESDAY:
            System.out.println("Today's tuesday!");
            break;
        case WEDNESDAY:
            System.out.println("Today's wednesday!");
            break;
        case THURSDAY:
            System.out.println("Today's thursday!");
            break;
        case FRIDAY:
            System.out.println("Today's friday!");
            break;
        case SATURDAY:
            System.out.println("Today's Saturday!");
            break;
        case SUNDAY:
            System.out.println("Today's Sunday!");
            break;
        default:
            System.out.println("Invalid Data");
            break;
        }
    }
}

Posted 24-Sep-13 22:26pm

Member 10296208

Updated 24-Sep-13 22:41pm

pasztorpisti

v3

Add a Solution

Comments

pasztorpisti 25-Sep-13 5:17am

The problem with your solution is not the too many lines but redundancy. Its usually not the shorter code is the better but the code that is easy to read and doesn't have redundancy/copy-paste.

Shubhashish_Mandal 25-Sep-13 13:32pm

4 answers!! Surprise to see that there are so many people ready to do school assignment on request.

4 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

E.F. Nijboer · Answer 1 · 2013-09-24T22:49:00

Solution 1

Simply make sure the imput value is between 1 and 7, then simply lookup the value from an array with the names of the days.

Good luck!

Posted 24-Sep-13 22:49pm

E.F. Nijboer

pasztorpisti · Answer 2 · 2013-09-24T22:52:00

Java 1.5 and later has enum and this is the clean solution:

Java

public class AssignmentFour
{
    enum DayOfWeek
    {
        Monday,
        Tuesday,
        Wednesday,
        Thursday,
        Friday,
        Saturday,
        Sunday,
    }

    public static void main(String[] args)
    {
        DayOfWeek dayOfWeek = DayOfWeek.Thursday;
        System.out.println("Today's " + dayOfWeek + "!");
    }
}

But the teachers are probably interested in the array solution that was already recommended.

Fredrik Bornander · Answer 3 · 2013-09-24T22:53:00

This sounds like homework or something similar, but I'm going to give you the benefit of the doubt on that one.

Try storing your day names in an array, it reduces the number of lines:

Java

public static void main(String[] args)
{
    final String[] days = new String[] { "Monday", "tuesday", "wednesday", "thursday", "friday", "Saturday", "Sunday" };
    int day_of_week = 4;
    try {
       System.out.println(String.format("Today's %s!", days[day_of_week - 1]));
    }
    catch(IllegalArgumentException e) {
       System.out.println("Invalid Data");
    }
}

Hope this helps,
Fredrik

TorstenH. · Answer 4 · 2013-09-24T23:05:00

Simplest (primitive) approach :p

1 line:

Java

public class AssignmentFour{public static void main(String[] args){ final int MONDAY = 1, TUESDAY = 2, WEDNESDAY = 3, THURSDAY = 4, FRIDAY = 5, SATURDAY = 6, SUNDAY = 7;int day_of_week = 4; switch (day_of_week) { case MONDAY: System.out.println("Today's Monday!"); break; case TUESDAY: System.out.println("Today's tuesday!"); break; case WEDNESDAY: System.out.println("Today's wednesday!"); break; case THURSDAY: System.out.println("Today's thursday!"); break; case FRIDAY: System.out.println("Today's friday!"); break;case SATURDAY: System.out.println("Today's Saturday!"); break; case SUNDAY: System.out.println("Today's Sunday!"); break; default: System.out.println("Invalid Data"); break; } }}

Java Help; too many Lines

4 solutions

Solution 1

Solution 2

Solution 3

Solution 4

Add your solution here

Preview 0