Destructor is calling infinite.

Question

1.00/5 (2 votes)

See more:

Hello,

I am getting a problem in cpp.I am just doing like this

C#

~user(){
                current = (account *) first;
                while(current)
                {
                        account *next = current->next;
                        current->~account();
                        current = next;
                }
}

and in the destructor of account i am doing only

cout<<" Destructor of account :: Deleting memory ";
delete this;

Please tell me what i am doing wrong in this.
This is pring Destructor of account :: Deleting memory continouslly.

Thanks in advance.

Posted 23-Dec-13 20:23pm

BaldevS

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

BaldevS · Accepted Answer · 2013-12-23T20:29:00

Solution 1

Thanks.
It is solved.
I have just change one line only and that is
instead of doing current->~account(); i am doing delete(current);
and in destroctor i am doing nothing.

Posted 23-Dec-13 20:29pm

BaldevS

Comments

[no name] 24-Dec-13 3:00am

It may have been better to delete the question when you figured it out. This isn't facebook and no one cares about what happens in every minute of your day. Posts like this just clog up the forum.

BaldevS 24-Dec-13 5:20am

ok..then another question for you..how to delete any question?
I really dont know this.

Timberbird 24-Dec-13 7:09am

Yes, you shouldn't call destructor explicitly. And one more thing about your code

delete this;

Don't do that. Never. That was causing infinite print of your "Deleting memory" message, since deleting an object calls the destructor implicitly. And remember - you should never delete an object from one of its own methods (unless it's a class method, but that's not the case), not only destructor. Every time you write a line

delete this;

, you are dooming your program to experience a hard to discover, unexpected critical errors.

When delete call is finished, control is returned to the method which called it... or at least where this method should be. But now it's not there, since the object is already removed! Well, in most cases that's not the problem, in fact method implementation is still there. But if this block of memory has already been overwritten, your program executes a random block of code it finds in place of a former method. Results? Crash in most cases

BaldevS 24-Dec-13 8:45am

I really appreciate your help but if i wont write "delete(current) " then also it will call my defined destructor or not?
If not then why because after going out of scope the pointer should call the destructor.
Or i need to implement smart pointer for that.

Thanks for this much of explanation for my mistake.

Timberbird 26-Dec-13 6:43am

Sorry, I must have not written it clearly. Everything's ok with code delete [some variable], it's totally legit way to remove an object/whatever when it's no longer needed. But you must never try to delete this, since it leads to the consequences explaied above.
If you want to remove the dynamically created object when it goes out of scope, do it explicitly by calling delete [variable]. If you wand to create an object dynamically and be sure it is removed automatically when going out of scope, not bothering yourself with delete statement, use auto_ptr, for example (I prefer to keep track of my variables myself, so I don't use it much, but it's certainly a valid option).

As to the destructor: when you write delete [object], object's destructor is called automatically. You don't have to call it from your code explicitly, like object->~class(), delete this or whatever