What Is Wrorg In It I M Getting Failed Massage

Question

1.00/5 (3 votes)

See more:

C#

protected void Button1_Click(object sender, EventArgs e)
{
    SqlConnection con = new SqlConnection("Data Source=SHANTANU\\SQLEXPRESS;Initial Catalog=Inventry;Integrated Security=True");
    SqlDataAdapter myadp = new SqlDataAdapter();

    myadp.UpdateCommand = new SqlCommand();
    myadp.UpdateCommand.Connection = con;

    con.Open();

    myadp.UpdateCommand.CommandText = "update purchase set quantity= quantity-'"+(qnt1.Text+qnt2.Text)+"' where item='"+(item1.Text+item2.Text)+"'";

    int i = myadp.UpdateCommand.ExecuteNonQuery();
    if (i ==1)
    {
        Response.Write("<script>alert('updated')</script>");
    }
    else
    {
        Response.Write("<script>alert('Failed')</script>");
    }

    con.Close();
}

Posted 2-Jan-14 2:34am

Shantanu sinha

Updated 2-Jan-14 2:43am

Kornfeld Eliyahu Peter

v3

Add a Solution

Comments

Kornfeld Eliyahu Peter 2-Jan-14 8:41am

What the message is?

Shantanu sinha 2-Jan-14 8:56am

actually i have made a table with name "item" and "quantity" i want to update the database when i am selling the product where the query will search the item from the "itm.text" (textbox) and will update (it will minus) the present quantity by the number in the qnt.text(textbox).
it is working fine for 1 item but if i m using it for more than 1 product it is not getting updated. rather i am getting the error massage "failed" which i have put in last line of the code.

Thomas Daniels 2-Jan-14 8:42am

What's the error message?

Shantanu sinha 2-Jan-14 8:49am

the value is not getting subtracted

Thomas Daniels 2-Jan-14 8:52am

At which line do you get the error?

Member 10434230 2-Jan-14 8:43am

can you post database query which is getting executed, you can easily find it in profiler.

Shantanu sinha 2-Jan-14 8:51am

create database Inventry;
use Inventry;
create table purchase
(
item varchar(800),rate varchar(800),quantity varchar(800)
);
select * from purchase;
Alter table purchase Alter Column quantity int;
Alter table purchase Alter Column item varchar(200);

Vinay Jade 2-Jan-14 8:55am

we cant subtract varchar from varchar use int for quantity

Shantanu sinha 2-Jan-14 9:07am

i did that i updated the table in the database
but still it is not working
the solution is working fine for 1 item and 1 quantity but if i have to do it to more it is not working.

Vinay Jade 2-Jan-14 8:53am

add brekpoint near int i = myadp.UpdateCommand.ExecuteNonQuery(); and check what value is coming in i variable

4 solutions

Solution 2

where item='"+(item1.Text+item2.Text)+"'
That looks very strange. I would not expect the identifier of the item to be split over two textboxes.
Do you want to update two rows (i.e. the data for two items)? Then send two individual update requests, in one transaction.

Posted 2-Jan-14 2:53am

Bernhard Hiller

Comments

Shantanu sinha 2-Jan-14 9:03am

how can i do that

Shantanu sinha 2-Jan-14 9:04am

it means that i have to call two update commands. i tried that too but the value which was at last command got updated.

Bernhard Hiller 2-Jan-14 9:14am

myadp.UpdateCommand.CommandText = "update purchase set quantity= quantity-'"+qnt1.Text+"' where item='"+item1.Text+"'";
int i = myadp.UpdateCommand.ExecuteNonQuery();
myadp.UpdateCommand.CommandText = "update purchase set quantity= quantity-'"+qnt2.Text+"' where item='"+item2.Text+"'";
i += myadp.UpdateCommand.ExecuteNonQuery();
if (i == 2) ...

Shantanu sinha 2-Jan-14 9:30am

int i+= myadp.UpdateCommand.ExecuteNonQuery(); here i am getting error
Error 1 Invalid expression term '+=' C:\the who software\WebSite2\sale.aspx.cs 37 18 C:\the who software\WebSite2\

Shantanu sinha 4-Jan-14 21:52pm

it helped little and finally i made my logic.really txs a lot

Solution 3

try this

C#

int value = Convert.ToInt32( qnt1.Text) + Convert.ToInt32( qnt2.Text);
           int item = Convert.ToInt32( item1.Text) + Convert.ToInt32( item2.Text);
           myadp.UpdateCommand.CommandText = "update purchase set quantity= quantity-"+ value+" where item='"+ item+"'";

Posted 2-Jan-14 3:54am

Karthik_Mahalingam

Comments

Shantanu sinha 2-Jan-14 10:04am

sir ji i dont have to add the values..

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

♥…ЯҠ…♥ · Accepted Answer · 2014-01-02T02:49:00

Hi Shantanu,

If you use ExecuteNonQuery(), then

For UPDATE, INSERT, and DELETE statements, the return value is the number of rows affected by the command.

So I think the number of rows updated may be greater than 1 so its error in your condition.
Try this

C#

if (i > -1)
           {
               Response.Write("<script>alert('updated')</script>");
           }
           else
           {
               Response.Write("<script>alert('Failed')</script>");
           }

Updated solution

I hope this is something wrong with concatenation,So try this

SQL

"quantity= quantity-'"+(Convert.ToInt32(qnt1.Text)+Convert.ToInt32(qnt2.Text))+"' where item='"+(Convert.ToInt32(item1.Text)+Convert.ToInt32(item2.Text))+"'";

Hope this helps you a bit.

Regards,
RK

Shantanu sinha · Accepted Answer · 2014-01-02T04:05:00

C#

protected void Button1_Click(object sender, EventArgs e)
{
    SqlConnection con = new SqlConnection("Data Source=SHANTANU\\SQLEXPRESS;Initial Catalog=Inventry;Integrated Security=True");
    SqlDataAdapter myadp = new SqlDataAdapter();
      myadp.UpdateCommand = new SqlCommand();
      myadp.UpdateCommand.Connection = con;
      con.Open();
      myadp.UpdateCommand.CommandText = "update purchase set quantity= quantity-'"+qnt1.Text+"' where item='"+item1.Text+"'";
      int i = myadp.UpdateCommand.ExecuteNonQuery();
        if (i==1)
        {
            Response.Write("<script>alert('updated')</script>");
        }
        else
        {
            Response.Write("<script>alert('Failed')</script>");
        }
        con.Close();
        con.Open();
        myadp.UpdateCommand.CommandText = "update purchase set quantity= quantity-'" + qnt2.Text + "' where item='" + item2.Text+ "'";
        int j = myadp.UpdateCommand.ExecuteNonQuery();
        if (j == 1)
        {
           // Response.Write("<script>alert('updated')</script>");
        }
        else
        {
            Response.Write("<script>alert('Failed')</script>");
        }
        con.Close();
        con.Open();
        myadp.UpdateCommand.CommandText = "update purchase set quantity= quantity-'" + qnt3.Text + "' where item='" + item3.Text + "'";
        int k = myadp.UpdateCommand.ExecuteNonQuery();
        if (k == 1)
        {
           // Response.Write("<script>alert('updated')</script>");
        }
        else
        {
           // Response.Write("<script>alert('Failed')</script>");
        }
        con.Close();
        con.Open();
        myadp.UpdateCommand.CommandText = "update purchase set quantity= quantity-'" + qnt4.Text + "' where item='" + item4.Text + "'";
        int l = myadp.UpdateCommand.ExecuteNonQuery();
        if (l == 1)
        {
          //  Response.Write("<script>alert('updated')</script>");
        }
        else
        {
          //  Response.Write("<script>alert('Failed')</script>");
        }
        con.Close();
        con.Open();
        myadp.UpdateCommand.CommandText = "update purchase set quantity= quantity-'" + qnt5.Text + "' where item='" + item5.Text + "'";
        int m = myadp.UpdateCommand.ExecuteNonQuery();
        if (m == 1)
        {
            Response.Redirect("sale.aspx");
            //Response.Write("<script>alert('updated')</script>");
        }
        else
        {
           // Response.Write("<script>alert('Failed')</script>");
        }
        con.Close();
        Response.Redirect("sale.aspx");

code block corrected

What Is Wrorg In It I M Getting Failed Massage

4 solutions

Solution 1

Solution 2

Solution 3

Solution 4

Add your solution here

Preview 0