Why records not moving

Question

0.00/5 (No votes)

See more:

SQL-Server-2008

Two records in my database.when i click on next button then one error message coming
"There is no row at position 1"
i am using below code .
anyone please help me where i am doing mistake in code.

C#

using System;
using System.Collections.Generic;
using System.ComponentModel;
using System.Data;
using System.Drawing;
using System.Linq;
using System.Text;
using System.Windows.Forms;
using System.Data.SqlClient;

namespace MyProject
{

    public partial class Form1 : Form
    {
        int i = 0;
        
        public Form1()
        {
            InitializeComponent();
        }

       private void Form1_Load(object sender, EventArgs e)
        {
           SqlConnection conn = new SqlConnection(@"Data Source=.\SQLEXPRESS;AttachDbFilename=C:\Users\manish\Documents\HRM.mdf;Integrated Security=True;Connect Timeout=30;User Instance=True");
            conn.Open();
            SqlCommand command = new SqlCommand("select * from emp_detail", conn);
            SqlDataAdapter adp = new SqlDataAdapter(command);
            DataTable tbl = new DataTable();
            adp.Fill(tbl);
            display(tbl);
       }
           private void display(DataTable tbl)
           {
           txtempid.Text = tbl.Rows[i][0].ToString();
            txtname.Text = tbl.Rows[i][1].ToString();
            txtsurname.Text = tbl.Rows[i][2].ToString();
            txtfathername.Text = tbl.Rows[i][3].ToString();
            dtdob.Text = tbl.Rows[i][4].ToString();
            cbgender.Text = tbl.Rows[i][5].ToString();
            cbcity.Text = tbl.Rows[i][6].ToString();
            txtcontactno.Text = tbl.Rows[i][7].ToString();
            dtdoj.Text = tbl.Rows[i][8].ToString();
            txtdept.Text = tbl.Rows[i][9].ToString();
            txtdesig.Text = tbl.Rows[i][10].ToString();
            txtqualification.Text = tbl.Rows[i][11].ToString();
            rtaddress.Text = tbl.Rows[i][12].ToString();
            rtremarks.Text = tbl.Rows[i][13].ToString();
            
        }
           private void button8_Click(object sender, EventArgs e)
           {
               DataTable tbl = new DataTable();

               if (i > tbl.Rows.Count - 1)
               {
                   i++;

                   display(tbl);
               }
               else
               {
                   MessageBox.Show("this is last records");
               }
           }

Posted 19-Mar-14 2:24am

manish7664

Updated 19-Mar-14 2:26am

george4986

v4

Add a Solution

Comments

CHill60 19-Mar-14 8:29am

I presume button8 is your "Next button" ? You create a new DataTable tbl but don't populate it

ZurdoDev 19-Mar-14 8:31am

I think you want < in your if statement in the button click. If I follow the way you have it now you are saying if the current record is greater than the number of rows then increment the row counter and display the table. I think you mean <

However, this is easily solved if you use a breakpoint and step through the code. You'll see exactly what is happening. No need for mysteries.

3 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Jawad Ahmed Tanoli · Answer 1 · 2014-03-19T02:32:00

using System;
using System.Collections.Generic;
using System.ComponentModel;
using System.Data;
using System.Drawing;
using System.Linq;
using System.Text;
using System.Windows.Forms;
using System.Data.SqlClient;
 
namespace MyProject
{
 
    public partial class Form1 : Form
    {
        int i = 0;
        DataTable tbl = new DataTable();
        public Form1()
        {
            InitializeComponent();
        }
 
    private void Form1_Load(object sender, EventArgs e)
    {
        SqlConnection conn = new SqlConnection(@"Data Source=.\SQLEXPRESS;AttachDbFilename=C:\Users\manish\Documents\HRM.mdf;Integrated Security=True;Connect Timeout=30;User Instance=True");
        conn.Open();
        SqlCommand command = new SqlCommand("select * from emp_detail", conn);
        SqlDataAdapter adp = new SqlDataAdapter(command);
        //DataTable tbl = new DataTable();
        adp.Fill(tbl);
        display(tbl);
    }
    private void display(DataTable tbl)
    {
        txtempid.Text = tbl.Rows[i][0].ToString();
        txtname.Text = tbl.Rows[i][1].ToString();
        txtsurname.Text = tbl.Rows[i][2].ToString();
        txtfathername.Text = tbl.Rows[i][3].ToString();
        dtdob.Text = tbl.Rows[i][4].ToString();
        cbgender.Text = tbl.Rows[i][5].ToString();
        cbcity.Text = tbl.Rows[i][6].ToString();
        txtcontactno.Text = tbl.Rows[i][7].ToString();
        dtdoj.Text = tbl.Rows[i][8].ToString();
        txtdept.Text = tbl.Rows[i][9].ToString();
        txtdesig.Text = tbl.Rows[i][10].ToString();
        txtqualification.Text = tbl.Rows[i][11].ToString();
        rtaddress.Text = tbl.Rows[i][12].ToString();
        rtremarks.Text = tbl.Rows[i][13].ToString();
    }
    private void button8_Click(object sender, EventArgs e)
    {
        //DataTable tbl = new DataTable();
 
        if (i <=tbl.Rows.Count)
        {
        i++;
 
        display(tbl);
    }
    else
    {
        MessageBox.Show("this is last records");
    }
}

CHill60 · Answer 2 · 2014-03-19T02:35:00

Further to Jawad Ahmed Tanoli's solution...

The cause of your problem is Variable Scope[^]

The DataTable tbl is not the same as the tbl in your Button8_Click event!

What Jawad's code does is move the declaration of DataTable tbl to Form level scope, so the same instance (i.e. the data that is loaded at Form_Load) is available to all the functions within this Form class.

Jawad Ahmed Tanoli · Answer 3 · 2014-03-19T02:39:00

Solution 3

C#

private void button8_Click(object sender, EventArgs e)
          {
              DataTable tbl = new DataTable();
//this datatable tbl is not filled here with data
              if (i > tbl.Rows.Count - 1)
              {
                  i++;

                  display(tbl);
              }
              else
              {
                  MessageBox.Show("this is last records");
              }
          }

Posted 19-Mar-14 2:39am

Jawad Ahmed Tanoli

Comments

CHill60 19-Mar-14 8:41am

Why have you posted this as another solution? It is already in your original post. You can use the "Improve Solution" link to update your answer if necessary.
See also my solution - I've explained *why* that datatable is not filled with data

Jawad Ahmed Tanoli 19-Mar-14 8:45am

Chill60 i just want to post that piece of code.

Why records not moving

3 solutions

Solution 1

Solution 2

Solution 3

Add your solution here

Preview 0