Using String.Format to format a Address

Question

0.00/5 (No votes)

See more:

I have a class with properties Street, PoBox, City. Some can have empty values from these. I want to give a method to take full address from those methods like
Street,
PoBox,
City.

How can I create this by using string.format. When I'm using this, if any property has empty it gives empty line.

[edit]Minor corrections for readability[/edit]

My code is like this

C#

string street = "AAA";
string city = string.Empty;
string country = "SSS";

string add = string.Format("{0}\n{1}\n{2}",street, city, country);
Console.WriteLine(add);

Result:

AA

SSS

My problem is when city is empty, extra line comes between the street and county.

Posted 4-Apr-11 18:42pm

Sanyon_d

Updated 4-Apr-11 20:35pm

Sergey Alexandrovich Kryukov

v3

Add a Solution

6 solutions

Solution 1

String.Format won't return an empty string if some of the values are null. For example:

C#

string val1 = null;
string val2 = "Something";

string.Format("Test: {0}/{1}", val1, val2);

Gives Test: /Something
So perhaps you have some other problem. Using the debugger try to isolate the part where the return string is getting empty.

Posted 4-Apr-11 18:58pm

Wendelius

Comments

Sergey Alexandrovich Kryukov 5-Apr-11 2:38am

Good point. The solution is obvious, so... a 5.
--SA

Michel [mjbohn] 5-Apr-11 3:00am

This solution takes care of null value, but won't solve the empty row prob that Sanjeewabdissa was asking. Nonetheless a good answer

Sergey Alexandrovich Kryukov 5-Apr-11 3:22am

Well... yes I agree. I added my Answer :-)
--SA

Sanyon_d 5-Apr-11 4:12am

I got the answer,
fullAddress =string.Format("{0}\n{1}\n{2}",val1,val2,val3);
fullAddress = fullAddress.Replace("\n\n", "\n");

Solution 7

Try This--

string street = "AAA"; 
string city = string.Empty;
string country = "SSS";
string FullAddress=string.Format("{0}{1}{2}{3}{4}",street ,(string.IsNullorEmpty(street)?"":Enviornment.NewLine),city,(string.IsNullorEmpty(city)?"":Enviornment.NewLine),country)

--Pankaj

Posted 4-Apr-11 21:25pm

pankajupadhyay29

Comments

Olivier Levrey 5-Apr-11 3:55am

This will work as well but I don't really like copied/pasted code (you duplicated the IsNullOrEmpty and ?: test).
Voted 4.

Solution 4

Give StringBuilder a try

StringBuilder sb = new StringBuilder();

if (street != string.emty)
sb.AppendLine(street);

if (city != string.emty)
sb.AppendLine(city);

if (country != string.emty)
sb.AppendLine(country);

Console.WriteLite(sb.toString());

Posted 4-Apr-11 19:28pm

Michel [mjbohn]

Comments

Sergey Alexandrovich Kryukov 5-Apr-11 2:37am

That will work, my 3.
Why 3? because you should not assume non-null.
--SA

Solution 5

you can also try it

C#

string street = "AAA";
            string city = string.Empty;
            string country = "SSS";
           
 string  add = street + "\n" + city + "\n" + country;
            string[] Adress = add.Split((string[])null, StringSplitOptions.RemoveEmptyEntries);
            foreach (string str in Adress)
            {
                Console.WriteLine(str);
            }

output :-
AAA
SSS

Posted 4-Apr-11 19:33pm

RaviRanjanKr

Comments

Olivier Levrey 5-Apr-11 3:52am

It looks a litte bit more complicated but will work.
And it is better to use Environment.NewLine instead of hardcoded '\n'.
Voted 4.

Solution 3

[Moved to Question]
OP should not post this text as Answer, to be removed. Next time, use "Improve answer", "Add comment" or reply to existing comment.

Posted 4-Apr-11 19:06pm

Sanyon_d

Updated 4-Apr-11 20:36pm

v2

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Sergey Alexandrovich Kryukov · Accepted Answer · 2011-04-04T20:45:00

Solution 6

Use something like this:

C#

System.Text.StringBuilder sb = new System.Text.StringBuilder();
void AddLine(string value) {
   if (!string.IsNullOrEmpty(value))
      sb.AppendLine(value); 
}
void AddLines(string[] values) {
   foreach(value in values)
      AddLine(value); 
}

//...

AddLines(new string[] {street, city, country, phone, email, }); // :-)

—SA

Posted 4-Apr-11 20:45pm

Sergey Alexandrovich Kryukov

Comments

Olivier Levrey 5-Apr-11 3:50am

Who downvoted this?? This answer is perfectly correct. My 5 SA.

Sergey Alexandrovich Kryukov 5-Apr-11 13:17pm

Thank you Olivier.
--SA

Michel [mjbohn] 5-Apr-11 3:58am

Who thinks this answer deserves a vote of 1? Just can't follow
my 5

Sergey Alexandrovich Kryukov 5-Apr-11 13:17pm

Thank you very much. (This happens :=<)
--SA

Kim Togo 5-Apr-11 9:30am

Good solution. I will borrow that :-)

Sergey Alexandrovich Kryukov 5-Apr-11 12:55pm

Great.
Will you also formally accept this Answer?
Thank you.
--SA

Wendelius 5-Apr-11 13:38pm

Good answer, my 5

Sergey Alexandrovich Kryukov 5-Apr-11 13:54pm

Thank you, Mika.
--SA