How to get the query to return more than 1 record?

Question

1.00/5 (1 vote)

See more:

I would like to get my method to return more than one query result. the current method, is only outputting 1 record. Please advise - Thank you

What I have tried:

SQL

SqlDataReader reader = command.ExecuteReader();
                    while (reader.Read())
                    {
                        string title = reader.GetString(0);  
                        string body = reader.GetString(4);

                        string pub = reader["publication_id"].ToString();
                        string iss = reader["issue_id"].ToString();
                        string sid = reader["STORYID"].ToString(); 


                        string c = url(title, pub, iss, sid);

            DateTime dt = DateTime.Today;

            XElement xeRoot = new XElement("article");

            XElement xeStatus = new XElement("status", "Approved");
            xeRoot.Add(xeStatus);

            XElement xeTitle = new XElement("title", title);
            xeRoot.Add(xeTitle);

            XElement xeSubTitle = new XElement("subtitle", title);
            xeRoot.Add(xeSubTitle);

            XElement xeSynopsis = new XElement("synopsis", body + "...");
            xeRoot.Add(xeSynopsis);

            XElement xeURL = new XElement("url", c);
            xeRoot.Add(xeURL);

            XElement xeDisplayDate = new XElement("display_date", dt);
            xeRoot.Add(xeDisplayDate);

            XDocument xDoc = new XDocument(xeRoot);
            return xDoc.ToString();

                    }
                }
            }
            return null;
      
        }

Posted 17-Jun-16 3:29am

miss786

Updated 17-Jun-16 3:36am

PIEBALDconsult

v2

Add a Solution

Comments

PIEBALDconsult 17-Jun-16 9:34am

How do you know it isn't? You'll need places to put them.

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Accepted Answer · 2016-06-17T03:36:00

Solution 1

Well...let's rip some code out of your sample:

C#

SqlDataReader reader = command.ExecuteReader();
while (reader.Read())
{
    string title = reader.GetString(0);  
    ...
    XDocument xDoc = new XDocument(xeRoot);
    return xDoc.ToString();

}

You return from the method at the end of the first loop...

Posted 17-Jun-16 3:36am

OriginalGriff

Comments

miss786 17-Jun-16 9:43am

Hi, Thank you for your suggestion and help. I am little unclear in regards your solution. Should i be returning the method outside the loop? Thanks

OriginalGriff 17-Jun-16 9:57am

Well it'd help ... as soon as your code meets a return statement, that's it - the method is over. So if your loop ends with return, it will always exit at the end of the first row.
But... it doesn't look like you've thought about that code at all - the code inside the loop doesn't look like it does anything that can be "carried on" to teh next iteration.
It's as if you said:

int i = 0;
while (reader.Read())
{
i = (int) reader["value"];
}

The value of i will always be the value of the last row in the reader, because it overwrites the value each time it gores round the loop.

Now, I have no idea what you are trying to do, or how it fits into the rest of your app - but if you want to process multiple rows, you need to do something other than "overwrite each time" as you are at the moment.