What's wrong with my code? It's working only for one item in list.

Question

1.00/5 (2 votes)

See more:

Whats wrong with My code?
I tried to update quantity for each product in shopping cart, but it's not working for every product in list separately.

PHP

<?php
  global $con;
  
  include("includes/db.php");
  
  $ip = getIp();

  if(isset($_POST['update_cart'])){
  
  $qty = $_POST['qty'];

  $update_qty = "update cart set qty='$qty' where ip_add='$ip'";
  
  $run_qty = mysqli_query($con, $update_qty);

  $_SESSION['qty']=$qty;

  $total = $total*$qty;
  
  }
?>

What I have tried:

PHP

<?php				
  global $con;
					
  include("includes/db.php");
					
  $ip = getIp();

  if(isset($_POST['update_cart'])){
					
    $qty = $_POST['qty'];

    $update_qty = "update cart set qty='$qty' where ip_add='$ip'";
					
    $run_qty = mysqli_query($con, $update_qty);

    $_SESSION['qty']=$qty;

    $total = $total*$qty;
					
  }
?>

Posted 21-Sep-17 7:05am

Member 13422296

Updated 21-Sep-17 15:02pm

Mohibur Rashid

v2

Add a Solution

Comments

eddieangel 21-Sep-17 16:05pm

Did you query the database to ensure that all of the items in the cart actually have the correct ip? If so is the database being updated correctly but not your session variable?

Member 13422296 22-Sep-17 7:49am

You are right.
So please suggest me the right code.
I will be thankful to you.

And thanks for responding

Mohibur Rashid 21-Sep-17 21:20pm

Your question is not clear enough. And Your code does how you wrote it, if ip_add is unique, it's not going to update more than one item.
<
mysqli_query($con, $update_qty); will return number rows those are being updated.

Member 13422296 22-Sep-17 7:48am

So please suggest me the right code.
I will be thankful to you.

Member 13422296 22-Sep-17 7:49am

And thank you very much for responding.💐

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Patrice T · Answer 1 · 2017-09-21T15:02:00

Quote:
I tried to update quantity for each product in shopping cart, but it's not working for every product in list separately.

As I understand your query, it update the quantity of all items in cart because you don't say which item (in cart) you want to update.
-----
Question: you use the user public ip as identification, but what happen when 2 users working in same company have same public ip ?
-----

PHP

$update_qty = "update cart set qty='$qty' where ip_add='$ip'";

Not a solution to your question, but another problem you have.
Never build an SQL query by concatenating strings. Sooner or later, you will do it with user inputs, and this opens door to a vulnerability named "SQL injection", it is dangerous for your database and error prone.
A single quote in a name and your program crash. If a user input a name like "Brian O'Conner" can crash your app, it is an SQL injection vulnerability, and the crash is the least of the problems, a malicious user input and it is promoted to SQL commands with all credentials.
SQL injection - Wikipedia[^]
SQL Injection[^]
SQL Injection Attacks by Example[^]
PHP: SQL Injection - Manual[^]
SQL Injection Prevention Cheat Sheet - OWASP[^]