Click here to Skip to main content
15,867,704 members
Articles / .NET
Article

Bug when using the java.util.zip classes to write zip files

Rate me:
Please Sign up or sign in to vote.
4.58/5 (16 votes)
8 May 2004CPOL2 min read 135.8K   23   22
Describes an issue when writing a binary file into a zip file using the java.util.zip classes

Introduction

I was writing a little .NET app in C# and was looking for a small library that would let me read and write zip files. That's when my first Google search gave me a link to Using the Zip Classes in the J# Class Libraries to Compress Files and Data with C#. Great! - that was my first reaction, but it didn't last too long. You can read zip files alright, but when you write zip files, if you have binary files (as you most often will), the generated zip file will be corrupt and you can't read it back. Funnily, WinZip does open it (ignoring the header errors) and the suggested solution by a Microsoftie in the one of the MS NGs was to extract all files using WinZip and then to zip it back. LOL. Why'd anyone want to use the zipping libraries at all if they had the option of bringing WinZip into the picture?

There is not even a KB article on this bug - bad! I lost about half a day when I was using these classes because I initially thought it was something wrong in my code. Anyway, this is a warning to everyone. Do not use the J# class libraries for zipping/unzipping if you are using the BCL 1.1 version. Heath Stewart (C# MVP and CodeProject Editor) has informed me that the BCL 2.0 includes zipping functionality - so that's really good news. And until that comes out, a very good free alternative to the J# classes is SharpZipLib which I very strongly recommend.

Bug demo

  1. Create a new C# console app project
  2. Add a reference to vjslib (...Microsoft.NET\Framework\v1.1.4322\vjslib.dll)
  3. Copy/paste the following code into your main cs file :-
    C#
    using System;
    using System.IO;
    using java.util.zip;
    
    class MainClass
    {
      [STAThread]
      static void Main(string[] args)
      {
        BugDemo();
      }
    
      static void BugDemo()
      {
        //Write zip file
        ZipOutputStream os = new ZipOutputStream(
          new java.io.FileOutputStream("test.zip"));
        ZipEntry ze = new ZipEntry("gluk.gif");
        ze.setMethod(ZipEntry.DEFLATED);
        os.putNextEntry(ze);
        java.io.FileInputStream fs = 
          new java.io.FileInputStream("gluk.gif");
        sbyte[] buff = new sbyte[1024];
        int n = 0;
    
        while ((n=fs.read(buff,0,buff.Length))>0)
        {
          os.write(buff,0,n);
        }
        fs.close();
        os.closeEntry();      
        os.close();
    
        Console.WriteLine("Okay, the zip has been written.");
    
        //Read zip file
        try
        {
          //Bug will occur here
          ZipFile zf = new ZipFile("test.zip");  
        }
        catch
        {
          Console.WriteLine("Bug confirmed!");
        }
      }
    }
  4. Now make sure you have a gluk.gif in the same folder as the executable.

  5. Compile and run.

Workaround

There is no real workaround to the problem. You can use the alternative library I mentioned above or wait for Whidbey.

License

This article, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)


Written By
United States United States
Nish Nishant is a technology enthusiast from Columbus, Ohio. He has over 20 years of software industry experience in various roles including Chief Technology Officer, Senior Solution Architect, Lead Software Architect, Principal Software Engineer, and Engineering/Architecture Team Leader. Nish is a 14-time recipient of the Microsoft Visual C++ MVP Award.

Nish authored C++/CLI in Action for Manning Publications in 2005, and co-authored Extending MFC Applications with the .NET Framework for Addison Wesley in 2003. In addition, he has over 140 published technology articles on CodeProject.com and another 250+ blog articles on his WordPress blog. Nish is experienced in technology leadership, solution architecture, software architecture, cloud development (AWS and Azure), REST services, software engineering best practices, CI/CD, mentoring, and directing all stages of software development.

Nish's Technology Blog : voidnish.wordpress.com

Comments and Discussions

 
Questionhow to open and read files from a zip file using jsp or java Pin
sandhyamn8-Jun-07 19:56
sandhyamn8-Jun-07 19:56 
GeneralJava Zip Pin
SanjitP11-Apr-07 22:28
SanjitP11-Apr-07 22:28 
GeneralRe: Java Zip Pin
WajeehAhmed16-Apr-07 1:30
WajeehAhmed16-Apr-07 1:30 
QuestionAlternative? Pin
evoluzion22-Dec-06 11:02
evoluzion22-Dec-06 11:02 
AnswerRe: Alternative? Pin
Brad Bruce22-Dec-06 11:19
Brad Bruce22-Dec-06 11:19 
GeneralVB convert procedure Pin
Alessandro Betti17-May-06 6:56
Alessandro Betti17-May-06 6:56 
Generalon text files Pin
dvsr27-Dec-05 13:33
dvsr27-Dec-05 13:33 
GeneralAlternative (with code) Pin
Elmue17-Nov-05 2:30
Elmue17-Nov-05 2:30 
GeneralA fix available from M$ Pin
rshearer31-Aug-05 10:43
rshearer31-Aug-05 10:43 
GeneralAnother big problem Pin
nahumtakum15-May-04 0:31
nahumtakum15-May-04 0:31 
Questionis it really corrupt? Pin
Radeldudel10-May-04 21:11
Radeldudel10-May-04 21:11 
AnswerRe: is it really corrupt? Pin
Nish Nishant10-May-04 21:36
sitebuilderNish Nishant10-May-04 21:36 
GeneralRe: is it really corrupt? Pin
Radeldudel10-May-04 21:53
Radeldudel10-May-04 21:53 
GeneralRe: is it really corrupt? Pin
Nish Nishant10-May-04 22:40
sitebuilderNish Nishant10-May-04 22:40 
GeneralRe: is it really corrupt? Pin
Radeldudel10-May-04 22:44
Radeldudel10-May-04 22:44 
GeneralTry this code Pin
Valeri Makarov9-May-04 5:56
Valeri Makarov9-May-04 5:56 
GeneralRe: Try this code Pin
Nish Nishant9-May-04 6:18
sitebuilderNish Nishant9-May-04 6:18 
GeneralRe: Try this code Pin
foxrobert12-May-04 21:54
foxrobert12-May-04 21:54 
GeneralRe: Try this code Pin
Valeri Makarov12-May-04 22:49
Valeri Makarov12-May-04 22:49 
QuestionWorks fine for me ? Pin
Bee Master9-May-04 5:36
Bee Master9-May-04 5:36 
AnswerRe: Works fine for me ? Pin
Nish Nishant9-May-04 6:14
sitebuilderNish Nishant9-May-04 6:14 
GeneralRe: Works fine for me ? Pin
Bee Master11-May-04 5:58
Bee Master11-May-04 5:58 

General General    News News    Suggestion Suggestion    Question Question    Bug Bug    Answer Answer    Joke Joke    Praise Praise    Rant Rant    Admin Admin   

Use Ctrl+Left/Right to switch messages, Ctrl+Up/Down to switch threads, Ctrl+Shift+Left/Right to switch pages.