C# Discussion Boards - CodeProject

Sascha Lefèvre19-Jun-15 12:53

19-Jun-15 12:53

Suggestions:

If this isn't a quickly abstracted example but your actual code then don't include the type name in the name of fields or properties and also not the class name. "PDVString" doesn't convey any useful meaning. If it is a description, name it "Description" or likewise for whatever it is.

And to me it looks like you could just as well make it a base class member. For handhelds it will contain the description (or whatever) for handhelds and else for non-handhelds. Likewise you could replace the TextBoxes "txtPDV" and "txtPDVHH" by a single TextBox "txtDescription" and thus do away with any type distinction:

var pdv1 = isHandheld /* == true */ ? (basePDV)new PDVHH() : (basePDV)new PDV();
                      // ^^^ superfluous because isHandheld already is a boolean

txtCaseID.Text = pdv1.CaseID;
txtDescription.Text = pdv1.Description;

If the brain were so simple we could understand it, we would be so simple we couldn't. — Lyall Watson

Re: Inheritance

JammoD8719-Jun-15 21:26

JammoD87

19-Jun-15 21:26

Hi Both,

Thanks for the replies, I think I need to look into changing this solution. Smile | :)

Personal Blog: A Software Programmer
Twitter: JammoD

C# need 2 threads for long execution

dracebus19-Jun-15 8:48

dracebus

19-Jun-15 8:48

Hi there, this is my first post, sorry if I dont get it right on the first time.
I have a program that loads data from a sharepoint.
It loads txt files, xml files, etc.
Any of these "load" actions take a lot of time because of the user's connectivity to the sharepoint.
Therefore the whole windows form UI gets unresponsive until the data is loaded.

So I would like to learn how can I easily create a thread for that "retrieval" of information while the whole windows forms UI still works and is operative.

Thanks in advance.

This is an example of one of the longest tasks, and I would like to encapsulate it into a new thread if possible

XmlDataDocument xmlDoc = new XmlDataDocument();
string str = "http://www.w3schools.com/xml/note.xml"

            WebRequest request = WebRequest.Create(str);
            request.Timeout = 30 * 60 * 1000;
            request.UseDefaultCredentials = true;
            request.Proxy.Credentials = request.Credentials;
            WebResponse response = (WebResponse)request.GetResponse();
            using (Stream fs = response.GetResponseStream())
            
            xmlDoc.Load(fs);

Re: C# need 2 threads for long execution

PIEBALDconsult19-Jun-15 8:59

PIEBALDconsult

19-Jun-15 8:59

One way is:
https://msdn.microsoft.com/en-us/library/system.componentmodel.backgroundworker.aspx[^]

Re: C# need 2 threads for long execution

dracebus19-Jun-15 9:02

dracebus

19-Jun-15 9:02

can you give me an example of how to use it?
thanks

Re: C# need 2 threads for long execution

PIEBALDconsult19-Jun-15 9:12

PIEBALDconsult

19-Jun-15 9:12

Nope.

Re: C# need 2 threads for long execution

Dave Kreskowiak19-Jun-15 9:21

Dave Kreskowiak

19-Jun-15 9:21

You didn't scroll down the page that link brought up, did you?

A guide to posting questions on CodeProject

Click this: Asking questions is a skill.
Seriously, do it.

Dave Kreskowiak

Re: C# need 2 threads for long execution

Philippe Mori19-Jun-15 16:20

Philippe Mori

19-Jun-15 16:20

Can you read the documentation?

Philippe Mori

Trying to sum several fields into a total field

Norris Chappell18-Jun-15 16:17

Norris Chappell

18-Jun-15 16:17

Posted on 17 Jun 2015

Requirement Year Qtr.1 Q1IntProc Q1IntProj

CMMICAMSG1 2015 7 4 1

Q1ExtBSI Q1ExtCMMI

0 2

I am trying to sum several fields into one.

This code is giving me the I am getting the Object reference not set to an instance of an object error here:

int lblQtr1 = int.Parse(Q1IntProc.Text) + int.Parse(Q1IntProj.Text) + int.Parse(Q1ExtBSI.Text) + int.Parse(Q1ExtCMMI.Text);

protected void gvInternalAudit_RowDataBound(object sender, GridViewRowEventArgs e)
{

if (e.Row.RowType == DataControlRowType.DataRow)
{

Label Qtr1 = (Label)e.Row.FindControl("lblQtr1");
Label Q1IntProc = (Label)e.Row.FindControl("lblQ1IntProc");
Label Q1IntProj = (Label)e.Row.FindControl("lblQ1IntProj");
Label Q1ExtBSI = (Label)e.Row.FindControl("lblQ1ExtBSI");
Label Q1ExtCMMI = (Label)e.Row.FindControl("lblQ1ExtCMMI");

int lblQtr1 = int.Parse(Q1IntProc.Text) + int.Parse(Q1IntProj.Text) + int.Parse(Q1ExtBSI.Text) + int.Parse(Q1ExtCMMI.Text);

Qtr1.Text = lblQtr1.ToString();

}

}

Here is all of my code:

using System;
using System.Data;
using System.Collections.Generic;
using System.Linq;
using System.Web;
using System.Drawing;
using System.Web.UI;
using System.Web.UI.WebControls;
using System.Data.Sql;
using System.Data.SqlClient;
using System.Configuration;
using System.Web.UI.WebControls.WebParts;

namespace HIMSLA.InternalAudit
{
    public partial class InternalAuditUserControl : UserControl
    {
        public SqlConnection conn = new SqlConnection(ConfigurationManager.ConnectionStrings["SQLMedTestConnHIM"].ConnectionString);
        SqlCommand cmd = new SqlCommand();
        protected void Page_Load(object sender, EventArgs e)
        {
            lblMsg.Text = "";
            if (!Page.IsPostBack)
            {
                BindSubjectData();
            }
        }
       
        //call to bind gridview
        protected void BindSubjectData()
        {
            using (SqlConnection sqlCon = new SqlConnection(ConfigurationManager.ConnectionStrings["SQLMedTestConnHIM"].ConnectionString))
            {
                using (SqlCommand cmd = new SqlCommand())
                {
                    cmd.CommandText = "SELECT * FROM InternalAudit  order by Requirement";
                    cmd.Connection = sqlCon;
                    sqlCon.Open();
                    SqlDataAdapter da = new SqlDataAdapter(cmd);
                    DataTable dt = new DataTable();
                    da.Fill(dt);
                    if (dt.Rows.Count > 0)
                    {
                        gvInternalAudit.DataSource = dt;
                        gvInternalAudit.DataBind();
                    }
                    else
                    {
                        DataRow dr = dt.NewRow();
                        dt.Rows.Add(dr);
                        gvInternalAudit.DataSource = dt;
                        gvInternalAudit.DataBind();
                        gvInternalAudit.Rows[0].Visible = false;
                    }
                    sqlCon.Close();
                }
            }
        }
        protected void gvInternalAudit_RowDataBound(object sender, GridViewRowEventArgs e)
        {

            if (e.Row.RowType == DataControlRowType.DataRow)
            {

                Label Qtr1 = (Label)e.Row.FindControl("lblQtr1");
                Label Q1IntProc = (Label)e.Row.FindControl("lblQ1IntProc");
                Label Q1IntProj = (Label)e.Row.FindControl("lblQ1IntProj");
                Label Q1ExtBSI = (Label)e.Row.FindControl("lblQ1ExtBSI");
                Label Q1ExtCMMI = (Label)e.Row.FindControl("lblQ1ExtCMMI");


                int lblQtr1 = int.Parse(Q1IntProc.Text) + int.Parse(Q1IntProj.Text) + int.Parse(Q1ExtBSI.Text) + int.Parse(Q1ExtCMMI.Text);

                Qtr1.Text = lblQtr1.ToString();

            }

        }

        //called on row edit command
        protected void gvInternalAudit_RowEditing(object sender, GridViewEditEventArgs e)
        {
            gvInternalAudit.EditIndex = e.NewEditIndex;
            BindSubjectData();
        }

        //called when cancel edit mode
        protected void gvInternalAudit_RowCancelingEdit(object sender, GridViewCancelEditEventArgs e)
        {
            gvInternalAudit.EditIndex = -1;
            BindSubjectData();
        }
       
        //called on row add new command
        protected void gvInternalAudit_RowCommand(object sender, GridViewCommandEventArgs e)
        {
            if (e.CommandName == "Add")
            {
                bool IsAdded = false;
                TextBox newRequirement =
                (TextBox)gvInternalAudit.FooterRow.FindControl("newRequirement");
                 TextBox newYear = (TextBox)gvInternalAudit.FooterRow.FindControl("newYear");
                 TextBox newQtr1 = (TextBox)gvInternalAudit.FooterRow.FindControl("newQtr1");
                 TextBox newQ1IntProc = (TextBox)gvInternalAudit.FooterRow.FindControl("newQ1IntProc");
                 TextBox newQ1IntProj = (TextBox)gvInternalAudit.FooterRow.FindControl("newQ1IntProj");
                 TextBox newQ1ExtBSI = (TextBox)gvInternalAudit.FooterRow.FindControl("newQ1ExtBSI");
                 TextBox newQ1ExtCMMI = (TextBox)gvInternalAudit.FooterRow.FindControl("newQ1ExtCMMI");
                 TextBox newQtr2 = (TextBox)gvInternalAudit.FooterRow.FindControl("newQtr2");
                 TextBox newQ2IntProc = (TextBox)gvInternalAudit.FooterRow.FindControl("newQ2IntProc");
                 TextBox newQ2IntProj = (TextBox)gvInternalAudit.FooterRow.FindControl("newQ2IntProj");
                 TextBox newQ2ExtBSI = (TextBox)gvInternalAudit.FooterRow.FindControl("newQ2ExtBSI");
                 TextBox newQ2ExtCMMI = (TextBox)gvInternalAudit.FooterRow.FindControl("newQ2ExtCMMI");
                 TextBox newQtr3 = (TextBox)gvInternalAudit.FooterRow.FindControl("newQtr3");
                 TextBox newQ3IntProc = (TextBox)gvInternalAudit.FooterRow.FindControl("newQ3IntProc");
                 TextBox newQ3IntProj = (TextBox)gvInternalAudit.FooterRow.FindControl("newQ3IntProj");
                 TextBox newQ3ExtBSI = (TextBox)gvInternalAudit.FooterRow.FindControl("newQ3ExtBSI");
                 TextBox newQ3ExtCMMI = (TextBox)gvInternalAudit.FooterRow.FindControl("newQ3ExtCMMI");
                 TextBox newQtr4 = (TextBox)gvInternalAudit.FooterRow.FindControl("newQtr4");
                 TextBox newQ4IntProc = (TextBox)gvInternalAudit.FooterRow.FindControl("newQ4IntProc");
                 TextBox newQ4IntProj = (TextBox)gvInternalAudit.FooterRow.FindControl("newQ4IntProj");
                 TextBox newQ4ExtBSI = (TextBox)gvInternalAudit.FooterRow.FindControl("newQ4ExtBSI");
                 TextBox newQ4ExtCMMI = (TextBox)gvInternalAudit.FooterRow.FindControl("newQ4ExtCMMI");
                 TextBox newYearTotals = (TextBox)gvInternalAudit.FooterRow.FindControl("newYearTotals");
                 
                

             //   TextBox Grade = (TextBox)gvSubDetails.FooterRow.FindControl("newGrade");
                using (SqlConnection sqlCon = new SqlConnection(ConfigurationManager.ConnectionStrings["SQLMedTestConnHIM"].ConnectionString))
                {
                    using (SqlCommand cmd = new SqlCommand())
                    {
                        //here i'd added "@" for continuous string in new line
                        cmd.CommandText = @"INSERT INTO InternalAudit(Requirement, Year, Qtr1, Q1IntProc, Q1IntProj,Q1ExtBSI,Q1ExtCMMI,Qtr2,Q2IntProc,Q2IntProj,Q2ExtBSI,Q2ExtCMMI, Qtr3, Q3IntProc, Q3IntProj,Q3ExtBSI,Q3ExtCMMI,Qtr4, Q4IntProc, Q4IntProj,Q4ExtBSI,Q4ExtCMMI,YearTotals)
                                   VALUES(@Requirement,@Year,@Qtr1,@Q1IntProc,@Q1IntProj,@Q1ExtBSI,@Q1ExtCMMI,@Qtr2,@Q2IntProc,@Q2IntProj,@Q2ExtBSI,@Q2ExtCMMI,@Qtr3,@Q3IntProc,@Q3IntProj,@Q3ExtBSI,@Q3ExtCMMI,@Qtr4,@Q4IntProc,@Q4IntProj,@Q4ExtBSI,@Q4ExtCMMI,@YearTotals)";

                        cmd.Parameters.AddWithValue("@Requirement", newRequirement.Text);
                        cmd.Parameters.AddWithValue("@Year", newYear.Text);
                        cmd.Parameters.AddWithValue("@Qtr1", newQtr1.Text);
                        cmd.Parameters.AddWithValue("@Q1IntProc", newQ1IntProc.Text);
                        cmd.Parameters.AddWithValue("@Q1IntProj", newQ1IntProj.Text);
                        cmd.Parameters.AddWithValue("@Q1ExtBSI", newQ1ExtBSI.Text);
                        cmd.Parameters.AddWithValue("@Q1ExtCMMI", newQ1ExtCMMI.Text);
                        cmd.Parameters.AddWithValue("@Qtr2", newQtr2.Text);
                        cmd.Parameters.AddWithValue("@Q2IntProc", newQ2IntProc.Text);
                        cmd.Parameters.AddWithValue("@Q2IntProj", newQ2IntProj.Text);
                        cmd.Parameters.AddWithValue("@Q2ExtBSI", newQ2ExtBSI.Text);
                        cmd.Parameters.AddWithValue("@Q2ExtCMMI", newQ2ExtCMMI.Text);
                        cmd.Parameters.AddWithValue("@Qtr3", newQtr3.Text);
                        cmd.Parameters.AddWithValue("@Q3IntProc", newQ3IntProc.Text);
                        cmd.Parameters.AddWithValue("@Q3IntProj", newQ3IntProj.Text);
                        cmd.Parameters.AddWithValue("@Q3ExtBSI", newQ3ExtBSI.Text);
                        cmd.Parameters.AddWithValue("@Q3ExtCMMI", newQ3ExtCMMI.Text);
                        cmd.Parameters.AddWithValue("@Qtr4", newQtr4.Text);
                        cmd.Parameters.AddWithValue("@Q4IntProc", newQ4IntProc.Text);
                        cmd.Parameters.AddWithValue("@Q4IntProj", newQ4IntProj.Text);
                        cmd.Parameters.AddWithValue("@Q4ExtBSI", newQ4ExtBSI.Text);
                        cmd.Parameters.AddWithValue("@Q4ExtCMMI", newQ4ExtCMMI.Text);
                        cmd.Parameters.AddWithValue("@YearTotals", newYearTotals.Text);
                     
                        cmd.Connection = sqlCon;
                        sqlCon.Open();
                        IsAdded = cmd.ExecuteNonQuery() > 0;
                        sqlCon.Close();
                    }
                }
                if (IsAdded)
                {
                    lblMsg.Text = "'" + newRequirement.Text + "' InternalAudit added successfully!";
                   lblMsg.ForeColor = System.Drawing.Color.Green;

                    BindSubjectData();
                }
                else
                {
                    lblMsg.Text = "Error while adding '" + newRequirement.Text + "' subject details";
                    lblMsg.ForeColor = System.Drawing.Color.Red;
                }
            }
        }
        //called on row update command
        
        protected void gvInternalAudit_RowUpdating(object sender, GridViewUpdateEventArgs e)
        {
            bool IsUpdated = false;
            //getting key value, row id
            int ID =
            Convert.ToInt32(gvInternalAudit.DataKeys[e.RowIndex].Value.ToString());
            //getting row field details
            TextBox Requirement =
            (TextBox)gvInternalAudit.Rows[e.RowIndex].FindControl("txtRequirement");
            TextBox Year = (TextBox)gvInternalAudit.Rows[e.RowIndex].FindControl("txtYear");
            TextBox Qtr1 = (TextBox)gvInternalAudit.Rows[e.RowIndex].FindControl("txtQtr1");
            TextBox Q1IntProc = (TextBox)gvInternalAudit.Rows[e.RowIndex].FindControl("txtQ1IntProc");
            TextBox Q1IntProj  = (TextBox)gvInternalAudit.Rows[e.RowIndex].FindControl("txtQ1IntProj");
            TextBox Q1ExtBSI = (TextBox)gvInternalAudit.Rows[e.RowIndex].FindControl("txtQ1ExtBSI");
            TextBox Q1ExtCMMI = (TextBox)gvInternalAudit.Rows[e.RowIndex].FindControl("txtQ1ExtCMMI");
            TextBox Qtr2 = (TextBox)gvInternalAudit.Rows[e.RowIndex].FindControl("txtQtr2");
            TextBox Q2IntProc = (TextBox)gvInternalAudit.Rows[e.RowIndex].FindControl("txtQ2IntProc");
            TextBox Q2IntProj  = (TextBox)gvInternalAudit.Rows[e.RowIndex].FindControl("txtQ2IntProj");
            TextBox Q2ExtBSI = (TextBox)gvInternalAudit.Rows[e.RowIndex].FindControl("txtQ2ExtBSI");
            TextBox Q2ExtCMMI = (TextBox)gvInternalAudit.Rows[e.RowIndex].FindControl("txtQ2ExtCMMI");
            TextBox Qtr3 = (TextBox)gvInternalAudit.Rows[e.RowIndex].FindControl("txtQtr3");
            TextBox Q3IntProc = (TextBox)gvInternalAudit.Rows[e.RowIndex].FindControl("txtQ3IntProc");
            TextBox Q3IntProj  = (TextBox)gvInternalAudit.Rows[e.RowIndex].FindControl("txtQ3IntProj");
            TextBox Q3ExtBSI = (TextBox)gvInternalAudit.Rows[e.RowIndex].FindControl("txtQ3ExtBSI");
            TextBox Q3ExtCMMI = (TextBox)gvInternalAudit.Rows[e.RowIndex].FindControl("txtQ3ExtCMMI");
            TextBox Qtr4 = (TextBox)gvInternalAudit.Rows[e.RowIndex].FindControl("txtQtr4");
            TextBox Q4IntProc = (TextBox)gvInternalAudit.Rows[e.RowIndex].FindControl("txtQ4IntProc");
            TextBox Q4IntProj  = (TextBox)gvInternalAudit.Rows[e.RowIndex].FindControl("txtQ4IntProj");
            TextBox Q4ExtBSI = (TextBox)gvInternalAudit.Rows[e.RowIndex].FindControl("txtQ4ExtBSI");
            TextBox Q4ExtCMMI = (TextBox)gvInternalAudit.Rows[e.RowIndex].FindControl("txtQ4ExtCMMI");
            TextBox YearTotals = (TextBox)gvInternalAudit.Rows[e.RowIndex].FindControl("txtYearTotals");

         //   TextBox Grade = (TextBox)gvSubDetails.Rows[e.RowIndex].FindControl("txtGrade");
            using (SqlConnection sqlCon = new SqlConnection(ConfigurationManager.ConnectionStrings["SQLMedTestConnHIM"].ConnectionString))
            {
                using (SqlCommand cmd = new SqlCommand())
                {
                    //here i'd added "@" for continuous string in new line
                    cmd.CommandText = @"UPDATE InternalAudit SET Requirement=@Requirement,Year=@Year,Qtr1=@Qtr1,Q1IntProc=@Q1IntProc,Q1IntProj=@Q1IntProj,Q1ExtBSI=@Q1ExtBSI,Q1ExtCMMI=@Q1ExtCMMI, Qtr2=@Qtr2, Q2IntProc=@Q2IntProc, Q2IntProj=@Q2IntProj,Q2ExtBSI=@Q2ExtBSI, Q2ExtCMMI=@Q2ExtCMMI, Qtr3=@Qtr3, Q3IntProc=@Q3IntProc, Q3IntProj=@Q3IntProj,Q3ExtBSI=@Q3ExtBSI, Q3ExtCMMI=@Q3ExtCMMI,Qtr4=@Qtr4, Q4IntProc=@Q4IntProc, Q4IntProj=@Q4IntProj,Q4ExtBSI=@Q4ExtBSI, Q4ExtCMMI=@Q4ExtCMMI WHERE ID=@Id";
                    cmd.Parameters.AddWithValue("@Id", ID);
                    cmd.Parameters.AddWithValue("@Requirement", Requirement.Text);
                        cmd.Parameters.AddWithValue("@Year", Year.Text);
                        cmd.Parameters.AddWithValue("@Qtr1", Qtr1.Text);
                        cmd.Parameters.AddWithValue("@Q1IntProc", Q1IntProc.Text);
                        cmd.Parameters.AddWithValue("@Q1IntProj", Q1IntProj.Text);
                        cmd.Parameters.AddWithValue("@Q1ExtBSI", Q1ExtBSI.Text);
                        cmd.Parameters.AddWithValue("@Q1ExtCMMI", Q1ExtCMMI.Text);
                        cmd.Parameters.AddWithValue("@Qtr2", Qtr2.Text);
                        cmd.Parameters.AddWithValue("@Q2IntProc", Q2IntProc.Text);
                        cmd.Parameters.AddWithValue("@Q2IntProj", Q2IntProj.Text);
                        cmd.Parameters.AddWithValue("@Q2ExtBSI", Q2ExtBSI.Text);
                        cmd.Parameters.AddWithValue("@Q2ExtCMMI", Q2ExtCMMI.Text);
                        cmd.Parameters.AddWithValue("@Qtr3", Qtr3.Text);
                        cmd.Parameters.AddWithValue("@Q3IntProc", Q3IntProc.Text);
                        cmd.Parameters.AddWithValue("@Q3IntProj", Q3IntProj.Text);
                        cmd.Parameters.AddWithValue("@Q3ExtBSI", Q3ExtBSI.Text);
                        cmd.Parameters.AddWithValue("@Q3ExtCMMI", Q3ExtCMMI.Text);
                        cmd.Parameters.AddWithValue("@Qtr4", Qtr4.Text);
                        cmd.Parameters.AddWithValue("@Q4IntProc", Q4IntProc.Text);
                        cmd.Parameters.AddWithValue("@Q4IntProj", Q4IntProj.Text);
                        cmd.Parameters.AddWithValue("@Q4ExtBSI", Q4ExtBSI.Text);
                        cmd.Parameters.AddWithValue("@Q4ExtCMMI", Q4ExtCMMI.Text);
                        cmd.Parameters.AddWithValue("@YearTotals", YearTotals.Text);
               
                    cmd.Connection = sqlCon;
                    sqlCon.Open();
                    IsUpdated = cmd.ExecuteNonQuery() > 0;
                    sqlCon.Close();
                }
            }
            if (IsUpdated)
            {
                lblMsg.Text = "'" + Requirement.Text + "' InternalAudit updated successfully!";
                lblMsg.ForeColor = System.Drawing.Color.Green;
            }
            else
            {
                lblMsg.Text = "Error while updating '" + Requirement.Text + "' subject details";
                lblMsg.ForeColor = System.Drawing.Color.Red;
            }
            gvInternalAudit.EditIndex = -1;
            BindSubjectData();
        }

        //called on row delete command
        protected void gvInternalAudit_RowDeleting(object sender, GridViewDeleteEventArgs e)
        {
            bool IsDeleted = false;
            //getting key value, row id
            int ID = Convert.ToInt32(gvInternalAudit.DataKeys[e.RowIndex].Value.ToString());
            //getting row field subjectname
            Label Requirement = (Label)gvInternalAudit.Rows[e.RowIndex].FindControl("lblRequirement");
            using (SqlConnection sqlCon = new SqlConnection(ConfigurationManager.ConnectionStrings["SQLMedTestConnHIM"].ConnectionString))
            {
                using (SqlCommand cmd = new SqlCommand())
                {
                    cmd.CommandText = "DELETE FROM InternalAudit WHERE Id=@ID";
                    cmd.Parameters.AddWithValue("@ID", ID);
                    cmd.Connection = sqlCon;
                    sqlCon.Open();
                    IsDeleted = cmd.ExecuteNonQuery() > 0;
                    sqlCon.Close();
                }
            }
            if (IsDeleted)
            {
                lblMsg.Text = "'" + Requirement.Text + "' InternalAudit has been deleted successfully!";
                lblMsg.ForeColor = System.Drawing.Color.Green;
                BindSubjectData();
            }
            else
            {
                lblMsg.Text = "Error while deleting '" + Requirement.Text + "' subject details";
                lblMsg.ForeColor = System.Drawing.Color.Red;
            }
        }

    }
}

modified 19-Jun-15 1:56am.

Re: Trying to sum several fields into a total field

OriginalGriff18-Jun-15 19:15

OriginalGriff

18-Jun-15 19:15

Although you have two different variables declared as each of those name (one as a Label, one as a TextBox) I can't see anything immediately wrong with the code you show.

So start by looking at which line is giving the error: double click the error message in VS and it'll take you right to it.
Anything odd about that line? Or the lines immediately above?
What concerns me slightly is that the code adding the parameters to your SqlCommand object in gvInternalAudit_RowUpdating is not indented correctly - which normally means that the curly brackets don't match somewhere or some similar error which means that the compiler doesn't understand the control flow properly. That can throw up a lot of "spurious" errors which disappear once the control flow is sorted. It's likely that your problem is something to do with that.

Do a CTRL+K, CTRL+D to reformat the document and see if the indentation corrects itself. If it doesn't, then there is a serious problem elsewhere.

Bad command or file name. Bad, bad command! Sit! Stay! Staaaay...

Re: Trying to sum several fields into a total field

Norris Chappell18-Jun-15 20:26

Norris Chappell

18-Jun-15 20:26

int lblQtr1 = int.Parse(Q1IntProc.Text) + int.Parse(Q1IntProj.Text) + int.Parse(Q1ExtBSI.Text) + int.Parse(Q1ExtCMMI.Text); This line is giving me the error:

Re: Trying to sum several fields into a total field

Norris Chappell18-Jun-15 20:31

Norris Chappell

18-Jun-15 20:31

The qtr1 field is 0. However the other 4 fields are showing in debug a Null value.

Re: Trying to sum several fields into a total field

Pete O'Hanlon18-Jun-15 22:39

Pete O'Hanlon

18-Jun-15 22:39

Null is not an integer value. This is why it's failing - as a plain int is not a nullable type, you cannot just parse it, you should actually use TryParse instead. You need to break your logic up into something that looks a little bit like this:

//int lblQtr1 = int.Parse(Q1IntProc.Text) + int.Parse(Q1IntProj.Text) + int.Parse(Q1ExtBSI.Text) + int.Parse(Q1ExtCMMI.Text); 
private int GetValue(TextBox textBox)
{
  int output;
  if (int.TryParse(textBox.Text, out output))
  {
    return output;
  }
  return 0;
}
int lblQtr1 = GetValue(Q1IntProc) + GetValue(Q1IntProj) + GetValue(Q1ExtBSI) + GetValue(Q1ExtCMMI);

Re: Trying to sum several fields into a total field

Norris Chappell19-Jun-15 4:44

Norris Chappell

19-Jun-15 4:44

I getting that error that The name 'Q1IntProc' does not exist in the current context.
So I should have an if statement for each field that I am summing? So what goes here textBox.Text?

Re: Trying to sum several fields into a total field

Richard MacCutchan19-Jun-15 7:02

Richard MacCutchan

19-Jun-15 7:02

I already suggested that you check the variable names that you are using. They appear not to match the names you have set in your ASP page.

Re: Trying to sum several fields into a total field

Norris Chappell19-Jun-15 7:23

Norris Chappell

19-Jun-15 7:23

<itemtemplate>
<asp:label id="lblQ1IntProc" text="<%#Eval("Q1IntProc") %>"
="" runat="server">

<itemtemplate>
<asp:label id="lblQ1IntProj" text="<%#Eval("Q1IntProj") %>"
="" runat="server">

<itemtemplate>
<asp:label id="lblQ1ExtBSI" text="<%#Eval("Q1ExtBSI") %>"
="" runat="server">

<itemtemplate>
<asp:label id="lblQ1ExtCMMI" text="<%#Eval("Q1Q1ExtCMMI") %>"
="" runat="server">

It is what I have in my asp. Did I not set it properly?

Re: Trying to sum several fields into a total field

Norris Chappell19-Jun-15 5:35

Norris Chappell

19-Jun-15 5:35

Hi, I not sure how to use this code? Please let me know if I need to make changes to it?

Re: Trying to sum several fields into a total field

Norris Chappell19-Jun-15 9:30

Norris Chappell

19-Jun-15 9:30

Pete, I not for sure how to use this code. Can you let me know what I need to do? I still getting the error for the 4 fields. The fields do not exist in the current context.

Re: Trying to sum several fields into a total field

Agent__00718-Jun-15 20:30

Agent__007

18-Jun-15 20:30

A quick check would be - just put a debug point on the line throwing the error, and hover (move your mouse pointer over) Q1IntProc, Q1IntProj, Q1ExtBSI and Q1ExtCMMI one by one (or with a quick watch (right click -> Quick Watch)) and check which one's null.

There must be (atleast) one of them which is null. If so, look at corresponding "FindControl" statement and check if the string param you are specifying for the "FindControl" call ("txtQ1IntProc", for instance) does actually represent a valid TextBox in your (GridView's) row.

Hope that helps.

You have just been Sharapova'd.

Re: Trying to sum several fields into a total field

Norris Chappell18-Jun-15 20:36

Norris Chappell

18-Jun-15 20:36

I did that and all of them are null.
aspx:
<asp:templatefield headertext="Q1IntProc">
<edititemtemplate>
<asp:textbox id="txtQ1IntProc" text="<%#Eval("Q1IntProc") %>"
="" runat="server">

<itemtemplate>
<asp:label id="lblQ1IntProc" text="<%#Eval("Q1IntProc") %>"
="" runat="server">

<footertemplate>
<asp:textbox id="newQ1IntProc" runat="server">

I changed to my code to TextBox but still getting the null errors:
Qtr1 value is 0 the other 4 are null. Frown | :(

modified 19-Jun-15 3:21am.

Re: Trying to sum several fields into a total field

Richard MacCutchan18-Jun-15 22:05

Richard MacCutchan

18-Jun-15 22:05

The ids of the textboxes in your ASP file do not (as far as I can see) match the names you are using in your code. Also coding a line such as

int lblQtr1 = int.Parse(Q1IntProc.Text) + int.Parse(Q1IntProj.Text) + int.Parse(Q1ExtBSI.Text) + int.Parse(Q1ExtCMMI.Text);

is asking for trouble. You have no idea what may be in any of the text fields, so if the user enters garbage it will just fail. You shoud use int.TryParse to capture the numeric values, so you can alert the user if any is invalid. You should also assign each value to an individual variable before summing them. That way, you can debug it much more easily.

Re: Trying to sum several fields into a total field

Agent__00718-Jun-15 23:23

Agent__007

18-Jun-15 23:23

Norris Chappell wrote:
I changed to my code to TextBox but still getting the null errors:

Yes, that should be Label only and not TextBox, my mistake.

Not sure what's wrong here. But in your ASP markup, are you missing an <ItemTemplate> wrapped around the controls? You can also try finding the control in a "Cell" (like row.Cells[N].FindControl(), where N-> index of the container cell).

Not sure it's related, but you can also check the actual IDs of the controls after they are rendered and there's a property "ClientIDMode"(?) of GridView (not sure but I remember to have faced something similar a few years ago when I worked on ASP.NET WebForms) which you can use if there's a mismatch.

Good luck!

You have just been Sharapova'd.

Re: Trying to sum several fields into a total field

Norris Chappell19-Jun-15 3:25

Norris Chappell

19-Jun-15 3:25

Hi Everyone I finally figured it out. I didn't need to do it in C# after all. I modified my SQL to sum the fields I needed. I want to thank everyone that contributed.

modified 19-Jun-15 23:37pm.

Find 2 Dates A DateTime Falls between From Dictionary

Kevin Marois18-Jun-15 6:38

Kevin Marois

18-Jun-15 6:38

I have a dictionary where the key is a DateTime. I need to find the 2 entries in the dictionary that are closest to a given datetime.

So, I have

Dictionary<DateTime, double> columnInfos = new Dictionary<DateTime, double>();
foreach (var activity in activities)
{

    DateTime activityDate = activity.ActivityDateTime;

    // Get the 2 entries in the columnInfos dict that activityDate falls between
}

I was going to loop through the dictionary, but is that really the best way?> Anyone have a better solution?

Thanks

If it's not broken, fix it until it is

Re: Find 2 Dates A DateTime Falls between From Dictionary

Sascha Lefèvre18-Jun-15 6:56

Sascha Lefèvre

18-Jun-15 6:56

Coder (Hired) wrote:
I was going to loop through the dictionary, but is that really the best way?

The best way depends on your requirements. If there can be a lot of DateTimes and lookup is more frequent than insertion/deletion then a SortedList<TKey, TValue>[^] might provide better performance. Though if you also need lookup by an exact DateTime then you would have to create a custom collection class where you combine a Dictionary with a SortedList to get the best of both (or maybe you can find an existing implementation of that).

If the brain were so simple we could understand it, we would be so simple we couldn't. — Lyall Watson

Use Ctrl+Left/Right to switch messages, Ctrl+Up/Down to switch threads, Ctrl+Shift+Left/Right to switch pages.