The Weird and The Wonderful

Thomas Weller wrote:

He has no idea of OO programming, maybe he thinks VB5/6 IS OO

BadKarma wrote:

But surely VB6 is a OO programming language.

Tristan Rhodes wrote:

* Only one return per function (no short circuit conditions), leading to horrendous nesting.

Tristan Rhodes wrote:

* Don't use Data Access layers, they're a waste of time, just use inline SQL and bind to a DataReader.

Tristan Rhodes wrote:

* Don't create lots of objects, it's slow.

Tristan Rhodes wrote:

* Don't break things into sub functions, it's harder to read and slower.

Tristan Rhodes wrote:

* Don't use constants, it's hard to read the literal representation.

Tristan Rhodes wrote:

* Don't use wrappers, ever, as you will just end up with wrappers in wrappers.

Tristan Rhodes wrote:

* Don't use Inheritance, it's complicated.

Tristan Rhodes wrote:

* Don't use Interfaces, they're unescessary.

Tristan Rhodes wrote:

* Don't use Serialization (Xml or otherwise - My understanding of serialization is object state persistence so I'm not sure how to persist without it).

Tristan Rhodes wrote:

* Don't make custom controls

Tristan Rhodes wrote:

* Don't use design patterns, they just complicate things.

Tristan Rhodes wrote:

* Don't use code generators, they generate slow / too much code.

Tristan Rhodes wrote:

* Don't bother with resources until we need to globalize the app.

Tristan Rhodes wrote:

* Don't make unit tests, waste of time, we can just user test it.

Pete O'Hanlon wrote:

BOLOC

Pete O'Hanlon wrote:

Tristan Rhodes wrote:
* Only one return per function (no short circuit conditions), leading to horrendous nesting.



Not bad advice - just keep your functions short or you're in trouble.

MenuItemNode child = tvMenu.SelectedNode as MenuItemNode;

if (child == null)
     return;

MenuItemNode parent = child.Parent as MenuItemNode;

if (parent == null)
     return;

MenuItemNode swap = child.PrevNode as MenuItemNode;

if (swap == null)
     return;

//Code Here

MenuItemNode child = tvMenu.SelectedNode as MenuItemNode;

if (child != null)
{
      MenuItemNode parent = child.Parent as MenuItemNode;

      if (parent != null)
      {
            MenuItemNode swap = child.PrevNode as MenuItemNode;

            if (swap != null)
            {
                  //Code Here
            }
      }
}

bool IntializeAndvalidate (out MenuItemNode child, out MenuItemNode parent, MenuItemNode swap)
{
MenuItemNode child = tvMenu.SelectedNode as MenuItemNode;

      if (child != null)
      {
            MenuItemNode parent = child.Parent as MenuItemNode;

            if (parent != null)
            {
                  MenuItemNode swap = child.PrevNode as MenuItemNode;

                  return  (swap != null);
            }
      }
}

if (IntializeAndvalidate (child, parent, swap)
{
      // do stuff
}

int[] numbers=new int[100];
for (int i=0; ; i++) numbers[i]=i; // break with IndexOutOfRangeException 

if (child != null && child.Parent != null && child.PrevNode != null)
{
}

MenuItemNode child = tvMenu.SelectedNode as MenuItemNode;
if (child == null)
   return;
MenuItemNode parent = child.Parent as MenuItemNode;
if (parent == null)     
   return;
MenuItemNode swap = child.PrevNode as MenuItemNode;
if (swap == null)     
   return;
//Code Here

MenuItemNode child = tvMenu.SelectedNode as MenuItemNode;
if (child == null)
   {
   return;
   }
MenuItemNode parent = child.Parent as MenuItemNode;
if (parent == null)     
   {
   return;
   }
MenuItemNode swap = child.PrevNode as MenuItemNode;
if (swap == null)     
   {
   return;
   }
//Code Here

EyeYamFedUp wrote:

Public gblnSuperUser As Boolean
Public gblnLogonOK As Boolean = False

Pete O'Hanlon wrote:

He used comments didn't he?