|
Exactly! (and thanks for posting!) I was wondering how I could even declare app as a Crystal Report Application object to begin with. Turns out it works fine and was not the cause of our problems. The problem was corrected by using late binding on the Crystal App object.
"Go forth into the source" - Neal Morse
|
|
|
|
|
Inspired by the goto comments in the lounge today...
Msny years ago a co-worker showed me his first program after we had banned the use of goto statements at our company.
His program had a main loop like:
If var = 1 gosub 100
If var = 2 gosub 200
and so on..
and inside each subroutine before leaving, it would set var to whatever it needed to be next.
An abstracted goto !
This is back in the days before OO and events. This was procedural type code and in this case.. a goto would have been clearly easier to understand.
|
|
|
|
|
That's why I always get scared when such rules are preached religiously and then applied at all cost. I often write code for old 8 bit computers or microcontrollers and calling functions for everything will result in a slow processor working more on the stack than the actual task. Using goto or branching instructions in assembly then will make more of the two most valuable resources, CPU and memory. Thinking and making most of the resources at your disposal is more important than blindly following rules.
I'm invincible, I can't be vinced
|
|
|
|
|
Agreed.
I really don't understand the goto hate, although I've never worked in an environment where it was an issue. There are times when goto makes sense even in modern programming techniques.
|
|
|
|
|
I can understand it.
There are indeed times when goto makes sense. The problem is that it is taught to people who do not have the experience to understand when those times are, so use it when a "proper" alternative would be more work.
Blame the teachers! I do... 
Ideological Purity is no substitute for being able to stick your thumb down a pipe to stop the water
|
|
|
|
|
Wish it was more obvious in tutorials. The impression I get is "Don't ever use goto". That just made me wonder why switch/cases use the same syntax.
Anyone have a link to explain when it's a good idea?
|
|
|
|
|
No!
It's not a hard and fast rule - it depends on the complexity of what you are doing and why you might need it.
Sorry - but it's an experience thing, not something you can easily take down to a list of "if this and this and this, but not that or that, then..."
It's like driving a car - after a while you get a feel for "Is now a good time to pull out of this side turning?". It's not something you can easily explain.
Ideological Purity is no substitute for being able to stick your thumb down a pipe to stop the water
|
|
|
|
|
Not that I have used it, but the case some have made is breaking out of deeply nested loops (and not with exceptions):
for (i = 0; i < end; i++) {
doSomething();
for(j = obj[i].getAnotherObj(); j++; obj[i].end()) {
doSomethingElse();
for(k = anotherObj[j].getYetAnotherObj(); k++; anotherObj[j].end()) {
if (yetAnotherObj[k].condition())
goto breakOutOfDeeplyNestedLoop;
doYetSomethingElse();
}
blahBlah();
}
blahBlahBlah();
}
breakOutOfDeeplyNestedLoop:
moreStuffInThisMethod();
You could use exceptions, but that's really a misuse of them if the condition is not truly exceptional.
|
|
|
|
|
Ah yes, in some of my console apps I have a while loop for the console input, with continue to indicate that the command was recognised and bypass the rest of the commands in the loop.
Of course once I nested a for loop, I had to use a bool to ensure whether the loop should have used continue or not.
So assuming a similar scenario, instead of
while(settext())
{
if(!stricmp(text, "something"))
{
DoStuff();
continue; }
if(!strincmp(text, sizeof("other thing ")-1, "other thing "))
{
for(unsigned int i = 0; i < StringArray.size(); ++i)
{
if(!stricmp(text+sizeof("other thing ")-1, StringArray[i]))
{
StringArray.erase(i);
break; }
}
ReportError("parameter not found");
continue; }
if(!stricmp(text, "asparagus"))
{
continue; }
ReportError("command not found);
JumpHere:
continue; // Labels must have a statement
}
So that would be an applicable scenario?
modified 28-Feb-12 14:49pm.
|
|
|
|
|
Good example exactly of not using goto at all,
it's easily converted to an if then else situation.
which increases readability if u would ask me.
while(settext())
{
if(!stricmp(text, "something"))
{
DoStuff();
}
else if(!strincmp(text, sizeof("other thing ")-1, "other thing "))
{
for(unsigned int i = 0; i < StringArray.size(); ++i)
{
if(!stricmp(text+sizeof("other thing ")-1, StringArray[i]))
{
StringArray.erase(i);
break;
}
}
ReportError("parameter not found");
}
else if(!stricmp(text, "asparagus"))
{
}
else
{
ReportError("command not found");
}
}
|
|
|
|
|
I believe you read that wrong, please read the comments I have in the code. The point here was exiting out of the the for loop embedded in the while loop, not the if format 
Although I am also interested if using if-else-if actually is faster than repetitive
if() {code(); end_if_checks();} if() {...}in my example though.
|
|
|
|
|
If u want speed, i would const the size of for your fixed string,
would safe u getting it's length each time u go for another loop in the while.
The continues u fire are at end of each if slice, and in an if else construction
it would jump out to bottom anyways, so in this case i think continue actually will be equally fast at best and else even slower.
for(unsigned int i = 0; i < StringArray.size(); ++i)
{
if(!stricmp(text+sizeof("other thing ")-1, StringArray[i]))
{
StringArray.erase(i);
break;
}
}
I normally do different, a bit slower i assume but clear
const int Sizer = sizeof("other thing ")-1;
int WalkTo = StringArray.size() - 1;
if (WalkTo >= 0)
{
const char* Check = text + Sizer;
int i = -1;
int Found = 0;
do
{
i++;
if (!stricmp(Check, StringArray[i]))
{
StringArray.erase(i);
Found = 1;
}
} while (!Found && (i < WalkTo));
}
modified 29-Feb-12 3:31am.
|
|
|
|
|
Okay, let me add a line at the prefix to clear up any confusion:
std::vector<std::string> StringArray;
The StringArray.size() gets the size of an array of std::strings, not an array of chars.
Say the StringArray was initialised to a set of usernames, in a server for example, and the command 2 could be "disconnect xxx".
|
|
|
|
|
Except that then u might want to retrieve the current size each loop what does it make it different for the rest? I see no different(new) reason to agree break is a good way to be honest.
|
|
|
|
|
The main problem is that goto statement is the only instruction in all programming languages that can change the PC (Program Counter) register in the processor
and this is not right
|
|
|
|
|
Clearly false since a whole bunch of language constructs compile into assembler/IL jump instructions.
|
|
|
|
|
I guess its just that abusing it can make source code hard to follow.
|
|
|
|
|
When I was a kid, I had a book with a BASIC program that generated mazes. I loved the game, but it was a mess of code. There were GOTOs that led straight to other GOTOs! (Check out line 780.) As an exercise when I got older, I went through and made it structured -- took days! That is why all the GOTO hate.
Anyway, using a GOTO on occasion isn't such a big deal. The problem is when it is the backbone of a complex program. And I agree with the person who said very few programmers come across a situation in which GOTO would be the preferred method.
|
|
|
|
|
Hmm, looks remarkably like a very basic finite state machine to me 8)
|
|
|
|
|
I agree on the state machine.
Each state has one subroutine for it.
Each subroutine could transition to one or more states.
Simple, concise.
How (and why) would a goto improve this?
Other thoughts
In assembly, ever high level loop is implemented with gotos/branches.
Java does not have or need a goto because they allow labeled break and continue statements. I don't think C# copied that feature (unfortunately).
|
|
|
|
|
Subroutines cause stack push pulls, the goto doesn't which makes it much more efficient. If you want your code to run in an ever shrinking hardware platform world things like that put you in front of the competition.
|
|
|
|
|
I think his point was that in the end, everything ends translated to gotos by the compiler.
|
|
|
|
|
Deep recursion could potentially stand to be replaced with a goto.
The problem as others have mentioned is that it has been heavily abused. And since it usually would only be needed under a limited set of circumstances it's better to just make it off-limits unless someone can make a compelling case for its use.
|
|
|
|
|
The key to any job is having the right tool.
If we start removing tools because people abuse them we would have to take computers away from people entirely. Just saying 
|
|
|
|
|
Yes, if you're working in a language which doesn't support tail recursion. This goto (and the argument reassignments) should be clearly commented as being a hack around tail recursion not working, though.
|
|
|
|
General 
News 
Suggestion 
Question 
Bug 
Answer 
Joke 
Praise 
Rant 
Admin 
Submit an article or tip
