C / C++ / MFC

Re: What's problem of my code?( create a random maze)

6-Jun-12 2:36

jiuyejii wrote:
what's the problem of my code?? can't create the maze.
may be problem comes from back to previous step,but how to correct it?

You seriously need to learn to use the debugger to help solve such problems. Dumping a boatload of code in a forum and asking others to wade through it will get you nowhere.

Instead of trying to solve the problem as a whole, break it down into smaller chunks. If stack space is being exhausted, you most likely have a recursion problem.

"One man's wage rise is another man's price increase." - Harold Wilson

"Fireproof doesn't mean the fire will never come. It means when the fire comes that you will be able to withstand it." - Michael Simmons

"Show me a community that obeys the Ten Commandments and I'll show you a less crowded prison system." - Anonymous

Maximilien6-Jun-12 2:46

Maximilien

6-Jun-12 2:46

did you debug with a small maze size?
do you check array boundaries ? (for example in function count ).

You should try to convert the recursion to a iterative (loop); it might help fix the stack overflow.

Watched code never compiles.

Re: What's problem of my code?( create a random maze)

Aescleal6-Jun-12 6:47

Aescleal

6-Jun-12 6:47

No idea what's causing your stack overflow, but as one of the previous posters mentioned (think it was David, sorry if I've got that wrong) it's probably related to recursion.

As to what the problem is with your code I can sum that up in one word. Abstraction. There's not a lot is there? When you write huge lumps of code how are other people meant to follow what you mean? Come to think of it how are you supposed to be able to follow it next week? And if you and other people are having problems think of the poor, literal minded compiler, he's having a nightmare [1].

So even if you don't want to do the whole OO thing, think about splitting your code up into nice little packets you and the rest of the world can understand. Here are some guidelines which have served me well:

- make each function only do one thing but make it do it well
- split loops and complex conditionals out into their own functions
- if a variable name is only a couple of characters long it's almost always too short
- if you've got more than 2 levels of indirection in an expression then that's too much. If you've got 2 it's probably still too much. Things like char **& are right out
- even if you're programming in "C like" C++ don't play about with memory directly. Let someone else do the heavy lifting. std::vector, std::unique_ptr and std::shared_ptr can cover about 99% of your dynamic memory requirements.

Interestingly you've got one complex conditional in it's own function. Cool! Keep that up and look for other places you can do the same sort of thing. FREX you've got the following segment of code:

C++

c--;
i=cti[c];
j=ctj[c];
cti[c+1]=0;

ctj[c+1]=0;

in four places. Think of a name to describe what this lot is up to and pack it away in a function. Do that a few more times and you might be starting to see where your code is going wrong.

[1] I've committed a cardinal sin here, I've anthropomorphised a computer. They don't like it when you do that.

Re: What's problem of my code?( create a random maze)

Peter_in_27806-Jun-12 17:37

Peter_in_2780

6-Jun-12 17:37

Aescleal wrote:
I've anthropomorphised a computer. They don't like it when you do that.

No wonder OP has a stack overflow, with recursion like that! Poke tongue | ;-P

Cheers,
Peter

Software rusts. Simon Stephenson, ca 1994. So does this signature. me, 2012

Re: What's problem of my code?( create a random maze)

jiuyejii6-Jun-12 18:49

jiuyejii

6-Jun-12 18:49

Thank you for your advice

Re: What's problem of my code?( create a random maze)

Aescleal6-Jun-12 23:52

Aescleal

6-Jun-12 23:52

Any time!

Re: What's problem of my code?( create a random maze)

Stefan_Lang8-Jun-12 4:19

Stefan_Lang

8-Jun-12 4:19

The problem is right at the end of the function cmaze(): there you call the same function, recursively. That means for every step, your program will push one more function call on the stack, and it won't resolve it until the very end.

Don't do that kind of thing. Instead use the return code to indicate whetehr or not you need to do another step, and create a loop:

Change the function cmaze to:

C++

bool cmaze(int& i, int& j) {
   //...
   // change your test for the exit to the following:
   if (maze[out][N]=='.')
      return false;

   // ... the rest of your code

   // and at the end:
   return true;
}

Change your call to cmaze in makebg() to:

C++

i = in;
j = 1;
while (cmaze(i, j));

Re: What's problem of my code?( create a random maze)

jiuyejii8-Jun-12 17:57

jiuyejii

8-Jun-12 17:57

You are right and your suggestions let me learn more,thanks

MFC application being compiled on VS2012

YaronNir5-Jun-12 23:03

YaronNir

5-Jun-12 23:03

i took an MFC application written in VS2010
opened in in win8 with visual studio 2012
got the following errors:
error C1083: Cannot open include file: "tmschema.h": No such file or directory (afxwin.h)

it returns in several cases

anyway can help?
thanks

Interface basics click here :
http://www.codeproject.com/com/COMBasics.asp

don't forget to vote Smile | :)

David Crow6-Jun-12 2:37

6-Jun-12 2:37

YaronNir wrote:
anyway can help?

Does tmschema.h exist?

YaronNir6-Jun-12 2:40

YaronNir

6-Jun-12 2:40

actually you are right, it doesn't

will check more
thanks

Interface basics click here :
http://www.codeproject.com/com/COMBasics.asp

don't forget to vote Smile | :)

tldcolli4-Aug-12 3:31

tldcolli

4-Aug-12 3:31

Strangely, at Microsoft.com, the current link to the Microsoft Windows SDK appears to be broken:

http://msdn.microsoft.com/en-us/windows//bb980924.aspx?wt.svl=more_downloads[^]

Code Executed Twice - OnHScroll()

tldcolli4-Aug-12 3:28

tldcolli

4-Aug-12 3:28

The include file "tmschema.h" is part of the Microsoft SDK (in v6.0 and v7.0), and is included by Visual Studio 2010 (in afxwin.h). However, Visual Studio 2012 doesn't appear to have the correct include files and/or libraries.

I'm looking to see if there's a known solution, and I'll post here again when I've worked it out!

Confused | :confused:

AmbiguousName5-Jun-12 21:42

AmbiguousName

5-Jun-12 21:42

hello guys... I have these two track bars on my form. Now even though I check which tracked bar was clicked; it still executes the code twice which is very awkward. Here is what I am trying

void CMainDlg::OnHScroll(UINT nSBCode, UINT nPos, CScrollBar* pScrollBar)
{
    if((CSliderCtrl*)pScrollBar == &m_trackONE)
    {
       // some code here
       // if clicked this one; it starts all over again and reaches here again
    }

    if((CSliderCtrl*)pScrollBar == &m_trackTWO)
    {
       // some code here
       // if clicked this one; it starts all over again and reaches here again
    }
}

It correctly recognizes which track bar I clicked but why does it starts executing all over again? thanks for any pointer.

This world is going to explode due to international politics, SOON.

image processing toolkits | batch image processing

C^hris L^osinger6-Jun-12 1:17

C^hris L^osinger

6-Jun-12 1:17

does nSBCode change between calls?

AmbiguousName6-Jun-12 1:35

AmbiguousName

6-Jun-12 1:35

Thanks for ur time. It does change. For both track bars I checked this and both times
- on first call nSBCode had a value of 3
- on second call nSBCode had a value of 8

This world is going to explode due to international politics, SOON.

image processing toolkits | batch image processing

C^hris L^osinger6-Jun-12 1:38

C^hris L^osinger

6-Jun-12 1:38

3 = SB_PAGERIGHT
8 = SB_ENDSCROLL

so, it's telling you two different things

AmbiguousName6-Jun-12 1:40

AmbiguousName

6-Jun-12 1:40

Chris Losinger wrote:
so, it's telling you two different things

Well I am afraid I don't know its meaning. What should I do? Should I be worried or something?

This world is going to explode due to international politics, SOON.

image processing toolkits | batch image processing

C^hris L^osinger6-Jun-12 2:08

C^hris L^osinger

6-Jun-12 2:08

SB_ENDSCROLL just means the user has let go of the mouse button and is no longer interacting with the control, so scrolling is done. you can probably ignore it.

Malli_S6-Jun-12 21:43

Malli_S

6-Jun-12 21:43

Overloaded_Name wrote:
Well I am afraid I don't know its meaning. What should I do? Should I be worried or something?

Probably you should have a look at this[^]!

[Delegates] [Virtual Desktop] [Tray Me !]

-Malli...!

David Crow6-Jun-12 2:40

How to stop indexing from restarting?

6-Jun-12 2:40

Since pScrollBar can't point to two controls at the same time during the same call to OnHScroll(), the second if() statement should have an else in front of it.

Wolfkc5-Jun-12 12:14

Wolfkc

5-Jun-12 12:14

We have a utility that needs to maximize resources. We stop indexing by stopping the wsearch service. But within a matter of minutes it restarts. I thought there might be a connection to Outlook but even with outlook not started this happens.

We would rather not set the service to disabled. If anyone has any information or suggestions it is appreciated.

Thanks, kc

In the event log i see these two messages associated with the indexing restart.

Event 102, ESENT
Windows (6604) Windows: The database engine (6.01.7601.0000) started a new instance (0).

and

Event 1003, Serach
The Windows Search Service started.

--------------------------------------------------------------------------------

Re: How to stop indexing from restarting?

enhzflep5-Jun-12 16:01

enhzflep

5-Jun-12 16:01

Before I start, I'll admit to feeling dirty for even considering such an approach..

However, it sounds very much like the service has a watch-dog application monitoring it. Once the monitoring app detects that it is no longer running, it simply restarts the service.

If this is the case, you may be able to fool the watch-dog app. Often this type of arrangement has a Mutex at it's heart. The service creates a mutex, the watch-dog then tries periodically to create a mutex with the same name. If the operation fails, the service is still running as per normal. If on the other hand, the mutex creation is successful, one can safely assume that the intended creator of the mutex (the service) has ceased running and taken the mutex with it.

On second thoughts, scratch that idea - it's a service that comes bundled with Windows. It seems likely that Windows itself maintains an in-memory list of services and their current state.

On third thoughts, I can't think of a way of doing this (other than with the standard Services dialogs) that couldn't reasonably be considered a hack. Nonetheless,

I just read a thread in which one writer spoke of having to change the permissions on some registry key(s?) in order to change the service startup type...

Last post here.[^]

I guess that leaves you an avenue of investigation:

Change the reg-key to indicate Disabled, kill the service. Once proessing done, set Automatic (Delayed Start) then let windows start the service up when 'needed'.

No idea which RegKey though..

Re: How to stop indexing from restarting?

David Crow6-Jun-12 2:41