Click here to Skip to main content
15,886,689 members
Home / Discussions / JavaScript
   

JavaScript

 
GeneralRe: urdu Pin
Richard MacCutchan8-Aug-12 21:28
mveRichard MacCutchan8-Aug-12 21:28 
AnswerRe: urdu Pin
Rahul Rajat Singh22-Aug-12 1:24
professionalRahul Rajat Singh22-Aug-12 1:24 
GeneralRe: urdu Pin
Sandip.Nascar22-Aug-12 11:03
Sandip.Nascar22-Aug-12 11:03 
QuestionLooping through elements, to find textbox, and get values Pin
jkirkerx8-Aug-12 13:12
professionaljkirkerx8-Aug-12 13:12 
AnswerRe: Looping through elements, to find textbox, and get values Pin
jkirkerx8-Aug-12 18:13
professionaljkirkerx8-Aug-12 18:13 
GeneralRe: Looping through elements, to find textbox, and get values Pin
Andrei Straut9-Aug-12 4:41
Andrei Straut9-Aug-12 4:41 
GeneralRe: Looping through elements, to find textbox, and get values Pin
jkirkerx9-Aug-12 6:27
professionaljkirkerx9-Aug-12 6:27 
AnswerRe: Looping through elements, to find textbox, and get values Pin
Andrei Straut9-Aug-12 9:37
Andrei Straut9-Aug-12 9:37 
Now, I'm no JavaScript guru, but...

JavaScript
if ((nameArray[i] != "") && (codeArray[i] != ""))

Here I would also add a jQuery.trim() on nameArray[i]. You may have values that are simply spaces, and checking for empty string will return false

Also, in the for you could dump nameCount and codeCount. Maybe you didn't post the full function, but nameCount is used only for upper bound limit (which could be replaced with parseInt($("._name_Field").length)), and codeCount isn't used at all.

Other than that, seems to be fine. Also, it's good that you are commenting your code. I've been through some situations in my (relatively short) career when I banged my hand on a wall for not commenting my code a few months earlier.

And if it works for you the way you want it, it's all good. I may get burned for this, but I have a saying:
Make it work. Then do it better

Wrapping it all up, the final function would be:
JavaScript
var elements = [];
 
// Create Arrays to hold the values
var nameArray = [];
$("._name_Field").each(function () { nameArray.push($(this).val()) });
 
var codeArray = [];
$("._code_Field").each(function () { codeArray.push($(this).val()) });
 
// Gather the Data from the Element Containers from valid elements
var jdx = 0;
for (i = 0; i <= parseInt($("._name_Field").length) - 1; i++) {
  if ($.trim(nameArray[i]) != ""
	&& $.trim(codeArray[i]) != "") {
     elements[jdx] = [];
     elements[jdx]["name"] = nameArray[i];
     elements[jdx]["code"] = codeArray[i].toUpperCase();
     
     jdx++;
  }
}

Full-fledged Java/.NET lover, full-fledged PHP hater.
Full-fledged Google/Microsoft lover, full-fledged Apple hater.
Full-fledged Skype lover, full-fledged YM hater.

GeneralRe: Looping through elements, to find textbox, and get values Pin
jkirkerx9-Aug-12 10:18
professionaljkirkerx9-Aug-12 10:18 
GeneralRe: Looping through elements, to find textbox, and get values Pin
Andrei Straut9-Aug-12 10:35
Andrei Straut9-Aug-12 10:35 
AnswerRe: Looping through elements, to find textbox, and get values Pin
Andy Brummer9-Aug-12 10:26
sitebuilderAndy Brummer9-Aug-12 10:26 
GeneralRe: Looping through elements, to find textbox, and get values Pin
jkirkerx9-Aug-12 16:54
professionaljkirkerx9-Aug-12 16:54 
GeneralRe: Looping through elements, to find textbox, and get values Pin
Andy Brummer10-Aug-12 4:56
sitebuilderAndy Brummer10-Aug-12 4:56 
GeneralRe: Looping through elements, to find textbox, and get values Pin
jkirkerx10-Aug-12 6:31
professionaljkirkerx10-Aug-12 6:31 
QuestionGet value from textbox created with createElement Pin
jkirkerx6-Aug-12 15:48
professionaljkirkerx6-Aug-12 15:48 
AnswerRe: Get value from textbox created with createElement Pin
BobJanova7-Aug-12 0:12
BobJanova7-Aug-12 0:12 
GeneralRe: Get value from textbox created with createElement Pin
jkirkerx7-Aug-12 6:24
professionaljkirkerx7-Aug-12 6:24 
AnswerRe: Get value from textbox created with createElement Pin
twseitex7-Aug-12 8:25
twseitex7-Aug-12 8:25 
GeneralRe: Get value from textbox created with createElement Pin
jkirkerx8-Aug-12 10:54
professionaljkirkerx8-Aug-12 10:54 
Questionadapt datatable jquery to jee application Pin
ahmadiss4-Aug-12 23:34
ahmadiss4-Aug-12 23:34 
AnswerRe: adapt datatable jquery to jee application Pin
Richard MacCutchan5-Aug-12 1:24
mveRichard MacCutchan5-Aug-12 1:24 
Questionshowmodaldialog return value undefined across domain Pin
Amr M. K.4-Aug-12 23:24
Amr M. K.4-Aug-12 23:24 
AnswerRe: showmodaldialog return value undefined across domain Pin
jkirkerx5-Aug-12 11:05
professionaljkirkerx5-Aug-12 11:05 
GeneralRe: showmodaldialog return value undefined across domain Pin
Amr M. K.6-Aug-12 22:05
Amr M. K.6-Aug-12 22:05 
AnswerRe: showmodaldialog return value undefined across domain Pin
BobJanova5-Aug-12 23:43
BobJanova5-Aug-12 23:43 

General General    News News    Suggestion Suggestion    Question Question    Bug Bug    Answer Answer    Joke Joke    Praise Praise    Rant Rant    Admin Admin   

Use Ctrl+Left/Right to switch messages, Ctrl+Up/Down to switch threads, Ctrl+Shift+Left/Right to switch pages.