Click here to Skip to main content
15,896,606 members
Home / Discussions / ASP.NET
   

ASP.NET

 
GeneralRe: Help with a static class Pin
Stephen Holdorf20-May-15 4:40
Stephen Holdorf20-May-15 4:40 
GeneralRe: Help with a static class Pin
Sascha Lefèvre20-May-15 4:43
professionalSascha Lefèvre20-May-15 4:43 
GeneralRe: Help with a static class Pin
Stephen Holdorf20-May-15 4:45
Stephen Holdorf20-May-15 4:45 
GeneralRe: Help with a static class Pin
Sascha Lefèvre20-May-15 4:54
professionalSascha Lefèvre20-May-15 4:54 
GeneralRe: Help with a static class Pin
Stephen Holdorf20-May-15 5:21
Stephen Holdorf20-May-15 5:21 
GeneralRe: Help with a static class Pin
Sascha Lefèvre20-May-15 5:26
professionalSascha Lefèvre20-May-15 5:26 
GeneralRe: Help with a static class Pin
jkirkerx20-May-15 6:55
professionaljkirkerx20-May-15 6:55 
SuggestionRe: Help with a static class Pin
Richard Deeming20-May-15 7:08
mveRichard Deeming20-May-15 7:08 
Because you really wanted a code review: Smile | :)

The configuration property is called ConnectionStrings, and the indexer in C# uses square brackets.

Your SqlConnection, SqlCommand and SqlDataReader objects should be wrapped in using blocks.

command.Parameters.AddWithValue is less verbose than creating a new parameter, setting its value, and adding it to the collection. Shorter code means you're more likely to stick with the pattern! Smile | :)

Since you're only returning a single value, there's no need for ExecuteReader; use ExecuteScalar instead. You can also add a TOP 1 to the query.

Your catch block is swallowing every exception, making it impossible to diagnose problems, or to even know when there is a problem.

C#
public int GetAccountSortByAccountCode(int account)
{
    string connStr = ConfigurationManager.ConnectionStrings["DefaultConnection"].ConnectionString;

    // You should be able to make every SQL query a "const";
    // otherwise, you've probably missed a SQL injection vulnerability:
    const string query = "SELECT TOP 1 ac_sort_order FROM lkup_account_codes WHERE ac_code = @account";

    using (var conn = new SqlConnection(connStr))
    using (var cmd = new SqlCommand(query, conn))
    {
        cmd.Parameters.AddWithValue("@account", account);

        conn.Open();
        object commandResult = command.ExecuteScalar();

        return (commandResult == null || Convert.IsDBNull(commandResult))
            ? 0
            : Convert.ToInt32(commandResult);
    }
}




"These people looked deep within my soul and assigned me a number based on the order in which I joined."
- Homer


GeneralRe: Help with a static class Pin
jkirkerx20-May-15 8:10
professionaljkirkerx20-May-15 8:10 
GeneralRe: Help with a static class Pin
Richard Deeming20-May-15 8:20
mveRichard Deeming20-May-15 8:20 
GeneralRe: Help with a static class Pin
jkirkerx20-May-15 9:15
professionaljkirkerx20-May-15 9:15 
GeneralRe: Help with a static class Pin
Stephen Holdorf21-May-15 2:50
Stephen Holdorf21-May-15 2:50 
QuestionProblem With ASP.Net Webform using JQuery AJAX Pin
MadDashCoder14-May-15 23:09
MadDashCoder14-May-15 23:09 
AnswerRe: Problem With ASP.Net Webform using JQuery AJAX Pin
F-ES Sitecore14-May-15 23:33
professionalF-ES Sitecore14-May-15 23:33 
QuestionASP.NET web forms label set by jquery not updated in database Pin
spirospap13-May-15 15:27
spirospap13-May-15 15:27 
AnswerRe: ASP.NET web forms label set by jquery not updated in database Pin
F-ES Sitecore13-May-15 22:32
professionalF-ES Sitecore13-May-15 22:32 
QuestionASP.NET WebDav file upload Pin
candogu12-May-15 21:21
candogu12-May-15 21:21 
AnswerRe: ASP.NET WebDav file upload Pin
Richard Deeming13-May-15 1:28
mveRichard Deeming13-May-15 1:28 
QuestionBest method of delegating password resets Pin
sczii11-May-15 16:10
sczii11-May-15 16:10 
QuestionTextbox in Updatepanel doesnt submit text Pin
senglory7-May-15 21:46
senglory7-May-15 21:46 
AnswerRe: Textbox in Updatepanel doesnt submit text Pin
jkirkerx8-May-15 11:37
professionaljkirkerx8-May-15 11:37 
GeneralRe: Textbox in Updatepanel doesnt submit text Pin
senglory8-May-15 21:25
senglory8-May-15 21:25 
GeneralRe: Textbox in Updatepanel doesnt submit text Pin
senglory25-May-15 10:07
senglory25-May-15 10:07 
Questiondefault page redirect when go back home page. Pin
Ibrar Tariq7-May-15 21:35
Ibrar Tariq7-May-15 21:35 
QuestionRe: default page redirect when go back home page. Pin
ZurdoDev8-May-15 8:39
professionalZurdoDev8-May-15 8:39 

General General    News News    Suggestion Suggestion    Question Question    Bug Bug    Answer Answer    Joke Joke    Praise Praise    Rant Rant    Admin Admin   

Use Ctrl+Left/Right to switch messages, Ctrl+Up/Down to switch threads, Ctrl+Shift+Left/Right to switch pages.