Click here to Skip to main content
15,886,919 members
Home / Discussions / C#
   

C#

 
GeneralRe: I need help improving my code Pin
Gilbert Consellado5-Nov-15 17:38
professionalGilbert Consellado5-Nov-15 17:38 
GeneralRe: I need help improving my code Pin
V.5-Nov-15 19:36
professionalV.5-Nov-15 19:36 
GeneralRe: I need help improving my code Pin
John Torjo5-Nov-15 19:45
professionalJohn Torjo5-Nov-15 19:45 
GeneralRe: I need help improving my code Pin
V.5-Nov-15 19:58
professionalV.5-Nov-15 19:58 
GeneralRe: I need help improving my code Pin
John Torjo5-Nov-15 20:04
professionalJohn Torjo5-Nov-15 20:04 
AnswerRe: I need help improving my code Pin
BillWoodruff5-Nov-15 19:25
professionalBillWoodruff5-Nov-15 19:25 
GeneralRe: I need help improving my code Pin
Gilbert Consellado5-Nov-15 23:42
professionalGilbert Consellado5-Nov-15 23:42 
GeneralRe: I need help improving my code Pin
BillWoodruff6-Nov-15 0:42
professionalBillWoodruff6-Nov-15 0:42 
I'm glad you found some value in my response.

While predicting the frequency of "correct" values entered by a user, or coming from some "other Control or code," is always dicey, I think it's often worth it.

I can't know, looking at your code, if it's always the case that if the 'value parameter is an Int32 then the Control parameter will be null.

If there is some variation in what you get in the Control parameter, you might be able to exploit that to simplify your code.

If you think the Type of the 'value parameter is going to be Type Int32 more frequently than Type String, or some other Type:
C#
if (value is Int32)
{
   // convert to Int32 from object
   int valasInt32 = Convert.ToInt32(val);

   // check for in range and return bool
   return ?
}

if (value is string)
{
   // process string input
   return ?
}

// if you get here 'value is some other Type than String or Int32: try to Convert to Int32 ?
Ideally, you could use the suggestion by Chris Quinn on this thread to create an input Control that never let you enter any character that was not an integer. Does the 3rd. party Control you use (DevXpress ?) provide any Keyboard hooks you could exploit ?
«I want to stay as close to the edge as I can without going over. Out on the edge you see all kinds of things you can't see from the center» Kurt Vonnegut.


modified 6-Nov-15 8:39am.

GeneralRe: I need help improving my code Pin
Gilbert Consellado6-Nov-15 2:17
professionalGilbert Consellado6-Nov-15 2:17 
GeneralRe: I need help improving my code Pin
BillWoodruff6-Nov-15 2:40
professionalBillWoodruff6-Nov-15 2:40 
GeneralRe: I need help improving my code Pin
Gilbert Consellado6-Nov-15 3:00
professionalGilbert Consellado6-Nov-15 3:00 
GeneralRe: I need help improving my code Pin
BillWoodruff6-Nov-15 4:14
professionalBillWoodruff6-Nov-15 4:14 
GeneralRe: I need help improving my code Pin
Gilbert Consellado6-Nov-15 4:45
professionalGilbert Consellado6-Nov-15 4:45 
AnswerRe: I need help improving my code Pin
V.5-Nov-15 19:52
professionalV.5-Nov-15 19:52 
GeneralRe: I need help improving my code Pin
Gilbert Consellado6-Nov-15 0:04
professionalGilbert Consellado6-Nov-15 0:04 
AnswerRe: I need help improving my code Pin
Chris Quinn5-Nov-15 22:14
Chris Quinn5-Nov-15 22:14 
GeneralRe: I need help improving my code Pin
Gilbert Consellado6-Nov-15 0:08
professionalGilbert Consellado6-Nov-15 0:08 
AnswerRe: I need help improving my code Pin
Rob Philpott5-Nov-15 23:03
Rob Philpott5-Nov-15 23:03 
GeneralRe: I need help improving my code Pin
Gilbert Consellado6-Nov-15 0:12
professionalGilbert Consellado6-Nov-15 0:12 
Questionwhy you cannot "spoof" an Interface to use to cast an Object to a Type you know the structure of ? Pin
BillWoodruff4-Nov-15 23:25
professionalBillWoodruff4-Nov-15 23:25 
AnswerRe: why you cannot "spoof" an Interface to use to cast an Object to a Type you know the structure of ? Pin
Eddy Vluggen4-Nov-15 23:42
professionalEddy Vluggen4-Nov-15 23:42 
GeneralRe: why you cannot "spoof" an Interface to use to cast an Object to a Type you know the structure of ? Pin
BillWoodruff5-Nov-15 4:44
professionalBillWoodruff5-Nov-15 4:44 
GeneralRe: why you cannot "spoof" an Interface to use to cast an Object to a Type you know the structure of ? Pin
Eddy Vluggen5-Nov-15 8:28
professionalEddy Vluggen5-Nov-15 8:28 
AnswerRe: why you cannot "spoof" an Interface to use to cast an Object to a Type you know the structure of ? PinPopular
Pete O'Hanlon5-Nov-15 0:55
mvePete O'Hanlon5-Nov-15 0:55 
GeneralRe: why you cannot "spoof" an Interface to use to cast an Object to a Type you know the structure of ? Pin
BillWoodruff5-Nov-15 4:46
professionalBillWoodruff5-Nov-15 4:46 

General General    News News    Suggestion Suggestion    Question Question    Bug Bug    Answer Answer    Joke Joke    Praise Praise    Rant Rant    Admin Admin   

Use Ctrl+Left/Right to switch messages, Ctrl+Up/Down to switch threads, Ctrl+Shift+Left/Right to switch pages.