How to handle multiple exceptions(Try..Catch) - C# Discussion Boards

19-Sep-17 4:55

I'm trying to figure out how to handle multiple exceptions based off my code. I want to have an error for API, one for Tracking Number, and then one for if the XML isn't formatted for the entire XML. Would using try catch for each be the best method and if so how would I code that. The code in bold is what I need assistance with in regards for Tracking Number and API Here is what I have currently:

try
            {
                if (bool.Parse(WebConfigurationManager.AppSettings["Debug"]) == true)
                    File.WriteAllText(Path.Combine(Server.MapPath("Log"), DateTime.Now.ToString("MMddyyy_HHmmss") + ".xml"), xmlRequest);
                // Determine Method to Call
                XmlDocument doc = new XmlDocument();
                doc.XmlResolver = null;
                doc.LoadXml(xmlRequest);
               
                string method = doc.FirstChild.Name;
                XmlNode mainNode = doc.FirstChild;

                if (method.ToLower() == "xml")
                {
                    method = doc.FirstChild.NextSibling.Name;
                    mainNode = doc.FirstChild.NextSibling;
                }

                if (method == "AmazonTrackingRequest")
                {
                    Data.General.Shipment prc = new Data.General.Shipment();
                    string pronum = mainNode.SelectSingleNode("TrackingNumber")?.InnerText;
                    prc.GetByProNumber(decimal.Parse(pronum));

                   
                                        
                    rspxml.Root.Add(new XElement("API", "4.0"));
                    rspxml.Root.Add(new XElement("PackageTrackingInfo"));
                    rspxml.Root.Element("PackageTrackingInfo").Add(new XElement("TrackingNumber", prc.ProNumber.ToString()));
                    rspxml.Root.Add(new XElement("PackageDestinationLocation"));
                    rspxml.Root.Element("PackageDestinationLocation").Add(new XElement("City", prc.Consignee.ToString()));
                    rspxml.Root.Element("PackageDestinationLocation").Add(new XElement("StateProvince", prc.Consignee.ToString()));
                    rspxml.Root.Element("PackageDestinationLocation").Add(new XElement("PostalCode", prc.Consignee.ToString()));
                    rspxml.Root.Element("PackageDestinationLocation").Add(new XElement("CountryCode", prc.Consignee.ToString()));
                    rspxml.Root.Add(new XElement("PackageDeliveryDate"));
                    rspxml.Root.Element("PackageDeliveryDate").Add(new XElement("ScheduledDeliveryDate", prc.Consignee.ToString()));
                    rspxml.Root.Element("PackageDeliveryDate").Add(new XElement("ReScheduledDeliveryDate", prc.Consignee.ToString()));
                    rspxml.Root.Add(new XElement("TrackingEventHistory"));
                    foreach (Saia.Data.General.Shipment.HistoryItem itm in prc.History)
                    {
                        rspxml.Root.Add(new XElement("TrackingEventDetail"));
                        rspxml.Root.Element("TrackingEventDetail").Add(new XElement("EventStatus", prc.History.ToString()));
                        rspxml.Root.Element("TrackingEventDetail").Add(new XElement("EventReason", prc.History.ToString()));
                        rspxml.Root.Element("TrackingEventDetail").Add(new XElement("EventDateTime", prc.History.ToString()));
                        rspxml.Root.Add(new XElement("EventLocation"));
                        
                        
                    }


                }

            }
            catch (CodeException e)
            {
               Error here
            }
            catch (Exception e)
            {
               Error here
            }

            return rspxml.ToString();
        }
    }
}

Richard Deeming19-Sep-17 5:22

19-Sep-17 5:22

The code you're using to build the XML can be greatly simplified:

rspxml.Root.Add(
    new XElement("API", "4.0"),
    new XElement("PackageTrackingInfo",
        new XElement("TrackingNumber", prc.ProNumber)
    ),
    new XElement("PackageDestinationLocation",
        new XElement("City", prc.Consignee),
        new XElement("StateProvince", prc.Consignee),
        new XElement("PostalCode", prc.Consignee),
        new XElement("CountryCode", prc.Consignee)
    ),
    new XElement("PackageDeliveryDate",
        new XElement("ScheduledDeliveryDate", prc.Consignee),
        new XElement("ReScheduledDeliveryDate", prc.Consignee)
    ),
    new XElement("TrackingEventHistory",
        prc.History.Select(item => new XElement("TrackingEventDetail",
            // TODO: Use the correct properties from the item, which weren't shown in your code:
            new XElement("EventStatus", item.EventStatus),
            new XElement("EventReason", item.EventReason),
            new XElement("EventDateTime", item.EventDateTime),
            new XElement("EventLocation", item.EventLocation)
        )
    )
);

This will also fix the problem you currently have where elements are appended to the wrong parent - particularly within the "history" loop.

Now you just need to explain what the problem is, and why you're still mixing XmlDocument and XDocument documents. Smile | :)

"These people looked deep within my soul and assigned me a number based on the order in which I joined."
- Homer

Bootzilla3319-Sep-17 5:32

19-Sep-17 5:32

The problem is, not really a problem, I have error codes for the Tracking Number and API Version XElement that I want to using exceptions like this:

rspxml = XDocument.Parse("<?xml version=\"1.0\" encoding=\"UTF - 8\"?><TrackingErrorInfo><TrackingNumber>12345678</TrackingNumber><TrackingErrorDetail><ErrorDetailCode>ERROR_101</ErrorDetailCode><ErrorDetailCodeDesc>INVALID TRACKING NUMBER</ErrorDetailCodeDesc></TrackingErrorDetail></TrackingErrorInfo></AmazonTrackingResponse>");

So for instance when there is an invalid Tracking Number I want the xml to read this error_101 code.

As for XMLDocument and XDocument, what are your suggestions for those?

Richard Deeming19-Sep-17 5:57

19-Sep-17 5:57

Firstly, that's not a valid XML document. You either need to remove the closing </AmazonTrackingResponse> tag, or insert the opening tag.

Secondly, you would read it in the same way as any other XML document:

var rspxml = XDocument.Parse("<?xml version=\"1.0\" encoding=\"UTF-8\"?><AmazonTrackingResponse><TrackingErrorInfo><TrackingNumber>12345678</TrackingNumber><TrackingErrorDetail><ErrorDetailCode>ERROR_101</ErrorDetailCode><ErrorDetailCodeDesc>INVALID TRACKING NUMBER</ErrorDetailCodeDesc></TrackingErrorDetail></TrackingErrorInfo></AmazonTrackingResponse>");

var errorInfo = rspxml.Descendants("TrackingErrorInfo").FirstOrDefault();
if (errorInfo != null)
{
    string trackingNumber = (string)errorInfo.Element("TrackingNumber");
    
    var detail = errorInfo.Element("TrackingErrorDetail");
    if (detail != null)
    {
        string errorCode = (string)detail.Element("ErrorDetailCode");
        string errorMessage = (string)detail.Element("ErrorDetailCodeDesc");
        // Do something with the error details...
    }
}

As for the XmlDocument vs XDocument, I'd suggest choosing one and sticking to it. The XDocument is generally easier to work with.

"These people looked deep within my soul and assigned me a number based on the order in which I joined."
- Homer

Bootzilla3319-Sep-17 6:05

19-Sep-17 6:05

Yeah I just post part of that tag. I didn't want to post the entire thing so that's why the beginning tag isn't showing here.

Also how would I check for errors on

rspxml.Root.Add(new XElement("APIVersion", "4.0"));

and I have an error code for if 'XML is not well formed', how would I do that one.

And thanks on using one between XMLDocument or XDocument.

modified 19-Sep-17 12:13pm.

Bootzilla3319-Sep-17 9:58

19-Sep-17 9:58

rspxml.Root.Add(
    new XElement("API", "4.0"),
    new XElement("PackageTrackingInfo",
        new XElement("TrackingNumber", prc.ProNumber)
    ),
    new XElement("PackageDestinationLocation",
        new XElement("City", prc.Consignee),
        new XElement("StateProvince", prc.Consignee),
        new XElement("PostalCode", prc.Consignee),
        new XElement("CountryCode", prc.Consignee)
    ),
    new XElement("PackageDeliveryDate",
        new XElement("ScheduledDeliveryDate", prc.Consignee),
        new XElement("ReScheduledDeliveryDate", prc.Consignee)
    ),
    new XElement("TrackingEventHistory",
        prc.History.Select(item => new XElement("TrackingEventDetail",
            // TODO: Use the correct properties from the item, which weren't shown in your code:
            new XElement("EventStatus", item.EventStatus),
            new XElement("EventReason", item.EventReason),
            new XElement("EventDateTime", item.EventDateTime),
            new XElement("EventLocation", item.EventLocation)
        )
    )
);

@RichardDeeming, Question about this code. On the

new XElement("TrackingEventHistory",
        prc.History.Select(item => new XElement("TrackingEventDetail",

line what should that be because you have .Select but that gives me an error 'Shipment.HistoryCollection' does not contain a definition for 'Select' and no extension method 'Select' accepting a first argument of type 'Shipment.HistoryCollection' could be found (are you missing a using directive or an assembly reference?)

Is that code I should use and need to add something to eliminate the error. What I was thinking it should be is:

new XElement("TrackingEventHistory",
         new XElement("TrackingEventDetail",
            // TODO: Use the correct properties from the item, which weren't shown in your code:
            new XElement("EventStatus", prc.History),
            new XElement("EventReason", prc.History),
            new XElement("EventDateTime", prc.History),
            new XElement("EventLocation", prc.History)

eddieangel19-Sep-17 12:18

eddieangel

19-Sep-17 12:18

Select is a Linq statement.

Try adding the proper using statement to the top of your class.

using System.Linq;
using System.Xml.Linq;

If those do not work you may need to cast your object to something else.

Bootzilla3320-Sep-17 2:56

20-Sep-17 2:56

I already have these

using System.Linq;
using System.Xml.Linq;

You mentioned Cast to something else but not sure what to do there. Anyone else with any suggestions would be appreciated.If no one has any suggestions then I will have to go back to the ToString code I had previously and just go with that.
This is what I have now:

 public string ProcessXML(string xmlRequest)
        {
            XDocument rspxml = null;
            try
            {
                if (bool.Parse(WebConfigurationManager.AppSettings["Debug"]) == true)
                    File.WriteAllText(Path.Combine(Server.MapPath("Log"), DateTime.Now.ToString("MMddyyy_HHmmss") + ".xml"), xmlRequest);
                // Determine Method to Call
                XmlDocument doc = new XmlDocument();
                doc.XmlResolver = null;
                doc.LoadXml(xmlRequest);

                string method = doc.FirstChild.Name;
                XmlNode mainNode = doc.FirstChild;

                if (method.ToLower() == "xml")
                {
                    method = doc.FirstChild.NextSibling.Name;
                    mainNode = doc.FirstChild.NextSibling;
                }

                if (method == "AmazonTrackingRequest")
                {
                    Saia.Data.General.Shipment prc = new Data.General.Shipment();
                    string pronum = mainNode.SelectSingleNode("TrackingNumber").InnerText;
                    prc.GetByProNumber(decimal.Parse(pronum));

                    if (string.IsNullOrEmpty(pronum))
                    {
                        rspxml = XDocument.Parse("<?xml version=\"1.0\" encoding=\"UTF - 8\"?><AmazonTrackingResponse xmlns: xsi = 'http://www.w3.org/2001/XMLSchema-instance'xsi: noNamespaceSchemaLocation='AmazonTrackingResponse.xsd'><APIVersion >4.0</APIVersion><TrackingErrorInfo><TrackingNumber>12345678</TrackingNumber><TrackingErrorDetail><ErrorDetailCode>ERROR_101</ErrorDetailCode><ErrorDetailCodeDesc>INVALID TRACKING NUMBER</ErrorDetailCodeDesc></TrackingErrorDetail></TrackingErrorInfo></AmazonTrackingResponse>");
                    }
                    else
                    {
                        decimal tn = 0.0m;

                        if (decimal.TryParse(pronum, out tn))

                        {
                            prc.GetByProNumber(tn);
                        }
                        else
                        {
                            Console.WriteLine("Unable to parse '{0}'.", pronum);
                        }
                    }


                    rspxml = XDocument.Parse("<AmazonTrackingResponse xmlns:xsi='http://www.w3.org/2001/XMLSchema-instance' xsi:noNamespaceSchemaLocation='AmazonTrackingResponse.xsd'></AmazonTrackingResponse>");
                    rspxml.Root.Add(new XElement("APIVersion", "4.0"));

                    var errorInfo = rspxml.Descendants("TrackingErrorInfo").FirstOrDefault();
                    if (errorInfo != null)
                    {
                        string packtrackinginfo = (string)errorInfo.Element("PackageTrackingInfo");

                        var detail = errorInfo.Element("TrackingErrorDetail");
                        if (detail != null)
                        {
                            string errorCode = (string)detail.Element("ErrorDetailCode");
                            string errorMessage = (string)detail.Element("ErrorDetailCodeDesc");
                            // Do something with the error details...
                        }
                    }


        rspxml.Root.Add(
        new XElement("API", "4.0"),
        new XElement("PackageTrackingInfo",
            new XElement("TrackingNumber", prc.ProNumber)
        ),
        new XElement("PackageDestinationLocation",
            new XElement("City", prc.Consignee),
            new XElement("StateProvince", prc.Consignee),
            new XElement("PostalCode", prc.Consignee),
            new XElement("CountryCode", prc.Consignee)
        ),
        new XElement("PackageDeliveryDate",
            new XElement("ScheduledDeliveryDate", prc.Consignee),
            new XElement("ReScheduledDeliveryDate", prc.Consignee)
        ),
        new XElement("TrackingEventHistory",
            new XElement("TrackingEventDetail",
            new XElement("EventStatus", prc.History),
            new XElement("EventReason", prc.History),
            new XElement("EventDateTime", prc.History)

        ),
         new XElement("EventLocation",
            new XElement("Street1", prc.History),
            new XElement("City", prc.History),
            new XElement("StateProvince", prc.History),
            new XElement("PostalCode", prc.History),
            new XElement("CountryCode", prc.History),
            new XElement("SignedForByName", prc.History)
        ),
         new XElement("PickupStoreInfo",
         new XElement("PickupDueDateDetails",
            new XElement("Date", prc.History),
            new XElement("UTCOffset", prc.History)
        ),
         new XElement("PickupID",
         new XElement("StoreName",
         new XElement("LocationID",
         new XElement("StoreLocation",
            new XElement("Street1", prc.History),
            new XElement("City", prc.History),
            new XElement("StateProvince", prc.History),
            new XElement("PostalCode", prc.History),
            new XElement("CountryCode", prc.History)
         )
         )
         )
         )
         )
         )
         );
                 

                    }


                
            }

            
            catch (CodeException e)
            {
                rspxml = XDocument.Parse("<?xml version=\"1.0\" encoding=\"UTF - 8\"?><AmazonTrackingResponse xmlns: xsi = 'http://www.w3.org/2001/XMLSchema-instance'xsi: noNamespaceSchemaLocation='AmazonTrackingResponse.xsd'><APIVersion>4.0</APIVersion ><TrackingErrorInfo><TrackingNumber>12345678</TrackingNumber><TrackingErrorDetail><ErrorDetailCode>ERROR_203</ErrorDetailCode><ErrorDetailCodeDesc>XML DOCUMENT NOT WELL FORMED</ErrorDetailCodeDesc></TrackingErrorDetail></TrackingErrorInfo></AmazonTrackingResponse>");
                Core.Framework.Debug.CodeException(xmlRequest, e);
            }
            catch (Exception e)
            {
                rspxml = XDocument.Parse("<?xml version=\"1.0\" encoding=\"UTF - 8\"?><AmazonTrackingResponse xmlns: xsi = 'http://www.w3.org/2001/XMLSchema-instance'xsi: noNamespaceSchemaLocation='AmazonTrackingResponse.xsd'><APIVersion>4.0</APIVersion ><TrackingErrorInfo><TrackingNumber>12345678</TrackingNumber><TrackingErrorDetail><ErrorDetailCode>ERROR_203</ErrorDetailCode><ErrorDetailCodeDesc>XML DOCUMENT NOT WELL FORMED</ErrorDetailCodeDesc></TrackingErrorDetail></TrackingErrorInfo></AmazonTrackingResponse>");
                Core.Framework.Debug.Exception(xmlRequest, e);
            }

            return rspxml.ToString();
        }
        public class EventCode
        {
            public enum EvCodes {Delivered, DispatchedForDelivery, DepartedFromTerminal, ArrivedAtDestinationTerminal, DNF};
            public static void Main()
            {
                string val = "Dispatched For Delivery";
                switch ((EvCodes)Enum.Parse(typeof(EvCodes), val.Replace(" ", "")))
                {
                    case EvCodes.DispatchedForDelivery:
                    case EvCodes.Delivered:
                        Console.WriteLine("EVENT_301");
                        break;
                    case EvCodes.DepartedFromTerminal:
                        Console.WriteLine("EVENT_202");
                        break;
                    case EvCodes.ArrivedAtDestinationTerminal:
                        Console.WriteLine("EVENT_202");
                        break;
                    case EvCodes.DNF:
                        Console.WriteLine("EVENT_101");
                        Console.WriteLine("EVENT_102");
                        break;
                   
                    default:
                        break;
                }

            }
        }
    }
}

modified 20-Sep-17 9:27am.

Richard Deeming20-Sep-17 10:01

20-Sep-17 10:01

What interfaces are implemented by Shipment.HistoryCollection?

Presumably it implements IEnumerable, but not IEnumerable<T>; in which case, you need to insert a call to Cast[^] before the call to Select:

new XElement("TrackingEventHistory",
    prc.History.Cast<Saia.Data.General.Shipment.HistoryItem>().Select(item => new XElement("TrackingEventDetail",
        // TODO: Use the correct properties from the item, which weren't shown in your code:
        new XElement("EventStatus", item.EventStatus),
        new XElement("EventReason", item.EventReason),
        new XElement("EventDateTime", item.EventDateTime),
        new XElement("EventLocation", item.EventLocation)
    )
)

"These people looked deep within my soul and assigned me a number based on the order in which I joined."
- Homer

Bootzilla3321-Sep-17 3:58

21-Sep-17 3:58

OK this is what I have now and it seems to be working. A couple of questions/issues:

1. If you look at the commented out code below with the .ToString, I have PickupStoreInfo and then PickupDueDateDetails which is setup similar to the TrackingEventHistory and TrackingEventDetail, so would that be set up the same way with the Cast or should that be setup differently or is it ok like it is now.

rspxml.Root.Add(new XElement("PickupStoreInfo"));
                    //    rspxml.Root.Add(new XElement("PickupDueDateDetails"));
                    //    rspxml.Root.Element("PickupDueDateDetails").Add(new XElement("Date", prc.History.ToString()));
                    //    rspxml.Root.Element("PickupDueDateDetails").Add(new XElement("UTCOffset", prc.History.ToString()));

2. You mentioned about using one of either XDocument or XmlDocument, I tried this and when I change to XDocument on this line:

XmlDocument doc = new XmlDocument();

I get errors 'XDocument' does not contain a definition for 'XmlResolver' and no extension method 'XmlResolver' accepting a first argument of type 'XDocument' could be found (are you missing a using directive or an assembly reference?).

Same error definition for FirstChild, LoadXML.

If I change everything to XmlDocument like on this line from XDocument to XmlDocument:

rspxml = XDocument.Parse

I get 'XmlDocument does not contain definition for 'Parse'.

3.Is all of my syntax correct, specifically all of the parentheses after this line:

new XElement("CountryCode", prc.History)

I really appreciate all of your help and look forward to your response.

Here is the full code for this method:

public string ProcessXML(string xmlRequest)
        {
            XDocument rspxml = null;
            try
            {
                if (bool.Parse(WebConfigurationManager.AppSettings["Debug"]) == true)
                    File.WriteAllText(Path.Combine(Server.MapPath("Log"), DateTime.Now.ToString("MMddyyy_HHmmss") + ".xml"), xmlRequest);
                // Determine Method to Call
                XmlDocument doc = new XmlDocument();
                doc.XmlResolver = null;
                doc.LoadXml(xmlRequest);

                string method = doc.FirstChild.Name;
                XmlNode mainNode = doc.FirstChild;

                if (method.ToLower() == "xml")
                {
                    method = doc.FirstChild.NextSibling.Name;
                    mainNode = doc.FirstChild.NextSibling;
                }

                if (method == "AmazonTrackingRequest")
                {
                    Saia.Data.General.Shipment prc = new Data.General.Shipment();
                    string pronum = mainNode.SelectSingleNode("TrackingNumber").InnerText;
                    prc.GetByProNumber(decimal.Parse(pronum));

                    if (string.IsNullOrEmpty(pronum))
                    {
                        rspxml = XDocument.Parse("<?xml version=\"1.0\" encoding=\"UTF - 8\"?><AmazonTrackingResponse xmlns: xsi = 'http://www.w3.org/2001/XMLSchema-instance'xsi: noNamespaceSchemaLocation='AmazonTrackingResponse.xsd'><APIVersion >4.0</APIVersion><TrackingErrorInfo><TrackingNumber>12345678</TrackingNumber><TrackingErrorDetail><ErrorDetailCode>ERROR_101</ErrorDetailCode><ErrorDetailCodeDesc>INVALID TRACKING NUMBER</ErrorDetailCodeDesc></TrackingErrorDetail></TrackingErrorInfo></AmazonTrackingResponse>");
                    }
                    else
                    {
                        decimal tn = 0.0m;

                        if (decimal.TryParse(pronum, out tn))

                        {
                            prc.GetByProNumber(tn);
                        }
                        else
                        {
                            Console.WriteLine("Unable to parse '{0}'.", pronum);
                        }
                    }


                    rspxml = XDocument.Parse("<AmazonTrackingResponse xmlns:xsi='http://www.w3.org/2001/XMLSchema-instance' xsi:noNamespaceSchemaLocation='AmazonTrackingResponse.xsd'></AmazonTrackingResponse>");
                    rspxml.Root.Add(new XElement("APIVersion", "4.0"));

                    var errorInfo = rspxml.Descendants("TrackingErrorInfo").FirstOrDefault();
                    if (errorInfo != null)
                    {
                        string packtrackinginfo = (string)errorInfo.Element("PackageTrackingInfo");

                        var detail = errorInfo.Element("TrackingErrorDetail");
                        if (detail != null)
                        {
                            string errorCode = (string)detail.Element("ErrorDetailCode");
                            string errorMessage = (string)detail.Element("ErrorDetailCodeDesc");
                            // Do something with the error details...
                        }
                    }


        rspxml.Root.Add(
        new XElement("API", "4.0"),
        new XElement("PackageTrackingInfo",
            new XElement("TrackingNumber", prc.ProNumber)
        ),
        new XElement("PackageDestinationLocation",
            new XElement("City", prc.Consignee),
            new XElement("StateProvince", prc.Consignee),
            new XElement("PostalCode", prc.Consignee),
            new XElement("CountryCode", prc.Consignee)
        ),
        new XElement("PackageDeliveryDate",
            new XElement("ScheduledDeliveryDate", prc.Consignee),
            new XElement("ReScheduledDeliveryDate", prc.Consignee)
        ),
        new XElement("TrackingEventHistory", 
        prc.History.Cast<Saia.Data.General.Shipment.HistoryItem>().Select(item => new XElement("TrackingEventDetail",
            new XElement("EventStatus", prc.History,
            new XElement("EventReason", prc.History),
            new XElement("EventDateTime", prc.History)

        ),
         new XElement("EventLocation",
            new XElement("Street1", prc.History),
            new XElement("City", prc.History),
            new XElement("StateProvince", prc.History),
            new XElement("PostalCode", prc.History),
            new XElement("CountryCode", prc.History),
            new XElement("SignedForByName", prc.History)
        ),
         new XElement("PickupStoreInfo",
         new XElement("PickupDueDateDetails",
            new XElement("Date", prc.History),
            new XElement("UTCOffset", prc.History)
        ),
         new XElement("PickupID",
         new XElement("StoreName",
         new XElement("LocationID",
         new XElement("StoreLocation",
            new XElement("Street1", prc.History),
            new XElement("City", prc.History),
            new XElement("StateProvince", prc.History),
            new XElement("PostalCode", prc.History),
            new XElement("CountryCode", prc.History)
         )
         )
         )
         )
         )
         )
         )
         )
         );
         
         

   

                    //rspxml.Root.Add(new XElement("PackageTrackingInfo"));
                    //rspxml.Root.Element("PackageTrackingInfo").Add(new XElement("TrackingNumber", prc.ProNumber.ToString()));
                    //rspxml.Root.Add(new XElement("PackageDestinationLocation"));
                    //rspxml.Root.Element("PackageDestinationLocation").Add(new XElement("City", prc.Consignee.ToString()));
                    //rspxml.Root.Element("PackageDestinationLocation").Add(new XElement("StateProvince", prc.Consignee.ToString()));
                    //rspxml.Root.Element("PackageDestinationLocation").Add(new XElement("PostalCode", prc.Consignee.ToString()));
                    //rspxml.Root.Element("PackageDestinationLocation").Add(new XElement("CountryCode", prc.Consignee.ToString()));
                    //rspxml.Root.Add(new XElement("PackageDeliveryDate"));
                    //rspxml.Root.Element("PackageDeliveryDate").Add(new XElement("ScheduledDeliveryDate", prc.Consignee.ToString()));
                    //rspxml.Root.Element("PackageDeliveryDate").Add(new XElement("ReScheduledDeliveryDate", prc.Consignee.ToString()));
                    //rspxml.Root.Add(new XElement("TrackingEventHistory"));
                    //foreach (Saia.Data.General.Shipment.HistoryItem itm in prc.History)
                    //{
                    //    rspxml.Root.Add(new XElement("TrackingEventDetail"));
                    //    rspxml.Root.Element("TrackingEventDetail").Add(new XElement("EventStatus", prc.History.ToString()));
                    //    rspxml.Root.Element("TrackingEventDetail").Add(new XElement("EventReason", prc.History.ToString()));
                    //    rspxml.Root.Element("TrackingEventDetail").Add(new XElement("EventDateTime", prc.History.ToString()));
                    //    rspxml.Root.Add(new XElement("EventLocation"));
                    //    rspxml.Root.Element("EventLocation").Add(new XElement("Street1", prc.History.ToString()));
                    //    rspxml.Root.Element("EventLocation").Add(new XElement("City", prc.History.ToString()));
                    //    rspxml.Root.Element("EventLocation").Add(new XElement("StateProvince", prc.History.ToString()));
                    //    rspxml.Root.Element("EventLocation").Add(new XElement("PostalCode", prc.History.ToString()));
                    //    rspxml.Root.Element("EventLocation").Add(new XElement("CountryCode", prc.History.ToString()));
                    //    rspxml.Root.Element("TrackingEventDetail").Add(new XElement("SignedForByName", prc.History.ToString()));
                    //    rspxml.Root.Add(new XElement("PickupStoreInfo"));
                    //    rspxml.Root.Add(new XElement("PickupDueDateDetails"));
                    //    rspxml.Root.Element("PickupDueDateDetails").Add(new XElement("Date", prc.History.ToString()));
                    //    rspxml.Root.Element("PickupDueDateDetails").Add(new XElement("UTCOffset", prc.History.ToString()));
                    //    rspxml.Root.Add(new XElement("PickupID"));
                    //    rspxml.Root.Add(new XElement("StoreName"));
                    //    rspxml.Root.Add(new XElement("LocationID"));
                    //    rspxml.Root.Add(new XElement("StoreLocation"));
                    //    rspxml.Root.Element("StoreLocation").Add(new XElement("Street1", prc.History.ToString()));
                    //    rspxml.Root.Element("StoreLocation").Add(new XElement("City", prc.History.ToString()));
                    //    rspxml.Root.Element("StoreLocation").Add(new XElement("StateProvince", prc.History.ToString()));
                    //    rspxml.Root.Element("StoreLocation").Add(new XElement("PostalCode", prc.History.ToString()));
                    //    rspxml.Root.Element("StoreLocation").Add(new XElement("CountryCode", prc.History.ToString()));

                    }


                
            }

            
            catch (CodeException e)
            {
                rspxml = XDocument.Parse("<?xml version=\"1.0\" encoding=\"UTF - 8\"?><AmazonTrackingResponse xmlns: xsi = 'http://www.w3.org/2001/XMLSchema-instance'xsi: noNamespaceSchemaLocation='AmazonTrackingResponse.xsd'><APIVersion>4.0</APIVersion ><TrackingErrorInfo><TrackingNumber>12345678</TrackingNumber><TrackingErrorDetail><ErrorDetailCode>ERROR_203</ErrorDetailCode><ErrorDetailCodeDesc>XML DOCUMENT NOT WELL FORMED</ErrorDetailCodeDesc></TrackingErrorDetail></TrackingErrorInfo></AmazonTrackingResponse>");
                Core.Framework.Debug.CodeException(xmlRequest, e);
            }
            catch (Exception e)
            {
                rspxml = XDocument.Parse("<?xml version=\"1.0\" encoding=\"UTF - 8\"?><AmazonTrackingResponse xmlns: xsi = 'http://www.w3.org/2001/XMLSchema-instance'xsi: noNamespaceSchemaLocation='AmazonTrackingResponse.xsd'><APIVersion>4.0</APIVersion ><TrackingErrorInfo><TrackingNumber>12345678</TrackingNumber><TrackingErrorDetail><ErrorDetailCode>ERROR_203</ErrorDetailCode><ErrorDetailCodeDesc>XML DOCUMENT NOT WELL FORMED</ErrorDetailCodeDesc></TrackingErrorDetail></TrackingErrorInfo></AmazonTrackingResponse>");
                Core.Framework.Debug.Exception(xmlRequest, e);
            }

            return rspxml.ToString();
        }

Richard Deeming21-Sep-17 4:32

21-Sep-17 4:32

1) It's not clear what you're trying to do here. You're not adding an element for each history item, so you don't need the Select; you just need to pass in the correct values to the elements.

rspxml.Root.Add(new XElement("PickupDueDateDetails"),
    new XElement("Date", prc.PickupDueDate),
    new XElement("UTCOffset", prc.PickupDueDateOffset)
);

2) You can't just change the type and expect the existing code to work. You need to fix the existing code to use the correct methods for the type.

For example, this:

XmlDocument doc = new XmlDocument();
doc.XmlResolver = null;
doc.LoadXml(xmlRequest);

would become:

XDocument doc = XDocument.Parse(xmlResult);

This:

string method = doc.FirstChild.Name;
XmlNode mainNode = doc.FirstChild;

if (method.ToLower() == "xml")
{
    method = doc.FirstChild.NextSibling.Name;
    mainNode = doc.FirstChild.NextSibling;
}

would become:

XElement mainNode = doc.Root;
string method = mainNode.Name.LocalName;
// No need to check for the processing instruction here...

This:

string pronum = mainNode.SelectSingleNode("TrackingNumber").InnerText;

would become:

string pronum = (string)mainNode.Element("TrackingNumber");

3) I don't know. Does it compile? Does it do what you expect it to do?

I very much doubt that prc.History is the correct property to use for all of those elements.

"These people looked deep within my soul and assigned me a number based on the order in which I joined."
- Homer

Bootzilla3321-Sep-17 4:52

21-Sep-17 4:52

1) This may help explain. This is some of the XML I am trying to write out:

XML

</PackageDeliveryDate>
<TrackingEventHistory>
<TrackingEventDetail>
<EventStatus>LK</EventStatus>
<EventReason>AQ</EventReason>
<EventDateTime>2004-08-22T11:00:00-
08:00</EventDateTime>
<EventLocation>
<City>SEATTLE</City>
<StateProvince>WA</StateProvince>
<PostalCode>98107</PostalCode>
<CountryCode>US</CountryCode>
</EventLocation>
<SignedForByName>JOHN GALT</SignedForByName>
</TrackingEventDetail>
<PickupStoreInfo>
<PickupDueDateDetails>
<Date>2004-08-25</Date>
<UTCOffset>-07:00</UTCOffset>
</PickupDueDateDetails>
<PickupID>92253</PickupID>
<StoreName>US-PRI-DEL-03</StoreName>
<LocationID>19632</LocationId>
<StoreLocation>
<Street1>NW Market St</Street1>
<City>SEATTLE</City>
<StateProvince>WA</StateProvince>
<PostalCode>98107</PostalCode>
<CountryCode>US</CountryCode>
</StoreLocation>
</PickupStoreInfo>
</TrackingEventHistory>

Am I doing a rspxml.Root.Add for each section or can I use like this:

new XElement("PickupStoreInfo",
        new XElement("PickupDueDateDetails",
           new XElement("Date", prc.History),
           new XElement("UTCOffset", prc.History)
       ),

So based off this, how would that be written out in the code.

2) I updated the code and that seems to be working ok.

3) It does compile. And yes those are supposed to be prc.History. There are only two elements/fields that I'm concerned with and that is the Consignee and History so yes they should be prc.History. I just need to pull in the fields for in those two areas.

Richard Deeming21-Sep-17 5:18

21-Sep-17 5:18

Bootzilla33 wrote:

new XElement("PickupStoreInfo",
    new XElement("PickupDueDateDetails",
        new XElement("Date", prc.History),
        new XElement("UTCOffset"</span>, prc.History)
    ),

Since PickupDueDateDetails is a child of PickupStoreInfo, that's the correct way to do it.

But passing prc.History as the value for every node isn't going to produce the correct values in the resulting XML. Instead, you'll get the result of calling prc.History.ToString() inserted into every node.

If you don't need to pass a value in the node, it would be better to not pass a value to it, or exclude it from the document.

"These people looked deep within my soul and assigned me a number based on the order in which I joined."
- Homer

Bootzilla3321-Sep-17 5:41

21-Sep-17 5:41

I have the same thing for prc.Consignee. So what would you suggest something like this:

),
         new XElement("PickupStoreInfo",
         new XElement("PickupDueDateDetails",
            new XElement("Date"),
            new XElement("UTCOffset")
        ),

I pretty much have to pass a value in the node or else how else would I get the values?

Richard Deeming21-Sep-17 6:07

21-Sep-17 6:07

If you have to pass a value, then pass the value that the API is expecting. Passing the same (invalid) string for each node will most likely cause the API to return an error.

"These people looked deep within my soul and assigned me a number based on the order in which I joined."
- Homer

Bootzilla3321-Sep-17 6:15

21-Sep-17 6:15

Richard Deeming wrote:
If you have to pass a value, then pass the value that the API is expecting.

What would that be?

Something like:

new XElement("PickupStoreInfo",
        new XElement("PickupDueDateDetails",
           new XElement("Date", Date),
           new XElement("UTCOffset", UTCOffset)
       ),

Not sure???

Richard Deeming21-Sep-17 6:19

21-Sep-17 6:19

Pass in the values that the API is expecting you to pass in for the request.

You've presumably read the API documentation? The expected values should be documented there.

"These people looked deep within my soul and assigned me a number based on the order in which I joined."
- Homer

Bootzilla3321-Sep-17 6:40