Use try catch in C#?

Question

1.00/5 (2 votes)

See more:

Hello to this method I want to do a try catch blog.
Is it true that I use try catch in this way? if the condition is true try is not an error.

public void Insert()
    {
        DataTable table= Dbc.GetDataTable( "select //sql command continue where ıd>3 ,commandtype.text );

    if(table.rows.count>0)
    {
    List<int> List=(from row in table select //sql command continue)).ToList();

    if(List.Count() != 2)
    {
        Complete(table);
    }

    DeleteFalse();
    }
    }

What I have tried:

I try code

public void Insert()
            {
    try{
                DataTable table= Dbc.GetDataTable( "select //sql command continue where ıd>3 ,commandtype.text );

            if(table.rows.count>0)
            {
            List<int> List=(from row in table select //sql command continue)).ToList();

            if(List.Count() != 2)
            {
                Complete(table);
            }

            DeleteFalse();
            }
    }
    catch (Exception exceptions) {
          Console.WriteLine("Error");
        }
            }

Posted 3-Jan-19 9:06am

StudentSC

Updated 5-Jan-19 12:07pm

v2

Add a Solution

Comments

Eric Lynch 3-Jan-19 15:17pm

Typically, if you have a catch block, you should DO something with the exception. There are many possible actions you can take. Some common options include logging the text of the exception, re-trying the operation (for more specific exceptions like timeout), and returning an indication that the operation failed. It is seldom a good idea to simply discard the exception (as your "have tried" code would do).

It might help if you improve your question to describe your problem a little bit better. What were your expectations from the code you tried? How did the results you observed fail to meet those expectations? Its unclear from your current question if you are simply struggling to understand try/catch or you have some specific, desired outcome that you are having trouble implementing.

[no name] 3-Jan-19 15:32pm

Hello Adding method is doing my process. But I want this method returns a false result I want to return to the catch. So this methodum is already running. If it does not work, I want to fall into the catch. Thank you for your help.

Eric Lynch 3-Jan-19 16:56pm

Sorry, I am a bit confused about your goals. I think you may be misunderstanding a few different concepts.

In your reply, you indicate an expectation for your method to return "a false result". Currently, your method cannot return any result, it is of type "void". If you want it to return a true/false result, you need to change its datatype to "bool". Though, based on the remainder of your sentence and your code, it seems unlikely that this is actually your intent.

Next, you indicate that you want to "return to the catch". Perhaps, you're using imprecise terminology, but this is not exactly how a "catch" works.

In the "have tried" section of your question, if any error (exception) were to occur in the "try" block, you would stop executing the code in that "try" block.

Instead, at that point, you would begin executing the first line of code contained in the "catch" block. Since, you currently have no code in that "catch" block, you would do nothing. Effectively, you would discard (ignore) the exception. You would then continue to the next line of code after the "catch" block.

Since you have no code after the "catch" block, you would then return nothing (void) from the "Adding" method.

While I am fairly certain this is not what you intend, I am less clear on what you do intend.

Rather than replying to my comment, I again you suggest you click "Improve Question" and edit your question to add more detail.

You need to be specific about at least two things:
1) What EXACTLY do you expect/want to happen if the code in the "try" block succeeds?
2) What EXACTLY do you expect/want to happen if the code in the "try" block fails? This is the code you want to put in the "catch" block.

Currently, in failure, you do nothing. Also, in either success or failure, you return nothing (void) from the "Adding" method.

Keep in mind that your code may fail at almost any line within the "try" block. For example, it might fail during your SQL query, or during your call to FonkA, or during your call to DeleteNonCorrectAdd. Any of these failures, would result in the code "skipping" to the first line of code in your "catch" block.

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

RickZeeland · Answer 1 · 2019-01-03T09:30:00

Solution 1

See example here: https://www.dotnetperls.com/exception[^]

Posted 3-Jan-19 9:30am

RickZeeland

Maciej Los · Answer 2 · 2019-01-04T01:59:00

Solution 2

Please, read the Eric Lynch[^] comments first.
Then look at these articles, which may help you to understand when to use try - catch block:
How to: Use the Try-Catch Block to Catch Exceptions | Microsoft Docs[^]
try-catch - C# Reference | Microsoft Docs[^]

Posted 4-Jan-19 1:59am

Maciej Los