Error check in asp.net

Question

4.00/5 (1 vote)

See more:

I have a code like this:

C#

private void checkError()
{
    if (txtName.Text == string.Empty)
    {
        WebMsgBox.Show("Please Enter User Name");
        txtName.Focus();
        return;
    }
    if (txtUserId.Text.Trim() == string.Empty)
    {
        WebMsgBox.Show("Please Enter UserId");
        txtUserId.Focus();
        return;
    }
    if (txtPasword.Text.Trim() == string.Empty)
    {
        WebMsgBox.Show("Please Enter Password");
        txtPasword.Focus();
        return;
    }
}

This function i have declare in buttion_click event before the save code.

protected void btnSubmit_Click(object sender, EventArgs e)
    {
        try
        {
            checkError();
            SqlConnection con = database.GetConnection();
            SqlCommand com = new SqlCommand("spRegistration", con);
            com.CommandType = CommandType.StoredProcedure;
            com.Parameters.AddWithValue("@Name", txtName.Text);
            com.Parameters.AddWithValue("@UserId", txtUserId.Text);
            com.Parameters.AddWithValue("@Password", txtPasword.Text);
            com.Parameters.AddWithValue("@Date", txtDate.Text);
            com.ExecuteNonQuery();
            WebMsgBox.Show("Accounts Created Successfully");
            clearFields();

        }
        catch (Exception ex)
        {
            WebMsgBox.Show("Error Message:" + ex.Message);
        }
      
    }

Then if we click save button without any value in textbox, the null value will be insert into the database. How can i solve it.
Please help me.

Thanks in advance

Posted 19-May-11 2:42am

rahul dev123

Updated 19-May-11 2:45am

Ramalinga Koushik

v2

Add a Solution

Comments

[no name] 19-May-11 8:46am

Edited for Code Block for easy understandability

3 solutions

Solution 1

RequiredFieldValidator[^], perhaps.

Posted 19-May-11 2:46am

R. Giskard Reventlov

Comments

rahul dev123 19-May-11 8:56am

I use RequireFieldValidator but i also want to check in code behind

Solution 3

Change your error routine to return a bool:

private bool checkError()
{
    if (txtName.Text == string.Empty)
    {
        WebMsgBox.Show("Please Enter User Name");
        txtName.Focus();
        return true;
    }
    if (txtUserId.Text.Trim() == string.Empty)
    {
        WebMsgBox.Show("Please Enter UserId");
        txtUserId.Focus();
        return true;
    }
    if (txtPasword.Text.Trim() == string.Empty)
    {
        WebMsgBox.Show("Please Enter Password");
        txtPasword.Focus();
        return true;
    }
    return false;
}

Then just check the return code:

protected void btnSubmit_Click(object sender, EventArgs e)
    {
        try
        {
            if (!checkError())
            {
                SqlConnection con = database.GetConnection();
                ....
                clearFields();
            }
        }
        catch (Exception ex)
        {
            WebMsgBox.Show("Error Message:" + ex.Message);
        }
      
    }

Posted 19-May-11 2:51am

OriginalGriff

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Steven.Pinto2000 · Accepted Answer · 2011-05-19T02:51:00

Insted of void use return a boolean that is true or false so here is how it goes

C#

private bool checkError()
{
    if (txtName.Text == string.Empty)
    {
        WebMsgBox.Show("Please Enter User Name");
        txtName.Focus();
        return false;
    }
    if (txtUserId.Text.Trim() == string.Empty)
    {
        WebMsgBox.Show("Please Enter UserId");
        txtUserId.Focus();
        return false;
    }
    if (txtPasword.Text.Trim() == string.Empty)
    {
        WebMsgBox.Show("Please Enter Password");
        txtPasword.Focus();
        return false;
    }
    else return true;

}

C#

protected void btnSubmit_Click(object sender, EventArgs e)
{
try
{
if(checkError())
{
  SqlConnection con = database.GetConnection();
  SqlCommand com = new SqlCommand("spRegistration", con);
  com.CommandType = CommandType.StoredProcedure;
  com.Parameters.AddWithValue("@Name", txtName.Text);
  com.Parameters.AddWithValue("@UserId", txtUserId.Text);
  com.Parameters.AddWithValue("@Password", txtPasword.Text);
  com.Parameters.AddWithValue("@Date", txtDate.Text);
  com.ExecuteNonQuery();
  WebMsgBox.Show("Accounts Created Successfully");
  clearFields();
 }

}
catch (Exception ex)
{
WebMsgBox.Show("Error Message:" + ex.Message);
}

}