C# SQL Insert not working!

Question

0.00/5 (No votes)

See more:

I have a login Database made in Microsoft Access and I created a program in C# that i want to allow the user to create new logins with. Take note that im learning SQL still and this is my first attempt to use it.
Database Info:
Table Name: LoginTable
Username Column Name: User
Password Column Name: Pass

I'm trying to insert new records for the database, Username and Password.
TextBox1 is the username, Textbox 2 Im using to compare the text from TextBox3 to, and TextBox 3 is what Im using for the password to insert into the table.

Im using:
Language: C# 4.0
Platform: Windows 7 - x64
Compiler: Visual Studio Ultimate
Microsoft Access 2007

Here's my code:

C#

if (textBox2.Text == textBox3.Text && String.IsNullOrWhiteSpace(textBox1.Text) == false)
            {
                string insertCMD = "INSERT INTO LoginTable (User,Pass) VALUES (?,?,?)";
                string ConnStr = @"Provider=Microsoft.ACE.OLEDB.12.0;Data Source=G:\\MedDesk\\Login.accdb;";
                using (OleDbConnection MyConn = new OleDbConnection(ConnStr))
                {
                    try
                    {//insertCommand.Parameters.Add("Time", OleDbType.Char).Value = strTime;
                        MyConn.Open();
                        OleDbCommand Cmd = new OleDbCommand(insertCMD, MyConn);
                        Cmd.Parameters.Add("User", OleDbType.Char).Value = textBox1.Text;
                        Cmd.Parameters.Add("Pass", OleDbType.Char).Value = textBox3.Text;
                        Cmd.ExecuteNonQuery();
                        MyConn.Close();
                    }
                    catch (Exception ex)
                    {
                        MessageBox.Show(ex.Message);
                    }
                }

            }

Any questions please reply, I need help on this ASAP!

Posted 14-Feb-12 9:52am

shelby67

Add a Solution

Comments

shelby67 14-Feb-12 16:05pm

I'm using WPF, not sure if it really helps to know that but...

3 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Kschuler · Answer 1 · 2012-02-14T10:10:00

Solution 1

What's the error you are getting?

I see a couple of things. First...you really should name things more meaningful. textbox1 and textbox 2 is confusing. Start a naming convention with the first three characters telling you what the DataType is, then add a meaningful name. txtUserName and txtPassword are SOOO much easier to understand.

Second item, what are you trying to do here?

C#

if (textBox2.Text == textBox3.Text && String.IsNullOrWhiteSpace(textBox1.Text) == false)

Third, you have two values in the table, but are setting three?

C#

string insertCMD = "INSERT INTO LoginTable (User,Pass) VALUES (?,?,?)";

Fourth, what is the @ for?

C#

string ConnStr = @"Provider=Microsoft.ACE.OLEDB.12.0;Data Source=G:\\MedDesk\\Login.accdb;";

And fifth, if you're just playing around it's probably not an issue, but you really shouldn't store passwords as plain text. Look into hashing them before you save them into the file, then you can compare the hash of something a user types to what you have saved in the file. It's much more secure.

Posted 14-Feb-12 10:10am

Kschuler

Comments

shelby67 14-Feb-12 16:14pm

1.) I'm checking to make sure the Password matches the other Password TextBox, (textbox2, textbox3). then the last part im checking to see if textbox1 is not empty, i dont want to insert nothing into the database..

shelby67 14-Feb-12 16:15pm

as for the @ symbol, i got that off the web.

lewax00 14-Feb-12 16:28pm

The @ symbol is so you don't need to escape things, so you should either remove it or replace "G:\\MedDesk\\Login.accdb" with "G:\MedDesk\Login.accdb"

Kschuler 14-Feb-12 16:44pm

Good to know!

shelby67 14-Feb-12 16:15pm

even if I delete the third value and fix it to what you mentioned, still fails. The error is "Invalid Syntax in INSERT INTO command".

Kschuler 14-Feb-12 16:25pm

I think you need instead of ?, something like @User and @Pass. Then change where you are actually setting those parms so they say @User and @Pass too.

shelby67 14-Feb-12 20:35pm

Everything that has been mentioned i have tried. Same error.

Kschuler 15-Feb-12 9:29am

Why don't you update the code in the question with the code you are using now that you've made changes and we will have a better idea of how to help you.

Bernhard Hiller · Answer 2 · 2012-02-14T22:40:00

Solution 2

C#

string insertCMD = "INSERT INTO LoginTable ([User],Pass) VALUES (?,?)"

You must escape "User" by placing it between [].
And you need two question marks only, because you insert two values, not three.

Posted 14-Feb-12 22:40pm

Bernhard Hiller

CRDave1988 · Answer 3 · 2012-02-14T22:47:00

Solution 3

I think problem is with parameter see here how to use ot.

http://www.java2s.com/Code/CSharp/Database-ADO.net/RunanINSERTstatementwithparameters.htm[^]

Posted 14-Feb-12 22:47pm

CRDave1988