store procedure for select problem

Question

0.00/5 (No votes)

See more:

Hello friends.

The below is my store procedure

SQL

create procedure sp_insertclass(@standeredid int,@standeredname varchar(10),@branchname varchar(50) ,@yearfrom smallint,@yearto smallint,@createddatetime datetime)
as
begin
declare @acadamicid int;
declare @branchid int;
select @branchid=Branch_id from Branch where Branch_name=@branchname;
select @acadamicid=Acadamic_year_id from Acadamic_year where Acadamic_year_from=@yearfrom and Acadamic_year_to=@yearto;
insert into Standered_details(Standered_id,Standered_name,Branch_id,Acadamic_year_id,Created_date_time)values(@standeredid,@standeredname,@branchid,@acadamicid,@createddatetime)
end

When executing the above query it succeed.but when insert date through this query the exception occur like Acadamic_year_id is null. but i entered the from year and toyear correctly. please tell me what could be problem in task
One thing i did is yearfrom and yearto variable declared with int datatypes in c# class.Is it make a problem in this place.
Thank in advance

Posted 27-Jul-12 4:08am

baskaran chellasamy

Updated 27-Jul-12 4:19am

v3

Add a Solution

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Santhosh Kumar Jayaraman · Answer 1 · 2012-07-27T04:12:00

Solution 1

Check whether any academic year is present in the table for the given from date and todate. I think there are no records in the table.

select @acadamicid=Acadamic_year_id from Acadamic_year where Acadamic_year_from=@yearfrom and Acadamic_year_to=@yearto;

If its present, then include begin tran in the starting of stored proc and commit tran after insert

Posted 27-Jul-12 4:12am

Santhosh Kumar Jayaraman

Updated 27-Jul-12 4:25am

v2

Comments

baskaran chellasamy 27-Jul-12 10:22am

yes data present in the table

Santhosh Kumar Jayaraman 27-Jul-12 10:23am

Can you let us know whats year from, year to value and corresponding academic year id value from db?

Santhosh Kumar Jayaraman 27-Jul-12 10:24am

ALso include begin tran in the starting of stored proc and commit tran after insert

baskaran chellasamy 27-Jul-12 10:31am

year from is 2012 and yearto is 2013 and acadamic yearid=112 and one thing i left to mentions is in db yearfrom and yearto is smallint. but in c# class i declared as a int value.if this would be problem mean which datatype need to specify in c#.

Santhosh Kumar Jayaraman 27-Jul-12 10:33am

just try it with begin tran and commit tran

baskaran chellasamy 27-Jul-12 10:52am

yes i inserted tran and commit. how can track the value from c# class about this store procedure operation

Santhosh Kumar Jayaraman 27-Jul-12 10:56am

Is that working now as stored procedure?

baskaran chellasamy 27-Jul-12 11:20am

no.which value neeed to pass to datetime variable at executing the storeprocedure

Santhosh Kumar Jayaraman 27-Jul-12 11:21am

set @createddatetime=getdate()

baskaran chellasamy 27-Jul-12 11:30am

its working in when excuting the storeprocdure.i got correct value in the table .when executing through visualstudio(front end)it is not working.the code for c# is
SqlCommand cmd = new SqlCommand("sp_insertclass1", Dob.con);
Dob.con.Open();
/// cmd.Connection=Dob.con;
cmd.CommandType = CommandType.StoredProcedure;
// cmd.CommandText="dbo.sp_addschool";
cmd.Parameters.Add(new SqlParameter("@standeredid",sc11.STANDEREDID));
cmd.Parameters.Add(new SqlParameter("@standeredname",sc11.STANDEREDNAME));
cmd.Parameters.Add(new SqlParameter("@branchname", sc11.BRANCHNAME));
cmd.Parameters.Add(new SqlParameter("@yearfrom", sc11.YEARFROM));
cmd.Parameters.Add(new SqlParameter("@yearto",sc11.TOYEAR));
cmd.Parameters.Add(new SqlParameter("@createddatetime", sc11.CREATEDDATETIME));
int affectedrows = cmd.ExecuteNonQuery();
return affectedrows;
}
catch (Exception ex)
{
throw ex;
}
finally
{
if (Dob.con != null)
{
Dob.close();
}
}

Santhosh Kumar Jayaraman 27-Jul-12 11:31am

wat was the error?

baskaran chellasamy 27-Jul-12 11:36am

it doesnt show any error.but when trace the value cmd.ExecuteNonQuery() return
-1.

Santhosh Kumar Jayaraman 27-Jul-12 11:39am

Please check your parameter values in debug mode

baskaran chellasamy 27-Jul-12 11:44am

i check parameter value at debug mode.all values are set to parameter.but in excutenonquery it produce -1;

Santhosh Kumar Jayaraman 27-Jul-12 11:48am

Do you have commit in ur stored proc. It looks like rollback is happening

Santhosh Kumar Jayaraman 27-Jul-12 11:50am

also check this.
http://social.msdn.microsoft.com/Forums/en/adodotnetdataproviders/thread/ad9b1da8-191c-4ac3-96f8-d88c73061059

Sudheer Reddy Battula · Answer 2 · 2012-07-27T04:37:00

Not much different to what Solution 1 has to say, but add validation to check for a null value in the @acadamicid parameter, try this:

SQL

if(@acadamicid is not null)
begin

select @acadamicid=Acadamic_year_id from Acadamic_year where Acadamic_year_from=@yearfrom and Acadamic_year_to=@yearto;
insert into Standered_details(Standered_id,Standered_name,Branch_id,Acadamic_year_id,Created_date_time)
values(@standeredid,@standeredname,@branchid,@acadamicid,@createddatetime)
    
end