the Update Not Commited in my Application

Question

0.00/5 (No votes)

See more:

my aplication has updatepage.aspx which updates database tables .. the problem is when i click the button it takes the old values .. and no error ,, here is my code .. hope to find solution from masters =]

C#

protected void Button1_Click(object sender, EventArgs e)
   {
       prepareConnection();
       //Update News
       if (_CatID == "1")
       {

           if (FileUpload1.HasFile)
           {
               prepareConnection();
               string FileName = Path.GetFileName(FileUpload1.PostedFile.FileName);
               //save file to disk

               FileUpload1.SaveAs(Server.MapPath("~/ArticleImages/News/" + FileName));
               _command.CommandText = "UPDATE News SET Title=" + "N'" + titleTextBox.Text + "'" + "," + "Contect=" + "N'" + CKEditor1.Text + "'" + ",img=@FilePath WHERE ID='" + Convert.ToInt16(lblID.Text) + "';";
               _command.Parameters.AddWithValue("FilePath", "~/ArticleImages/News/" + FileName);
               try
               {
                   _command.ExecuteNonQuery();
               }
               catch (Exception ex)
               {
                   Response.Write(ex.Message);
               }

           }
           else
           {
               prepareConnection();
               _command.CommandText = "UPDATE News SET Title=" + "N'" + titleTextBox.Text + "'" + "," + "Contect=" + "N'" + CKEditor1.Text + "'" + " WHERE ID='" + Convert.ToInt16(lblID.Text) + "';";
               try
               {
                   _command.ExecuteNonQuery();
               }
               catch (Exception ex)
               {
                   Response.Write(ex.Message);
               }
           }

Posted 14-Oct-13 1:00am

Ameer A. Lawi

Add a Solution

Comments

Thanks7872 14-Oct-13 7:09am

Use debugger and try to find out whats going on inside this code block.

Ameer A. Lawi 14-Oct-13 8:30am

i did .. the old value passed there :(

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Accepted Answer · 2013-10-14T01:24:00

Two things:
1) Do not concatenate strings to build a SQL command. It leaves you wide open to accidental or deliberate SQL Injection attack which can destroy your entire database. Use Parametrized queries instead. Particularly in a web based application, where someone from the other side of the world could destroy your database without even trying hard...
2) Check your Page Load event: I am pretty sure you don't check for IsPostback[^] ebfore setting up your page - which means when the user clicks the button, you overwrite his new values before the Button_Click event is actioned...