Click here to Skip to main content
15,893,998 members
Please Sign up or sign in to vote.
1.00/5 (1 vote)
See more:
CREATE PROCEDURE AddNewUserProc
{
@NricNo VarChar(50)
@donorNric VarChar(50)
@donorName VarChar(50)
@donorAddress VarChar(250)
@donorPostalCode VarChar(50)
@donorContactNo VarChar(50)
@donorType int
@donorOrganizationName VarChar(250)
}

AS

IF NOT EXISTS (SELECT NricNo FROM Donor WHERE NricNo = @NricNo)
BEGIN
INSERT INTO Donor(NricNo, Name, Address, PostalCode, ContactNo, Type,OrganizationName) VALUES(@NricNo, @donorNric , @donorName , @donorAddress, @donorPostalCode, @donorContactNo, @donorType, @donorOrganizationName)
END

//Error keep saying must declare @NricNo twice, incorrect syntax near '{'.
Posted

Try this:
SQL
CREATE PROCEDURE AddNewUserProc
   @NricNo VarChar(50),
   @donorNric VarChar(50),
   @donorName VarChar(50),
   @donorAddress VarChar(250),
   @donorPostalCode VarChar(50),
   @donorContactNo VarChar(50),
   @donorType int,
   @donorOrganizationName VarChar(250)
AS
 
IF NOT EXISTS (SELECT NricNo FROM Donor WHERE NricNo = @NricNo)
BEGIN
INSERT INTO Donor(NricNo, Name, Address, PostalCode, ContactNo, Type,OrganizationName) VALUES(@NricNo, @donorNric , @donorName , @donorAddress, @donorPostalCode, @donorContactNo, @donorType, @donorOrganizationName)
END

Don't use { } brackets to create your procedure, but use commas to seperate the arguments.
 
Share this answer
 
v2
Comments
Pete O'Hanlon 29-Jan-14 12:34pm    
Snap! My 5.
Thomas Daniels 29-Jan-14 12:35pm    
Thank you!
Karthik_Mahalingam 29-Jan-14 13:12pm    
5
Thomas Daniels 29-Jan-14 13:22pm    
Thank you!
Try this instead:
SQL
CREATE PROCEDURE AddNewUserProc

  @NricNo VarChar(50),
  @donorNric VarChar(50),
  @donorName VarChar(50),
  @donorAddress VarChar(250),
  @donorPostalCode VarChar(50),
  @donorContactNo VarChar(50),
  @donorType int,
  @donorOrganizationName VarChar(250)

AS
 
IF NOT EXISTS (SELECT NricNo FROM Donor WHERE NricNo = @NricNo)
BEGIN
INSERT INTO Donor(NricNo, Name, Address, PostalCode, ContactNo, Type,OrganizationName) VALUES(@NricNo, @donorNric , @donorName , @donorAddress, @donorPostalCode, @donorContactNo, @donorType, @donorOrganizationName)
END
 
Share this answer
 
v2
Comments
Thomas Daniels 29-Jan-14 12:36pm    
+5, but you only need to remove the last comma.
Pete O'Hanlon 29-Jan-14 12:38pm    
Thanks, I was a bit zealous in my comma(ing). :D
Karthik_Mahalingam 29-Jan-14 13:12pm    
5
Pete O'Hanlon 29-Jan-14 13:32pm    
Thanks.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)



CodeProject, 20 Bay Street, 11th Floor Toronto, Ontario, Canada M5J 2N8 +1 (416) 849-8900