Java

Re: Using JNI without having to add jvm.dll path inside Environment Variables (User or System)

25-Jan-23 21:38

In order to use JNI, you have to add inside Environment Variables (User or System) the path to were jvm.dll is located. You have a few ways to do that, but it is possible. But, is there a way to not have to add the path inside Environment Variables and instead when you call the function to create a VM from C++ to tell it where it is located via JavaVMInitArgs, or maybe JavaVMOption, or in any other way, but like I said without having to add the path in Environment Variables?

Richard MacCutchan25-Jan-23 23:31

Re: Using JNI without having to add jvm.dll path inside Environment Variables (User or System)

25-Jan-23 23:31

Yes, this is the way I do it, but you can modify it any way you like to provide the path to the library:

C++

/*
 ******************************************************************************
 *
 *    Name     : cpptojava.cpp
 *
 *    Function : Basic Console application to call a Java class.
 *
 *    Created  : 09 Jun 2022
 *
 ******************************************************************************
 */

#include <Windows.h>
#include <iostream>
#include <string>
#include <sstream>
#include <vector>
#include <filesystem> // requires -std:c++17

#include "jni.h"

//
// Find the path to the jvm.dll given the base path to the Java runtime (or JDK if installed)
//
HMODULE LoadDll(
    const char* jrePath
)
{
    const char* pszjvmname = "bin\\server\\jvm.dll";   // Java VM name
    HMODULE hJVMDLL = 0;

    std::filesystem::path jvmpath(jrePath);
    jvmpath /= pszjvmname;
    if (!std::filesystem::exists(jvmpath))
    {
        std::cerr << "JVM library " << jvmpath << " not found." << std::endl;
        // throw an exception 
    }

    // load the Java VM DLL into our address space
    // NB filesystem::path is Unicode
    hJVMDLL = LoadLibraryW(reinterpret_cast<PCWSTR>(jvmpath.c_str()));
    if (hJVMDLL != NULL)
    {
        std::clog << "jvm.dll loaded from: " << jvmpath << std::endl;
    }
    return hJVMDLL; // a Windows HANDLE to the DLL
}


//
// A function to load the Java VM and initialise the JNI interface
// There are a number of diagnostic messages to show progress
//
JNIEnv* AttachJVM(
    const char* jrePath,
    JavaVM* jvm,
    std::string strcwd
)
{
    HMODULE     hJVMDLL = LoadDll(jrePath);
    if (hJVMDLL == 0)
    {
        return nullptr;
    }
    typedef jint(JNICALL* fpCJV)(JavaVM**, void**, void*);
    fpCJV JNI_CreateJavaVM = (fpCJV)::GetProcAddress(hJVMDLL, "JNI_CreateJavaVM");

    // tell the JVM where to find the class
    JavaVMOption    options[2];
    std::stringstream ssoptions;
    ssoptions << "-Djava.class.path=";
    ssoptions << strcwd;
    std::string stropts = ssoptions.str();
    options[0].optionString = const_cast<char*>(stropts.c_str());
    options[1].optionString = const_cast<char*>("-verbose:jni");   // print JNI-related messages

    JavaVMInitArgs  vm_args; // JDK/JRE 6 VM initialization arguments
    vm_args.version = JNI_VERSION_1_8;
    vm_args.nOptions = 1; // change to 2 for verbose output
    vm_args.ignoreUnrecognized = false;
    vm_args.options = options;
    for (int i = 0; i < vm_args.nOptions; ++i)
    {
        std::clog << "Options[" << i << "]: " << options[i].optionString << std::endl;
    }
    JNIEnv* env;            // pointer to native method interface
    jint res = JNI_CreateJavaVM(&jvm, (void**)&env, &vm_args);
    if (res != 0)
    {
        std::cerr << "C++: JNI_CreateJavaVM returned: " << res << std::endl;
    }
    jint version = env->GetVersion();
    std::clog << "JVM Version: " << (version >> 16) << "." << (version & 0xffff) << std::endl;

    return env; // the pointer to the jvm dll
}


void CallClass(
    JNIEnv* jniEnv,
    const char* pszClassname,
    const char* pszMethodname,
    const char* pszSignature
)
{
    jclass jvmclass = jniEnv->FindClass(pszClassname);
    if (jvmclass != NULL)
    {
        std::cout << "C++: Found the class: " << pszClassname << std::endl;
        jmethodID jmid = jniEnv->GetStaticMethodID(jvmclass, pszMethodname, pszSignature);
        if (jmid != NULL)
        {
            std::cout << "C++: Found the method: " << pszMethodname << std::endl;
            jniEnv->CallStaticVoidMethod(jvmclass, jmid, NULL);
            std::cout << "C++: env->CallStaticVoidMethod complete" << std::endl;
        }
        else
        {
            std::cerr << "C++: Failed to find the method: " << pszMethodname << std::endl;
        }
    }
    else
    {
        std::cerr << "C++: Failed to find the class: " << pszClassname << std::endl;
    }
}


int main(
    int argc,
    const char** argv
)
{
    const char* jreDir = nullptr;

    // suppress debug messages
    std::clog.setstate(std::ios::badbit);
    for (argv++; argc > 1; ++argv, --argc)
    {
        if (*argv[0] == '-')
        {
            // handle any execution options ...
            if (strstr(*argv, "-d"))
                std::clog.clear();
        }
        else
        {
            jreDir = *argv;
        }
    }
    if (jreDir == nullptr)
    {
        std::cerr << "No root path provided for JVM." << std::endl;
        return 1;
    }
    JNIEnv* jniEnv = NULL;
    std::filesystem::path cwd = std::filesystem::current_path();
    JavaVM jvm;
    jniEnv = AttachJVM(jreDir, &jvm, cwd.string());
    if (jniEnv == NULL)
    {
        std::cerr << "C++: Failed to get Java environment" << std::endl;
        return 1;
    }
        CallClass(jniEnv, "CppToJava", "main", "([Ljava/lang/String;)V");

    // clean up
    jint jvmres = jvm.DestroyJavaVM(); // never returns ???
    std::clog << "C++: DestroyJavaVM and terminate: " << jvmres << std::endl;

}

JohnCodding25-Jan-23 23:47

Re: Using JNI without having to add jvm.dll path inside Environment Variables (User or System)

25-Jan-23 23:47

Can you include a project with this? I tried it inside a project with c++17 but I'm getting 29 errors.

It marks these lines as problems:

std::filesystem::path jvmpath(jrePath);       // name followed by '::' must be a class or namespace name   and expected a;
    jvmpath /= pszjvmname;                    // identifier jvmpath undifined
    if (!std::filesystem::exists(jvmpath)) {  // name followed by '::' must be a class or namespace name

std::filesystem::path cwd = std::filesystem::current_path();   // name followed by '::' must be a class or namespace name   and expected a;

jniEnv = AttachJVM(jreDir, &jvm, cwd.string()); // identifier cwd undifined

Right now I'm using this to create a VM:

FString UCreateVM::createVM(FString location) {
	std::string javaLocation = TCHAR_TO_ANSI(*location);
	javaLocation.insert(0, "-Djava.class.path=");
	javaLocation.append("Data/Java");
	JavaVMInitArgs vm_args;
	JavaVMOption* options = new JavaVMOption[1];
	options[0].optionString = &javaLocation[0];
	vm_args.version = JNI_VERSION_10;
	vm_args.nOptions = 1;
	vm_args.options = options;
	vm_args.ignoreUnrecognized = false;
	JNIEnv* env = nullptr;
	jint rc = JNI_OK;
	if (jvm == nullptr) {
		rc = JNI_CreateJavaVM(&jvm, (void**)&env, &vm_args);
	}
	else {
		rc = jvm->AttachCurrentThread((void**)&env, NULL);
	}
	delete[] options;
	if (rc != JNI_OK) {
		if (rc == JNI_EVERSION)
			return "JNI_EVERSION";
		else if (rc == JNI_ENOMEM)
			return "JNI_ENOMEM";
		else if (rc == JNI_EINVAL)
			return "JNI_EINVAL";
		else if (rc == JNI_EEXIST)
			return "JNI_EEXIST";
		else
			return "JNI_FATALERROR";
	}
	return "JNI_CREATED";
}

Also, I should mention that I'm using Eclipse Adoptium Java JRE, and it will be distributed with the app (with all the legal stuff), and in the above function I can add another parameter and tell it where the path for the dll is located inside the app/Eclipse Adoptium Java JRE folder.

modified 26-Jan-23 5:03am.

Richard MacCutchan26-Jan-23 1:02

Re: Using JNI without having to add jvm.dll path inside Environment Variables (User or System)

26-Jan-23 1:02

I think your option (c++17) may be incorrect, it should be as below. I don't use a project but a simple Makefile. The compile statement that it generates is:

cl -nologo -EHsc -RTC1 -W3  -std:c++17 -I "C:\Program Files\Java\jdk-18.0.2\include" -I "C:\Program Files\Java\jdk-18.0.2\include\win32" cpptojava.cpp

The include paths may well be different on your system.

Your code appears to be OK; what happens when you run it?

JohnCodding26-Jan-23 1:16

Re: Using JNI without having to add jvm.dll path inside Environment Variables (User or System)

26-Jan-23 1:16

My code is running fine, but I just wanted to skip the step where you have to add the path of the jvm.dll inside Environment variable. Because with this, I need a separate exe file that will first check if the path is added or not (and to add it if it isn't), and after that to launch the exe for the program that is using JNI.

So for this right now I have a Java program that is doing the check and acting as a launcher (which is made using jpackage command, so it doesn't need Java to be installed), and when the check is done it is launching a different exe from its folder.

JohnCodding26-Jan-23 0:27

Re: Using JNI without having to add jvm.dll path inside Environment Variables (User or System)

26-Jan-23 0:27

Looking at the code, is the following line really what it only needs and the rest are checks if it exists, if it was loader or not?

hJVMDLL = LoadLibraryW(reinterpret_cast<PCWSTR>(jvmpath.c_str()));

Richard MacCutchan26-Jan-23 1:05

Re: Using JNI without having to add jvm.dll path inside Environment Variables (User or System)

26-Jan-23 1:05

That just loads the library into the process's address space. You still need the dynamic calls to find the method addresses before you can call them, as the library is not linked to the application at build time.

JohnCodding26-Jan-23 1:20

Re: Using JNI without having to add jvm.dll path inside Environment Variables (User or System)

26-Jan-23 1:20

Would AddDllDirectory with the path of the jvm.dll help with setting another path for the app to look into before it goes to Environment variables? Or that is used for something else and it won't work with JNI? Like I said, I can give the location to the jvm.dll in a parameter, because the location is different for each user, depending where the app is is installed.

Richard MacCutchan26-Jan-23 1:28

Re: Using JNI without having to add jvm.dll path inside Environment Variables (User or System)

26-Jan-23 1:28

JohnCodding wrote:
Would AddDllDirectory with the path of the jvm.dll help

I have never used it but the documentation suggests that it would. There's only one way to find out if it works.

JohnCodding26-Jan-23 1:45

Re: Using JNI without having to add jvm.dll path inside Environment Variables (User or System)

26-Jan-23 1:45

I tried this, but it doesn't work.

std::string dllLocation = "C:\\Program Files\\Eclipse Adoptium\\jdk-18.0.1.10-hotspot\\bin\\server";
std::wstring temp = std::wstring(dllLocation.begin(), dllLocation.end());

AddDllDirectory(temp.c_str());

I also tried to switch it to SetDllDirectory but that also didn't work.

JohnCodding26-Jan-23 1:52

Re: Using JNI without having to add jvm.dll path inside Environment Variables (User or System)

26-Jan-23 1:52

I might leave it as it is, with the launcher which adds the jvm.dll path to User path if it doesn't exists, and then to launch the actual app. C++ code wording is different then Java, more "raw", and I'm really not use to it, I'm getting lost looking at it and more confused the more I look at examples.

If it aint broke dont fix it. Laugh | :laugh:

modified 26-Jan-23 7:11am.

Richard MacCutchan26-Jan-23 2:44

Re: Using JNI without having to add jvm.dll path inside Environment Variables (User or System)

26-Jan-23 2:44

I just tried AddDllDirectory also, but it does not seem to do what I expected. I have also been going round in circles trying various changes but basically getting nowhere. I think you are right to stick with a solution that works for you.

jschell26-Jan-23 12:33

jschell

26-Jan-23 12:33

Having used JNI multiple times before I would note that I would never use it again.

If the JNI code crashes then it takes the VM down. And there is little or nothing you can do to stop that.

For convenience I am going to refer to the needed non-java code as C/C++ below but it applies to any language that can be used to create an exe.

And there is a very viable option
1. Create a C/C++ wrapper which allows the target code to be run as and exe.
2. The exe has a control API. There are three ways to control it: Stdio, files or TCP/IP. Or perhaps pipes.
3. Use Java process API to run and manage the exe. That allows one to start, stop and kill it.
4. The Java code uses the control API to control it. This can include everything: configuration, passing binary data, statistics, health checks even a request for the exe to exit.

Advantages over JNI
1. It cannot crash the VM
2. The external code runs in its own process space.
3. The C/C++ code can be unit tested independently from Java code.
4. The C/C++ code is its own deliverable. Move the exe into the Java deployment space. It can even be packaged into a jar (any file can be) but of course it would need to be extracted into the file system.
5. The java code can be tested independently from the java code if the control interface is built carefully.

Memory usage for requested rows from database

Valentinor13-Jan-23 1:18

Valentinor

13-Jan-23 1:18

When you are running in Java:

ResultSet rs = stmt.executeQuery("SELECT Column FROM Table WHERE Condition");

Does the database create in memory a list with all the rows/values that have the given condition, and it is keeping that list until the rs is close? Or it will only keep the first value, and move to the next value when rs.next() is called?

I'm asking this because you can give it the command to FETCH NEXT X ROWS ONLY, and in case you have a database with millions of entries, that would save time and resources when you only want X rows, and not all of them that match the given condition.

Or the FETCH is only a hard limit to know when to stop with sending the rows/values one by one?

jschell15-Jan-23 9:27

jschell

15-Jan-23 9:27

Valentinor wrote:
SELECT Column FROM Table WHERE Condition

First keep in mind that is SQL. It is sent as is to the database.

Valentinor wrote:
Does the database create in memory a list with all the rows/values that have the given condition

That is not how the jdbc is defined to work. But a bad driver could definitely do that. There is (or was) a jdbc/odbc 'text' driver and presumably it could have loaded everything into memory. But that was basically a toy anyways.

The next() technically loads it. But drivers I have actually looked at usually use some sort of batch request that might load 10, 100, etc, and then wait for the next to pull from the local set. I think I even recall somewhere that can be adjusted. The initial set as somewhat low value.

Valentinor wrote:
FETCH NEXT X ROWS ONLY

How you do that depends on the database (see above). But every query you write should always be constrained (the where clause) and most should have a limit on the number of rows. The result should be paged.

Only time that would not be true when you know for a fact that the target table has an extraordinarily low growth factor. Only ones I know for sure like that are application enumeration tables.

Table examples where you should ALWAYS include the paging mechanism are things like customers, users, orders, events, etc.

Valentinor wrote:
database with millions of entries, that would save time and resources when you only want X rows,

That is a complex statement and there is no simple answer.

You should NEVER, for example, allow for a design where a UI could expect a user to view 'millions' of rows. As a developer if you see a requirement like that you should insist that the requirements be changed to include reasonable constraint restrictions. Some examples
1. Require a date range, account number, customer store, etc.
2. Do a count(*) with the constraints in place and throw an error if the result is larger than X (say 10,000) which would then require the user (in the UI) to add more constraints to narrow the result.

And such queries should ALWAYS require a page and row size. So for example 'page 5', 'size 20'. The backend then restricts (hard code) the max size to something like 1000.

Additionally the users (whoever they are) might claim that they 'need' all of those rows. A person can never process millions of rows so such a claim for a user is ridiculous. The user in such a case always knows that they are looking for something very specific like a email, customer name, account number, etc.

However the other possible need is some automated process is going to consume that result. And in that case you should design a batching system that can dump large files wo some location (FTP server) to be processed by that external service. There are a vast number of problems that should be addressed in such a request, of which just one, is that you do not want to be dumping the entire contents of that table every day or every hour. Not to mention that there might even be some consideration about who actually owns that data and who pays for the processing to deliver it.

Valentinor16-Jan-23 21:44

Valentinor

16-Jan-23 21:44

jschell wrote:
That is not how the jdbc is defined to work.

OK, good. I'm the only developer for now, so I'm working on everything, and DB/SQL isn't something I'm good at, but I don't want to make a bad DB when it comes to performance.

jschell wrote:
But a bad driver could definitely do that.

I'm using Oracle JDBC driver 11, so I would say that is out of the question.

jschell wrote:
The result should be paged.

Is this a good example of paging?[^] Unfortunately, that isn't something I know of.

jschell wrote:
You should NEVER, for example, allow for a design where a UI could expect a user to view 'millions' of rows.

Oh, no way that. By that I meant something else, but you answered it here:

jschell wrote:
That is not how the jdbc is defined to work. But a bad driver could definitely do that.

Thank you for all the info!

jschell17-Jan-23 4:24

jschell

17-Jan-23 4:24

Valentinor wrote:
Is this a good example of paging?[^]

Using the following in google to look for examples.

PLSQL paging query

How to found a file by utilizing a variable for 'Startswith' in JAVA?

RedDk17-Jan-23 8:15

RedDk

17-Jan-23 8:15

There's a phrase in TSQL parlance:
"Row by Agonizing Row"
(In order to give proper credit to the conspiracy that does the stabbing here I'd have to misquote someone so I'll just type in stuff which an eleventh grade high school teacher could type if she were quoting herself).

Look up INDEX and think "I'll use INDEX, in 'automatic assign of an index' and just DROP the original index and reassign it after I do all the tabulation"

MOHAMMAD ZAINUL ABIDEEN3-Jan-23 1:32

MOHAMMAD ZAINUL ABIDEEN

3-Jan-23 1:32

I'm trying to find a file based on the starting eight digits extracted from an excel sheet for every iteration. I am receiving the error notice "Local variable CaseID declared in an enclosing scope must be final or effectively final" so i am using the code below and still appears to be fresh, so I don't know how to correct this, Even after it happen to be a straightforward repair.

Java

package Chrome;
//CHROME
import java.io.File;
import java.io.FileFilter;
import java.io.FileInputStream;
import java.io.FileOutputStream;
import java.io.FilenameFilter;

import org.apache.poi.ss.usermodel.Cell;
import org.apache.poi.ss.usermodel.DataFormatter;
import org.apache.poi.xssf.usermodel.XSSFCell;
import org.apache.poi.xssf.usermodel.XSSFSheet;
import org.apache.poi.xssf.usermodel.XSSFWorkbook;
import org.openqa.selenium.By;
import org.openqa.selenium.WebDriver;
import org.openqa.selenium.chrome.ChromeDriver;
import org.openqa.selenium.chrome.ChromeOptions;


public class ValidateInput {

public static void main(String[] args) throws Throwable {
// TODO Auto-generated method stub

// String filePath=System.getProperty("user.dir")+"\\UP.xlsx";
//File src = new File(filePath);    
//System.out.println(filePath);
File src = new File("C:\\Users\\Z246379\\Documents\\TestDataFolder\\ValidateInput.xlsx");          
FileInputStream fis = new FileInputStream(src);        



XSSFWorkbook wb = new XSSFWorkbook(fis);        
XSSFSheet Sheet1 = wb.getSheetAt(0);
int i1 = 2;
//Username
String data0 = Sheet1.getRow(2).getCell(0).getStringCellValue();
//Password    
String data01 = Sheet1.getRow(2).getCell(1).getStringCellValue();
//Case ID
String caseID = Sheet1.getRow(i1).getCell(2).getStringCellValue();
// Description
String Desc = Sheet1.getRow(2).getCell(3).getStringCellValue();
//Internal Claim File
String ICF = Sheet1.getRow(1).getCell(4).getStringCellValue();
String CRPT = Sheet1.getRow(1).getCell(5).getStringCellValue();

// final String caseID1 = caseID1;




//Chrome driver code

 System.out.println("Called openBrowser");
 String exePath = System.getProperty("user.dir")+"\\chromedriver.exe";
 System.setProperty("webdriver.chrome.driver", exePath);
 ChromeOptions options = new ChromeOptions();
 options.setExperimentalOption("useAutomationExtension", false);
 options.addArguments("start-maximized");
 options.addArguments("--no-sandbox");
 options.addArguments("--disable-extensions-except");
 options.addArguments("disable-extensions");
 //options.setExperimentalOption("useAutomationExtension", false); 
 WebDriver driver = new ChromeDriver(options);
 driver.get("https://client.abc.com");


 //Logging in       
 driver.findElement(By.xpath("//input[@id='userid']")).sendKeys(data0);
 driver.findElement(By.xpath("//body[@class='no-nav']/div[@id='wrapper']/header[@class='header']/div[@class='container']/div[@class='menu']/div[@class='drop']/div[@class='login-form']/form[@method='POST']/div[2]/input[1]")).sendKeys(data01);
 driver.findElement(By.xpath("//input[@value='Sign In']")).click();
 Thread.sleep(2000);
 //Navigate to Validate Input
 driver.findElement(By.xpath("//span[@class='wpsNavLevel2'][contains(text(),'EZ-Test')]")).click();
 Thread.sleep(3000);
 driver.get("https://ezt.abc.com/Test/inputFiles/selectValidateInput/selectValidateInput.xhtml");

 while (caseID != null)
      {

  caseID = Sheet1.getRow(i1).getCell(2).getStringCellValue();
  //Input Validate Input stuff

  driver.findElement(By.xpath("//input[@id='mainForm:caseId']")).sendKeys(caseID);
driver.findElement(By.xpath("//input[@id='mainForm:testBedDesc']")).sendKeys(Desc);
  driver.findElement(By.xpath("//select[@id='mainForm:customRptOptions']")).sendKeys(ICF);
 driver.findElement(By.xpath("//span[@id='mainForm:customReportLabel']")).click();




  File dir = new File("C:\\Users\\Z333379\\Documents\\Test beds");
  FilenameFilter filter = new FilenameFilter() {
  public boolean accept (File dir, String name) { 
   return name.startsWith(caseID); //this is where i get the error. its not letting me make case ID a variable. but i really need the starts with stuff
   } 
 }; 
 String[] children = dir.list(filter);
 if (children == null) {
    System.out.println("Either dir does not exist or is not a directory"); 
 } else { 
   for (int i=0; i< children.length; i++) {
   String filename = children[i];
   System.out.println(filename);
        driver.findElement(By.xpath("//input[@id='mainForm:comprehensive']")).sendKeys("C:\\Users\\Z246379\\Documents\\Test beds\\" + filename);
    } 
 } 

 driver.findElement(By.xpath("//button[@id='mainForm:reset']")).click();


 i1=i1+1;
      }

  }
}

This is from the source I read, I don't know how to define an inner local class with a mutable variable. Is that correct? This problem appears to be at the bottom of the code, at the caseID variable.

modified 3-Jan-23 7:15am.

Re: How to found a file by utilizing a variable for 'Startswith' in JAVA?

Richard MacCutchan3-Jan-23 2:22

how to discover a file by utilizing a variable for 'Startswith' in java?

3-Jan-23 2:22

Try this:

Java

final String caseId1 = caseID; // add this final variable
FilenameFilter filter = new FilenameFilter() {
  public boolean accept (File dir, String name) { 
   return name.startsWith(caseId1); // use the final variable here
   } 
 };

MOHAMMAD ZAINUL ABIDEEN3-Jan-23 1:22

MOHAMMAD ZAINUL ABIDEEN

3-Jan-23 1:22

i want to locate a file based on the first eight digits extracted from an excel sheet for every iteration. I am receiving the error notice "Local variable CaseID declared in an enclosing scope must be final or effectively final" so i am using a code below and it still showing it as fresh, and i dont know how to correct it, even after it appears to be a straightforward repair.

Re: how to discover a file by utilizing a variable for 'Startswith' in java?

Richard MacCutchan3-Jan-23 1:25