C / C++ / MFC

24-Mar-14 16:14

Reposting as thread has grown

#include <<windows.h>> // remove extra angle bracket for compilation
#include <<tchar.h>>
#include <<stdio.h>>
#include <<strsafe.h>>

void FreeMemory(char** myArray, int row);
void FileCountInDir(const TCHAR* dirpath, int * filescount, int* filesize);
void FindFilesInDirectory(const TCHAR* dirpath, char** filelist);

int _tmain(int argc, TCHAR *argv[])
{
int i =0;
TCHAR szDirpath[MAX_PATH];
//TCHAR Filelist[100][MAX_PATH];
char ** Filelist;
int iFileCountInFolder=0;
int iFileSize = 0;

_tcscpy(szDirpath,_T("C:\\BMPread_W\\TransitionEffects\\Images"));

FileCountInDir(szDirpath,&iFileCountInFolder,&iFileSize);
Filelist = (char**)malloc(iFileCountInFolder * sizeof(char *));
if(Filelist == NULL)
{
fprintf(stderr, "out of memory\n");
return 0;
}
for(i = 0; i < iFileCountInFolder; i++)
{
Filelist[i] = (char*)malloc((iFileSize * sizeof(char))+1);
if(Filelist[i] == NULL)
{
fprintf(stderr, "out of memory\n");
return 0;
}
}
FindFilesInDirectory(szDirpath, Filelist);

for(i =0;i 0)|| ((*filesize) < _tcslen(ffd.cFileName)))
{
(*filesize) = _tcslen(ffd.cFileName);
}
}
}
while (FindNextFile(hFind, &ffd) != 0);
FindClose(hFind);
}

void FreeMemory(char** myArray, int row)
{
int i;
if(myArray != NULL)
{
for (i = 0; i < row; i++){

free (myArray[i]);

}
}

Richard MacCutchan24-Mar-14 22:52

Richard MacCutchan

24-Mar-14 22:52

Please edit your question and put <pre> tags around it all, not just the last line; i.e the opening tag should be before the first line, and the closing tag after the last.
How does this even compile, since szDirpath is not declared in your code?

C++

_tcscpy(szDirpath,_T("C:\\BMPread_W\\TransitionEffects\\Images"));

FileCountInDir(szDirpath,&iFileCountInFolder,&iFileSize);

You could also simplify it to:

C++

FileCountInDir(_T("C:\\BMPread_W\\TransitionEffects\\Images"), &iFileCountInFolder, &iFileSize);

As to the rest, it seems to be missing major portions of code so it's difficult to tell what is happening.

Richard Andrew x6425-Mar-14 5:59

Richard Andrew x64

25-Mar-14 5:59

Have you stepped through the code and inspected the values of myArray and i? That might tell you why it's failing.

The difficult we do right away...
...the impossible takes slightly longer.

leon de boer25-Mar-14 17:36

leon de boer

25-Mar-14 17:36

Okay that rubbish won't even compile

No compiler is going to let this line thru

for(i =0;i 0)|| ((*filesize) < _tcslen(ffd.cFileName)))

I am also suggesting that this line was also supposed to be that function defined but it has ";" rather than open brackets

FindFilesInDirectory(szDirpath, Filelist);

The other function is not provided anywhere

void FileCountInDir(const TCHAR* dirpath, int * filescount, int* filesize);

Can I suggest you give us some code that actually compiles if you want help

There is also some house cleaning you didn't release the pointer array in FreeMemory. To make you life easier can I suggest you make a CreateMemory function to add to your FreeMemory function here is what they look like

char** CreateMemory(int rows, int stringsize) {
    int i;
    char** p;

    p = (char**) malloc (rows * sizeof (char*));
    if(p != NULL){
        for (i = 0; i < rows; i++){
            p[i] = (char*) malloc(stringsize * sizeof(char));
        }
    };
    return (p);
};

void FreeMemory(char** myArray, int row) {
    int i;
    if(myArray != NULL){
        for (i = 0; i < row; i++){
            free (myArray[i]);
        }
    };
    free(myArray);   // you forgot this
};

This is how you use them

char** q;

q = CreateMemory(10, 256);  // create 10 rows each 256 chars
strcpy(q[0], "row 1\0");  // fill row 1
strcpy(q[9], "row 10\0");  // fill row 10
FreeMemory(q, 10); // release all the memory

User 5924125-Mar-14 20:13

DirectShow GraphEdit missing property page options tab. PARTIALLY SOLVED - CLOSED

25-Mar-14 20:13

There was no need to repost. It could be spamming. I suggest you read the existing responses carefully before going any further. They may be from members who know something.

Peter Wasser

"The whole problem with the world is that fools and fanatics are always so certain of themselves, and wiser people so full of doubts." - Bertrand Russell

Vaclav_24-Mar-14 15:42

Vaclav_

24-Mar-14 15:42

I am trying to change the filter properties (Ezrgb24). I can read the property page – using IspecifyPropertyPages. I get all tabs of the property page, but getting “memory could not be written “error when I try to update it. I am working on that.

SOLVED
The filter .ax file was not being updated in System32 during debugging. Added to Post build proccess.

I have noticed when I access the property page using GrapEdit it is missing the first tab – only the input and output pins tabs are there. It is same on another DirectShow base filter.
I did not have this issue, I could read all tabs on unconnected Ezrgb24.
But I could not get the property page when the filter was connected in graph and running until I registered proppage.dll.
It sure looks as a problem with proppage.dll.(I'll look for a different version ).
Anybody have a knowledge about this issue?
I sure would like to know what is going on.

UNRESOLVED still cannot access Options sheet, only pin properties sheet. Since using GraphEdit for debugging only it does not effect application.

Thanks for reading.
Cheers
Vaclav

-- modified 25-Mar-14 22:15pm.

Re: DirectShow GraphEdit missing property page options tab.

Rage25-Mar-14 2:19

Rage

25-Mar-14 2:19

You need to post your property page initalisation code for us to be able to help you.

~RaGE();

I think words like 'destiny' are a way of trying to find order where none exists. - Christian Graus
Entropy isn't what it used to.

x it.Re: DirectShow GraphEdit missing property page options tab.IN PROGRESS

Vaclav_25-Mar-14 7:29

Vaclav_

25-Mar-14 7:29

Thanks for reply.
I did not specify which issue I need help with. Sorry.

As I said, I'll figure out the update "problem".
I feel the property sheet dialog should do the update just fine.

But I am just curious why the difference between GraphEdit using "off the shelf" filters both Ezrgb24 and Color Conversion Filter.
I did some search and found some discussions to the effect that GraphEdit does some extra work when displaying property sheet.

I think I found my problem, but it will take some undooing to fix it.
For safety reasons I did make copies of both filters and compiled them.
For so far unknown reason the options tab page in property sheet is gone, only the pins pages
are there. I assume this page code is external to the filter code.
That is why it works when filters are added manually in GraphEdit - it uses the original source.

-- modified 25-Mar-14 15:22pm.

Free fails with Access violation reading location

tejaswini_g24-Mar-14 13:31

Re: Free fails with Access violation reading location

24-Mar-14 13:31

Can anyone help what is wrong in the following code snippet.

free (Filelist[i]);

fails with access violation error.

Thanks in advance.

int _tmain(int argc, TCHAR *argv[])
{
int i =0;
char ** Filelist;
int iFileCountInFolder=0;
int iFileSize = 0;

_tcscpy(szDirpath,_T("C:\\BMPread_W\\TransitionEffects\\Images"));

FileCountInDir(szDirpath,&iFileCountInFolder,&iFileSize);
Filelist = (char**)malloc(iFileCountInFolder * sizeof(char *));
if(Filelist == NULL)
{
fprintf(stderr, "out of memory\n");
return;
}
for(i = 0; i < iFileCountInFolder; i++)
{
Filelist[i] = (char*)malloc((iFileSize * sizeof(char))+1);
if(Filelist[i] == NULL)
{
fprintf(stderr, "out of memory\n");
return;
}
}
FindFilesInDirectory(szDirpath, Filelist, &iFileCountInFolder);

if (Filelist != NULL) {
for ( i = 0; i < iFileCountInFolder ; i++)

//following line failing with access voilation
 free (Filelist[i]);

free (Filelist);
}
return 0;
}

modified 24-Mar-14 19:50pm.

Richard Andrew x6424-Mar-14 13:42

Richard Andrew x64

24-Mar-14 13:42

First, put your code between <pre></pre> tags so that it's readable.

Second, the code you cite as causing the error is not even in the snippet you show. Confused | :confused:

The difficult we do right away...
...the impossible takes slightly longer.

Re: Free fails with Access violation reading location

tejaswini_g24-Mar-14 15:01

Re: Free fails with Access violation reading location

24-Mar-14 15:01

re posted.

leon de boer24-Mar-14 15:06

leon de boer

24-Mar-14 15:06

The mallocs and frees are fine in concept the issue is deeper

I suspect this is the problem

Filelist[i] = (char*)malloc((iFileSize * sizeof(char))+1);

iFileSize is initially set to zero and then passed in as a parameter to FileCountInDir which I guess is supposed to fill it in.

But I find it really strange because that function is counting the directory entries from it's function name.

Really the string space allocation should be the length of each individual directory entry name so I am not sure it should be a single value.

For example a file "fred.bmp" should allocate 9 bytes (8+asciiz 0) while "afred.bmp" should allocate 10 bytes (9+asciiz 0)

I fail to see how you are allocating them all as iFileSize unless that is the largest filename in the directory.

And that leads to the answer for your fail that iFilesize must be coming back from FileCountInDir as -1 and that means you are allocating -1+1 = 0 bytes of memory which will fail in malloc returning NULL.

Hence Filelist[i] would indeed be carrying NULL

You can put protection to stop the error by doing this

if (FileList[i] != 0) free (Filelist[i]);

But as discussed I think you have serious issues with iFileSize

Re: Free fails with Access violation reading location

User 5924124-Mar-14 15:25

Re: Free fails with Access violation reading location

24-Mar-14 15:25

I think you are on to it as the mallocs and frees seem OK. Unfortunately not enough information provided.

Peter Wasser

"The whole problem with the world is that fools and fanatics are always so certain of themselves, and wiser people so full of doubts." - Bertrand Russell

User 5924124-Mar-14 15:59

Re: Free fails with Access violation reading location

24-Mar-14 15:59

malloc()-ing 0 bytes doesn't return NULL when I test.
This appears to be implementation dependent.

Peter Wasser

"The whole problem with the world is that fools and fanatics are always so certain of themselves, and wiser people so full of doubts." - Bertrand Russell

User 5924124-Mar-14 15:17

Re: Free fails with Access violation reading location

24-Mar-14 15:17

If you are posting a lump of code a compile ready snippet helps everybody.

Peter Wasser

"The whole problem with the world is that fools and fanatics are always so certain of themselves, and wiser people so full of doubts." - Bertrand Russell

modified 24-Mar-14 21:28pm.

tejaswini_g24-Mar-14 15:39