C / C++ / MFC

Greg Ellis wrote:

I have created a new thread which should run as a separate process.

 tags we can't see your include files for example. Also some idea of what the program does is helpful when it's not obvious from the code (and in this case it aint obvious - are you trying to count the lines that start with A or a or just echo a file to the console?)

Look into these things:

 - Don't use low level constructs (pointer, arrays, dynamic memory allocation) where a couple of local objects would have done (i.e. use <code>std::vector<std::string> lines( number_of_lines );</code> )
 - use variable names that describe what you're doing - i.e. rename adder and A
 - Learn how IOStreams work - <code>cin >> fileName;</code> won't work if you have spaces in the filename
 - Grab a textbook and have a look at the difference between initialisation and assignment. For example there's no reason to not create your input file object and open it at the same time
 - using strlen is completely pointless in a C++ program that's using std::string. Look up the interface to std::string in a decent reference and you'll find a member that does the right thing

Cheers,

Ash

//  #pragma warning( disable : 4101 )
#include<iostream>
#include<fstream>
#include<string>

using namespace std;

class FileSearcher
{
public:

	string fileName,line;
	char filename[256];
	unsigned long fileSize, begin,end;

	int Adder,count;
	string *A;
	 
public:
	FileSearcher(char *file )
	{
		Adder=0;
		count=0;
                runMe(file);
	}


	 
	~FileSearcher()
	{
		delete []A;
	}

public:
        void runMe(char *file)
	{
		cout<<"Enter the file name and complete path:> ";
		cin>>filename;
		fileName.assign( filename );// convert char array to string
		ifstream infile(filename);

		infile.seekg (0, ios::end);   //get file size
		fileSize = infile.tellg();
		infile.close();

		cout << "size is: " << (fileSize) << " bytes.\n";
		A=new string[fileSize+1];  // allocate string size to fileSize
		infile.open(fileName.c_str());

		Adder=0;
		count=0;

		while(!infile.eof())
		{
			getline(infile,line);
			if(line[count]=='A'|| line[count]=='a')   // compare
			{
				
				cout<<"FOUND an A here ("<<line[count]<<") Line= "<<Adder<<": \n\n"<<line.c_str()<<"\n";
				A[Adder]=strlen(line.c_str());//THIS LINE IS CAUSING ERROR 
				
				count++;	
			}
			count=0;
			Adder++;
		}
		infile.close();
		
		cout<<"\n\n";
	}
};
 



int main()
{

   FileSearcher *myFileSearcher = new FileSearcher("c:\\t.txt");

return 0;
}

mrby123 wrote:

...and entered Listbox items...