|
You don't need to malloc Temp: it's just a pointer. You also forgot to free it. You also didn't free the FrontTip argument if it's the only thing allocated (i.e. if its next is NULL). I would write
while(FrontTip != NULL)
{
SomeNode* Temp = FrontTip->next;
free(FrontTip);
FrontTip = Temp;
}
|
|
|
|
|
Quote: You don't need to malloc Temp: it's just a pointer.
I couldn`t explain that bit myself either, it was probably serving for a different purpose in the article I was learning from.
Thanks for your version and your help.
modified 22-Mar-22 18:39pm.
|
|
|
|
|
To be specific about what @k5054 wrote, use std::unique_ptr[^] whenever possible. There's also shared_ptr and weak_ptr for a pointer with multiple owners (shared) or users (weak).
|
|
|
|
|
Hey Greg, there`s more than one issue in the function I posted. Like how do you go about managing a pointer that has been passed to the function.
I`ve seen this code in a codeproject article:
void NukeA(A* p)
{
p->DoThis();
p->DoThat();
delete p;
p = nullptr;
}
My thought is that this is wrong because the original pointer (the pointer being passed) remains at the gates of the function unaffected by the changes inside NukeA();
void NukeSafelyA(A** p)
{
(*p)->DoThis();
(*p)->DoThat();
delete *p;
*p = nullptr;
}
My question is how do you go about assigning a pointer to the pointer being passed or assign the pointer being passed to a new pointer that is stated/declared in the body of the function;
void NukeSafelyA(A** p)
{
(*p)->DoThis();
(*p)->DoThat();
A * Temp1;
A * Temp2;
(*p) = Temp1;
Temp2 = (*p);
delete *p;
*p = nullptr;
}
modified 24-Mar-22 12:13pm.
|
|
|
|
|
Setting a pointer to nullptr after invoking delete on it is definitely recommended. Or in C, setting it to NULL after invoking free. To do it, pass the pointer by reference:
void NukeSafelyA(A*& p)
{
p->DoThis();
p->DoThat();
delete p;
p = nullptr;
}
|
|
|
|
|
Us old-school C programmers tend to forget about the existence of references. Well done, Greg. That's far cleaner than the pointer-to-pointer version the OP presented, but does exactly the same thing.
To the OP:
On the whole though, except as a learning exercise, and some really rare, odd cases, the STL should be the way to go. It's likely to be safer, perhaps faster, and certainly far better tested than your own implementation. The STL should be part of your basic tool kit for C++ programming.
Keep Calm and Carry On
|
|
|
|
|
Thanks guys. As you lean stuff, you begin to understand things that you previously heard about but never really understood. I`m taking the std pointers as a new horizon, at this point I feel that they are remote from where I am. I`ll be using the default c++ approach.
|
|
|
|
|
I am using a property sheet for my app to adjust the options and GUI elements. When the file opens, the app has two tabs created via Addview and all of that is working. OnInitialUpdate sets the styles because it uses the registry settings when it starts. What I'm trying to do is have the styles adjust on an OnApply when the user selects the style they want. I have the OutputPane working correctly which is shown in the code below. What I can't get to work is to have the document tabs change on a Recalc/Redraw.
BOOL CSettingsUserTabs::OnApply()
{
BOOL bResult = CMFCPropertyPage::OnApply();
if (bResult)
{
AfxGetApp()->WriteProfileInt(_T("Settings"), _T("UserTabStyle"), m_style_tabs);
((CMainFrame*)AfxGetMainWnd())->m_wndOutput.m_wndTabs.ModifyTabStyle((CMFCTabCtrl::Style)m_style_tabs);
((CMainFrame*)AfxGetMainWnd())->m_wndOutput.m_wndTabs.RecalcLayout();
CMFCTabCtrl& MDI_STYLES = ((CMainFrame*)AfxGetMainWnd())->GetMDITabs();
MDI_STYLES.ModifyTabStyle((CMFCTabCtrl::Style)m_style_tabs);
MDI_STYLES.RecalcLayout();
CMDIFrameWndEx* pMainFrame = DYNAMIC_DOWNCAST(CMDIFrameWndEx, GetTopLevelFrame());
pMainFrame->SetFocus();
pMainFrame->RecalcLayout();
}
return bResult;
}
Any ideas what I can do solve this problem? I've scoured the net for examples on how to solve this issue and yet to get it to work. There is a TabControl solution in the Microsoft master repository to show how it works, but since I'm using a propertysheet to control it, the example does work but the example doesn't use the AddView so I can't use it as a good example.
Here is the code that loads the RUNTIME_CLASSES where the tabs are created:
void CMovieView::OnInitialUpdate()
{
AddView(RUNTIME_CLASS(CTabView1), AfxStringID(IDS_TAB1));
AddView(RUNTIME_CLASS(CTabView2), AfxStringID(IDS_TAB2));
GetTabControl().EnableTabSwap(TRUE);
GetTabControl().SetLocation(CMFCBaseTabCtrl::Location::LOCATION_TOP);
GetTabControl().EnableAutoColor(TRUE);
int UserTabStyle = AfxGetApp()->GetProfileInt(_T("Settings"), _T("UserTabStyle"), 0);
if (UserTabStyle != FALSE && UserTabStyle <= 8) {
int EnumUserTabStyle = UserTabStyle - 1;
GetTabControl().ModifyTabStyle(static_cast<CMFCTabCtrl::Style>(EnumUserTabStyle));
}
else {
GetTabControl().ModifyTabStyle(CMFCTabCtrl::STYLE_FLAT);
}
CTabView::OnInitialUpdate();
}
This works on creation, I can't get it to work when the OnApply() is used because you can't recall OnInitialUpdate for something already created. I can't seem to get GetTabControl() to work after on create as a separate function....so I'm unclear on how to solve this problem. Does anyone have any ideas on how I can modify my code to get it working?
Thanks,
Chris
|
|
|
|
|
Message Closed
modified 15-May-23 19:06pm.
|
|
|
|
|
I'm net entirely clear on what you're trying to do.
Normally, a library that is expected to be used by a developer is supplied with a header file that describes the contents of the library, that is #included in the source file of user created software. That's what stdio.h or iostream do for you. If at all possible, you should look for the developer tools for your library and use the supplied headier.
Alternatively - and this is only as a last resort for the well-informed and foolhardy, there's no reason you can't declare the function in your own source code. But, you really have to know what the function signature is. If you have a mismatch, then you're almost certainly going to invoke Undefined Behavior, and then all bets about the validity of anything your program produces is suspect.
So for example, we know that the signature for a cosine function in the c standard library is double cos(double x;. Now normally we would write
#include <math.h>
double val = cos(2.5);
But it's perfectly valid to write
double cos(double x);
double val = cos(2.5);
But as I state above, you need to be sure that you've got the right signature for your function. If for example we were to write
double cos(int x); double val = cos(2.5)
/ ... Then the compiler will convert the 2.5 to an integer (e.g. a 4 byte value containing the value 0x02), and then pass that to the math library cos() function. On the library side, the code is expecting a double (e.g an 8 byte value in IEEE floating point format), so it will dutifully use the top 8 bytes of the stack for the value to calculate the cosine for. As you can see, we've only put 4 bytes on the stack in our call, and so half the data its using to calculate is, in essence, random data. Clearly, in this case we can't rely on what value cos() returns to us.
This is not the same as passing an int to cos() that has been properly declared. In that case, the compiler knows that the cos() function is expecting a double as its argument, so it provides a conversion from int to double at compile time.
Keep Calm and Carry On
|
|
|
|
|
Message Closed
modified 15-May-23 19:06pm.
|
|
|
|
|
|
Message Closed
modified 15-May-23 19:06pm.
|
|
|
|
|
First, the function you are trying to call is hci_inquiry not hci-inquiry. The second is an invalid identifier, and the compiler should be trying to parse this as hci - inqury. Not the same thing at all.
Second, looking at the documentation (RTFM! RTFM!), it looks like you probably want to use Qt::Concurrent::run(). Maybe start another thread and include the code that (a) works and (b) fails - plus what the failure mode is. As it is I'm blindly guessing at what you're doing and what may or may not be going wrong for you.
Third, Maybe look for a QT support forum. This forum isn't really intended to help with QT, but with C, C++ or MFC. I think I'm safe in saying that QT lies outside those bounds. It might be that there's noone here particularly well versed in QT.
Keep Calm and Carry On
|
|
|
|
|
Message Closed
modified 15-May-23 19:06pm.
|
|
|
|
|
Looking at the documentation at Concurrent Run | Qt Concurrent 5.15.8[^], it suggests you should be able to write:
QFuture<void> future_hci = QtConcurrent::run(
hci_inquiry,
dev_id,
len,
max_rsp,
NULL,
&ii,
flags);
But as k5054 already said, this is the C/C++ forum. For Qt issues you need to find a specialist forum. My feeling would be to write a small test program using the Qt run function with different parameters to check that it does work for the different situations. Once you overcome that issue then you should be able to focus more on the HCI stuff.
|
|
|
|
|
Message Closed
modified 15-May-23 19:06pm.
|
|
|
|
|
Member 14968771 wrote: QTconcurent will not accept more than 5 parameters,
What's your source for this statement. The docs Concurrent Run | Qt Concurrent 5.15.8 do not mention any limit. Assuming that its a C++ template using a parameter pack, the only limit I would expect would be your pthread stack size, which defaults to 8M, so for all intents an purposes not an issue.
One thing I would note is that hci_inquiry returns an int so I think the template parameter to QFuture should probablby be:
QFuture<int> future = QTconcurrent::run( ... )
Keep Calm and Carry On
|
|
|
|
|
Message Closed
modified 15-May-23 19:06pm.
|
|
|
|
|
Message Closed
modified 15-May-23 19:06pm.
|
|
|
|
|
Did some testing of my own over the weekend and I can confirm that QtConcurrent::run() does not like more than 5 parameters. Maybe the thing to do is to look into std::async, std::future as it does not seem to be limited and provides the same functionality. There's a couple of videos on them here: C++ Weekly - Ep 9 std::future Quick-Start - YouTube and here: C++ Weekly - Ep 11 std::future Part 2 - YouTube. Unless there's something in QtConcurrent that ties in better with your QT project, std::async and std::future may server you better.
As a point of interest, why QT? If you're on Ubuntu, and not using Kubuntu, I would have thought that maybe GTK+ would provide a more consistent look-&-feel. There are C++ bindings available (gtkmm), so if you're on a QT/C++ learning curve it would be about the same for you. There's no integrated IDE with gtk, but there's plenty of IDE's out there that will play nicely. Or you could go "hardcore" and learn how to write Makefiles!
Keep Calm and Carry On
|
|
|
|
|
Member 14968771 wrote: ( ...but for some who cannot read it looks as QT problem...)
Adding comments like that is unnecessary, and does not encourage people to help further.
|
|
|
|
|
Member 14968771 wrote: QTconcurent will not accept more than 5 parameters
Reminds me of when I worked for a company about to publish a completely rewritten FORTRAN compiler: The release was pushed by one (significant) customer who had run into the old compiler's limit on 99 (ninety-nine) parameters to one function. The new compiler would allow 128 parameters, but it could easily be extended to 256 in future compiler versions.
I sort of accept that when going above a certain limit (isn't it 4 for the ARM ABI?), there is an increased cost. Five is probably acceptable. The day it grows beyond 99, I think you are on the wrong track 
|
|
|
|
|
It reminds me of an adage or axiom or some such that my prof stated in class back in university days that went something like "If you function has more than 5 parameters, you've forgotten one!"
Keep Calm and Carry On
|
|
|
|
|
I merely said, "the documentation suggests ...". I do not have Qt on my system so I am not able to test it.
|
|
|
|
General 
News 
Suggestion 
Question 
Bug 
Answer 
Joke 
Praise 
Rant 
Admin 
Submit an article or tip
