ATL / WTL / STL Discussion Boards

Garth J Lancaster24-Mar-13 11:32

24-Mar-13 11:32

not exactely sure where/what your problem is ...

Are all your 'Cannot open source file' errors related to files under 'COMMON_CODE' directory ?

This is what I would do if all the errors ARE related to files under 'COMMON_CODE' - (and I'd use Windows Explorer and find to check where they are)

a) set an environment variable to where COMMON_CODE is - that is, I'd set a Permanent System variable - eg COMMON_CODE and point it to Drive:\Path\COMMON_CODE

b) restart the machine

c) In VS2008, open your project, Under 'Additional Include Directories', include ${COMMON_CODE} (I think you need a space between this and the other directories iirc)

When you move directories in future, you change the environment variable, not the project. I do this particularly for 3rd party libraries, where I might need to point to different versions of a library.

You still have to point it to the correct location, in either case/whichever way you're doing it, it looks like your 'Additional Include Directories' setting is still wrong

'g'

Re: Additional Include Directories

bkelly1324-Mar-13 12:15

bkelly13

24-Mar-13 12:15

Re: Are all your 'Cannot open source file' errors related to files under 'COMMON_CODE' directory ?

Yes, they are. The entire solution compiled and ran as expected. Then I copied the entire solution to another location. The build then began reporting that it could not find any of the files in directory D:\COMMON_CODE.

Re: You still have to point it to the correct location, in either case/whichever way you're doing it, it looks like your 'Additional Include Directories' setting is still wrong.

I don't see how it can be wrong. The common directory did not move, but the entire solution did. The additional directory location is being converted to a relative location directory. The configuration section does not specify a relative location, it specifies an absolute location.

Thanks for your time
If you work with telemetry, please check this bulletin board: http://www.bkelly.ws/irig_106/

Re: Additional Include Directories

H.Brydon26-Mar-13 16:32

H.Brydon

26-Mar-13 16:32

Garth J Lancaster wrote:
c) In VS2008, open your project, Under 'Additional Include Directories', include ${COMMON_CODE} (I think you need a space between this and the other directories iirc)

The include directories should be a semicolon-separated list. The directories themselves may (or may not) contain spaces.

In the bigger picture, I endorse this way of specifying directories.

If I understand the original problem properly, OP used a full filespec for an include directory. Visual Studio likes to keep track of file and directory locations relative to the location of the project file (or solution file, depending on things). If you get a solution/project working in one location (which points to an absolute file/folder location) and then copy the solution/project to another location, the 'relative' file/folder pointers will be wrong. Garth's solution should fix that part of the problem.

--
Harvey

Re: Additional Include Directories

dusty_dex24-Mar-13 11:41

dusty_dex

24-Mar-13 11:41

Have you tried deleting all temporary files, including precompiled headers?

"It's true that hard work never killed anyone. But I figure, why take the chance." - Ronald Reagan

That's what machines are for.

Got a problem?
Sleep on it.

Re: Additional Include Directories

bkelly1324-Mar-13 12:26

bkelly13

24-Mar-13 12:26

I deleted the dot NCP file where the project file is located. I deleted the all the files in the release directory and all the files in the debug directory. All to no avail.

I removed the D:\COMMON_CODE from the configuration, cleaned, recompiled, re-added it, and same results. It still refuses to find the files in the common directory. The errors show a relative directory location based on the original location.

What other files might I try to delete.

The same project continues to build in the original location.

Thanks for your time
If you work with telemetry, please check this bulletin board: http://www.bkelly.ws/irig_106/

Re: Additional Include Directories

SoMad24-Mar-13 13:26

SoMad

24-Mar-13 13:26

Perhaps I am missing something here. The sample you have shown is for a .cpp file. This suggests to me that this is not a problem with your "Additional Include Directories", but that those files were included into your project with the relative path. I would open up the .vcxproj (if that is the extension used for 2008) and look at the path specified for that file.

As an example from one of my projects, there are files included like this:

XML

<ItemGroup>
  :
  <ClCompile Include="StdAfx.cpp">
    :
    :
  </ClCompile>
  <ClCompile Include="..\..\Libraries\include\Packets\Stream.cpp">
    :
    :
  </ClCompile>
  :
</ItemGroup>

Obviously if you just copy the solution to a folder with a different nesting level, that will mess things up.

[EDIT]Updated the entries from my sample to show the .cpp files instead of the .h files[/EDIT]

Soren Madsen

"When you don't know what you're doing it's best to do it quickly" - Jase #DuckDynasty

Re: Additional Include Directories

bkelly1324-Mar-13 13:47

bkelly13

24-Mar-13 13:47

File Project_Client_.vcproj contains:

<Tool
				Name="VCCLCompilerTool"
				Optimization="0"
				AdditionalIncludeDirectories="D:\COMMON_CODE"
				PreprocessorDefinitions="WIN32;_WINDOWS;_DEBUG"
				MinimalRebuild="true"
				BasicRuntimeChecks="3"
				RuntimeLibrary="1"
				UsePrecompiledHeader="2"
				WarningLevel="3"
				DebugInformationFormat="4"

It has the absolute location of the include files. I presume that is correct.

Re: Obviously if you just copy the solution to a folder with a different nesting level, that will mess things up.

I don't see why. Everything within the solution proper is in the same relative locations. Only this directory is in the stated absolute location. The problem is only with the common code directory, and it has the correct path for that. Same as the original location.

Edit: But then in another place in the same file is this:

<Files>
    <Filter
        Name="Source Files"
        Filter="cpp;c;cc;cxx;def;odl;idl;hpj;bat;asm;asmx"
        UniqueIdentifier="{4FC737F1-C7A5-4376-A066-2A32D752A2FF}"
        >
        <File
            RelativePath="..\..\..\..\COMMON_CODE\C_Log_Writer.cpp"
            >
        </File>
        <File
            RelativePath="..\..\..\..\COMMON_CODE\C_TCP_Client.cpp"
            >

So it has the location in both relative and absolute position. That appears to be the worst of both worlds. How do I tell VS to recalculate all the relative positions.

Thanks for your time
If you work with telemetry, please check this bulletin board: http://www.bkelly.ws/irig_106/

Re: Additional Include Directories

SoMad24-Mar-13 14:00

SoMad

24-Mar-13 14:00

But that is because the "Additional Include" directories is for including header files.

Let me ask you this: If you double-click on your C_Log_Writer.cpp in your solution, is it found and opened in the IDE? I do not expect it to be if the relative path specified in you project file is now incorrect.

Soren Madsen

"When you don't know what you're doing it's best to do it quickly" - Jase #DuckDynasty

Re: Additional Include Directories

bkelly1324-Mar-13 14:11

bkelly13

24-Mar-13 14:11

Upon clicking on C_Log_Writer.cpp VS pops a message:
d:\B\COMMON_CODE\C_TCP_Client.cpp Cannot open file.

The solution is in directory D:\B\etc. The common code is in D:\COMMON_CODE like I explicitly specified in the configuration. It has no business putting that \B\ in there. I say again, the additional directories was specified as an absolute path, not a relative one. The original solution had both the dot CPP and the dot H file added. All were shown in the solution explorer.

Edit:
While in that configuration section of VS and with Additional Directories selected, press F1. In there it has an example that includes MAIN.C. I do not see it as limited to dot H or dot HPP files.

Thanks for your time
If you work with telemetry, please check this bulletin board: http://www.bkelly.ws/irig_106/

modified 24-Mar-13 20:21pm.

Re: Additional Include Directories

SoMad24-Mar-13 14:40

SoMad

24-Mar-13 14:40

Alright, so it may not be limited to header files, but I cannot remember ever seeing it used for .cpp files. I will refer back to my original answer, the problem is not with your Additional Include Directories, but with the way file references are stored when added to a project.

You may have a point that Visual Studio should use the Additional Include Directories path and save file references without paths (although I would not trust the "find first match" scheme to always find the correct file in case of multiple files with the same name in different Include Directories), but the way you can fix it now seems obvious to me: Correct the paths of the files in your project file. You can even try to just remove the paths completely and see if the files are found using the Additional Include Directories.

Soren Madsen

"When you don't know what you're doing it's best to do it quickly" - Jase #DuckDynasty

Re: Additional Include Directories

Richard MacCutchan24-Mar-13 23:37

Richard MacCutchan

24-Mar-13 23:37

This has nothing to do with include directories, since the file in question is a .cpp not a header file. You need to remove the relevant file(s) from the project and add them in again, using the absolute paths.

Use the best guess

Re: Additional Include Directories

bkelly1325-Mar-13 16:14

bkelly13

25-Mar-13 16:14

RE: This has nothing to do with include directories, since the file in question is a .cpp not a header file.

As noted in an earlier reply, the VS help utility has an example that includes MAIN.C. I disagree with that fundamental concept. The dialog does not explicitly or implicitly restrict the use to dot H / HPP files.

Per MacCutchan's reply, removing the files and adding them back in does work. It works, but I am not at all fond of that solution.

That said, and in my not so humble opinion, I find this to be a defect in Visual Studio.

Thanks for your time
If you work with telemetry, please check this bulletin board: http://www.bkelly.ws/irig_106/

Re: Additional Include Directories

Richard MacCutchan25-Mar-13 23:41

Richard MacCutchan

25-Mar-13 23:41

bkelly13 wrote:
The dialog does not explicitly or implicitly restrict the use to dot H / HPP files.

Maybe so, but that is the way the compiler (and by extension Visual Studio) operates. When you want to compile a file, the path and name(s) of the source file(s) to be compiled must be explicitly provided. Any header files that are referred to in the source are searched for according to the rules for that compiler. Most compilers will search the current directory, any directory that contains a named source file, and any directories that are listed in the 'include' lists; these are specified by option, environment variables etc. If the directory path for a source file is incorrect then the compiler will fail that compile and report the error. It will not make any attempt to look in the include directories for it.

bkelly13 wrote:
It works, but I am not at all fond of that solution.

Well that's the way it's supposed to work, and always has done.

bkelly13 wrote:
I find this to be a defect in Visual Studio.

I think you may be in a minority.

Use the best guess

memcpy, not understanding something

bkelly1311-Mar-13 14:11

bkelly13

11-Mar-13 14:11

Windows 7, Visual Studio 2008, MFC, C++
A memset is not doing what I expect. Here is the relevant code. It is a received TCP/IP payload packet and the goal is to copy some of the data to a new location. m_carry_over_bytes has the expected value of 1200.

All the code surrounding the memcpy is just to look at the before and after.

m_prev_header_packet_size     = mp_search_pointer->iads_structure.header.packet_size;
 m_prev_header_sequence_number = mp_search_pointer->iads_structure.header.sequence_number;
 m_prev_header_packets_sent    = mp_search_pointer->iads_structure.header.packets_sent;
 m_prev_header_packets_lost    = mp_search_pointer->iads_structure.header.loss_or_overflow;
 m_prev_header_dummy_0_5555    = mp_search_pointer->iads_structure.header.dummy[0];
 m_prev_header_dummy_1_6666    = mp_search_pointer->iads_structure.header.dummy[1];
 m_prev_header_dummy_2_7777    = mp_search_pointer->iads_structure.header.dummy[2];
 m_prev_header_dummy_3_ffff    = mp_search_pointer->iads_structure.header.dummy[3];


 memcpy( &m_carry_over_buffer,
         &mp_search_pointer,
         m_carry_over_bytes );

 m_curr_header_packet_size     = m_carry_over_buffer.iads_structure.header.packet_size;
 m_curr_header_sequence_number = m_carry_over_buffer.iads_structure.header.sequence_number;
 m_curr_header_packets_sent    = m_carry_over_buffer.iads_structure.header.packets_sent;
 m_curr_header_packets_lost    = m_carry_over_buffer.iads_structure.header.loss_or_overflow;
 m_curr_header_dummy_0_5555    = m_carry_over_buffer.iads_structure.header.dummy[0];
 m_curr_header_dummy_1_6666    = m_carry_over_buffer.iads_structure.header.dummy[1];
 m_curr_header_dummy_2_7777    = m_carry_over_buffer.iads_structure.header.dummy[2];
 m_curr_header_dummy_3_ffff    = m_carry_over_buffer.iads_structure.header.dummy[3];

Looking at the m_prev* variables I find the expected values: size is 1228, sequence_number is 62316, ... dummy 2 is 0x7777, etc

After the memcpy, the m_curr* values are expected to have the same values ad the m_prev* values. Instead they have all Fs, the value it was initialized to in the constructor.

Both the source and destination work back to this structure:

CSS

// 
  union RECEIVE_TYPE
  {
     char char_array [ C_TCP_MAX_RECEIVE_SIZE ];
     C_IADS_TD_FIXED_PARAMETER_PACKET iads_structure;
  } m_receive_buffer;

I expected this memcpy to be simple. Where am I not understanding it?

Thanks for your time
If you work with telemetry, please check this bulletin board: http://www.bkelly.ws/irig_106/

modified 11-Mar-13 20:47pm.

Re: memcpy, not understanding something

H.Brydon11-Mar-13 14:41

H.Brydon

11-Mar-13 14:41

You haven't shown all of the structures involved, but perhaps the memcpy() should be:

C++

memcpy( &m_carry_over_buffer,
         mp_search_pointer,
         m_carry_over_bytes );

--
Harvey

Re: memcpy, not understanding something

bkelly1311-Mar-13 14:53

bkelly13

11-Mar-13 14:53

H.Brydon,
You got it right. I was forgetting that mp_search_pointer was a pointer to start with. Still, I don't understand why it did not copy something into m_carry_over_buffer

Just for completeness they are declared as:

RECEIVE_TYPE *mp_search_pointer;
RECEIVE_TYPE  m_carry_over_buffer;

Thanks for your time
If you work with telemetry, please check this bulletin board: http://www.bkelly.ws/irig_106/

Re: memcpy, not understanding something

Richard MacCutchan11-Mar-13 22:35

Richard MacCutchan

11-Mar-13 22:35

You are specifying the source address as &mp_search_pointer which is the address of the pointer, rather than the pointer itself. I suspect that is not what you intended.

Use the best guess

Re: memcpy, not understanding something

Dale Burr28-Apr-13 22:01

Dale Burr

28-Apr-13 22:01

Richard MacCutchan wrote:
You are specifying the source address as &mp_search_pointer which is the address of the pointer, rather than the pointer itself. I suspect that is not what you intended.

Exactly right. The address of the pointer gives you a block of memory just 4-bytes long, containing a memory address. The pointer itself gives you the allocated memory you're looking for.

member char array is bad pointer

bkelly139-Mar-13 16:41

bkelly13

9-Mar-13 16:41

Environment Visual Studio 2008, C++, MFC
Class C_TCP_Format_WSA_Text has a method that begins like this:

void C_TCP_Format_WSA_Text::Format_WSA_Error_As_Text( int wsa_error, char*  wsa_text )
{...}

Class C_TCP_Client has this member declaration:

char m_tcp_error_text[ MAX_WSA_ERROR_TEXT ];

and has a method with a call that looks like this:

void C_TCP_Client::OnConnect( int nErrorCode )
{...
   m_C_TCP_Format_WSA_Text.Format_WSA_Error_As_Text( m_wsa_error_code, m_tcp_error_text );
...}

The compiler accepts it but when the code gets to the call to Format_WSA_Error_As_Text() the debugger says that m_tcp_error_text is a bad pointer. I looked at an example via google and it indicates my code is fine.
What am I missing?

Thanks for your time

Re: member char array is bad pointer

Richard MacCutchan9-Mar-13 22:40

Richard MacCutchan

9-Mar-13 22:40

You need to look in your debugger to see what the actual values of all the variables are. I can only assume that you are calling Format_WSA_Error_As_Text() from somewhere else and the pointer is not the one that you think it is. BTW your overuse of underscores in class and variable names does not make for easy reading, see MSDN's paper on General Naming Conventions[^].

Use the best guess

Unexpected result

bkelly1310-Mar-13 6:09

bkelly13

10-Mar-13 6:09

Following your advice I found some completely unexpected results. Skipping some steps here is the situation. From code in the dialog box the TCP client class is created as follows:

try
{
   mp_C_TCP_Client = new C_TCP_Client( mp_C_Log_Writer,
      C_TCP_DEFAULT_SOCKET_PORT,
      C_TCP_DEFAULT_IP_ADDRESS  );
   last_error = GetLastError();

} catch( ... ) {...}

Before stepping over the new statement, the port number is 49000 and the IP address is 192.168.2.2. Further down is this fragment:

if( mp_C_TCP_Client != NULL )
{
   mp_C_TCP_Client->Set_Log_Sequence_Match(      m_log_sequence_miss_match );

In the debugger the variable m_log_sequence_miss_match shows up as false, expected.

After stepping over the new statement, which does not catch any exception, the debugger no longer displays any value for that variable. It does not show a value for last_error = GetLastError().

When a break point is put in the constructor the arguments, correct before the new statement, are not correct within the constructor.

I presume there is something wrong with the new operation, but the debugger continues to step through the code in the constructor of the just created object. The values of the variable are clearly incorrect, but the debugger keeps on stepping.

BTW: here is a critical declaration:

C_TCP_Client *mp_C_TCP_Client;

I have been working on this code for a while and construction of the object has been fine. As usual, I do not recall making any changes that would affect the object's construction.

I do not know how to interpret these symptoms.

Thanks for your time

Re: member char array is bad pointer

bkelly1310-Mar-13 7:29

bkelly13

10-Mar-13 7:29

To reply to your comment on my underscore and the convention.
IDoNotLikeWritingLikeThis. IWouldNeverBuyABookWrittenLikeThis. IBelieveAllLanguagesUseSpacesBetweenWords.
More like this. Since I use expressive names,
the_underscore_meets_syntax_rules_with_minimum_disruption. In my opinion, the use of under scores is far more readable then camel case.
Another standard is to use UPPER_CASE when creating constants. So how does the standard address that in this example: DAYSOFTHEWEEK = 7. My choice is DAYS_OF_THE_WEEK. With this example, my use of under scores in variable names is consistant, camel case is inconsistent.
PLEASE note that I do not critisize others on this concept. I do NOT take offense at your comment, but do RESPECTFULLY disagree. Please, no flame wars on this topic.

Thanks for your time
If you work with telemetry, please check this bulletin board: http://www.bkelly.ws/irig_106/

Re: member char array is bad pointer

Richard MacCutchan10-Mar-13 8:04

Richard MacCutchan

10-Mar-13 8:04

bkelly13 wrote:
I do NOT take offense at your comment, but do RESPECTFULLY disagree.

Similarly my comment was just that, not a criticism.

Use the best guess

resolved, with many curses directed at myself

bkelly1310-Mar-13 7:38

bkelly13

10-Mar-13 7:38

I just saw an earlier posting of mine that someone answered and was the answer to this one.

This application is TCP/IP code. The solution has two projects, Server and Client. I built in release so I could copy the Server exe to another computer and run it there where testing the client on my desktop. Then I forgot to go back to debug mode and rebuild. The debugger is wildly inconsistent and does not work well when running a release version.

That was a stupid error on my part.

Thanks for your time
If you work with telemetry, please check this bulletin board: http://www.bkelly.ws/irig_106/

Re: resolved, with many curses directed at myself

Richard MacCutchan10-Mar-13 8:05

Richard MacCutchan

10-Mar-13 8:05

bkelly13 wrote:
That was a stupid error on my part.

Something I have done many times.

Use the best guess

Use Ctrl+Left/Right to switch messages, Ctrl+Up/Down to switch threads, Ctrl+Shift+Left/Right to switch pages.