|
I have a CString type variable with a large HTML file in it. When I attempt to replace all occurrances of a character with another characer, it works fine, however, if I attempt to replace a string ("= ") with another string ("="), it appears to get stuck in some endless loop somewhere.
I have left it running for hours, and it is still stuck at the same replace statement. Is there something I'm missing?
|
|
|
|
|
Whats your code?
Mazy
"The more I search, the more my need
For you,
The more I bless, the more I bleed
For you."The Outlaw Torn-Metallica
|
|
|
|
|
It's not a very elegant method, but the code is:
void CParser::StandardiseHTML ( CString* HTMLfile )
{
HTMLfile->Replace ("@", "@");
HTMLfile->Replace ('\n', ' ');
HTMLfile->Replace ('\t', ' ');
HTMLfile->Replace (" ", " ");
while ( HTMLfile->Replace (" ", " ") != 0 );
HTMLfile->Replace (" =", "=");
HTMLfile->Replace ("= ", "=");
HTMLfile->MakeUpper ();
}
It manages to get into trouble with the statement
HTMLfile->Replace (" ", " ");
|
|
|
|
|
What??? No, where it says
HTMLfile->Replace (" ", " ");
the first string is actually a non-braking space character - In the while loop, it's meant to have two spaces between the first seyt of inverted commas, and one in the second set.
|
|
|
|
|
Is it possible the first character is actually a space just like the second? That would cause an infinite loop, as each call to replace will find the same character and replace it with itself.
|
|
|
|
|
Hi,
Sometimes, I feel a little bit lost with COM, and QI AddRef Release, smart pointers, long pointers to...., just two case:
Should I Release this pointer or not ?
LPDISPATCH pDisp = Fmt.GetObject();
And in this case ?
BSREPORTCTRLSLib::IBsMetafile *pIBsMeta;
pDisp->QueryInterface(IID_IBsMetafile, (void **) &pIBsMeta);
Thanks, Greetings
Braulio
|
|
|
|
|
[edited - I shouldn't watch FIFA World Cup and answer questions at the same time]
You should use Release when you're done with interface returned from QueryInterface call.
Have no idea about GetObject.
Tomasz Sowinski -- http://www.shooltz.com
- It's for protection
- Protection from what? Zee Germans?
|
|
|
|
|
QI calls AddRef() on your behalf internally, calling it again on the returned pointer means you now have 2 references on the interface pointer and need to call Release() twice...
See: ATLBase.h 5374 (your line numbers may vary  ) for an example QI implementation:
ATLINLINE ATLAPI AtlInternalQueryInterface(
void* pThis,
const _ATL_INTMAP_ENTRY* pEntries,
REFIID iid,
void** ppvObject)
{
ATLASSERT(pThis != NULL);
ATLASSERT(pEntries->pFunc == _ATL_SIMPLEMAPENTRY);
if (ppvObject == NULL)
return E_POINTER;
*ppvObject = NULL;
if (InlineIsEqualUnknown(iid))
{
IUnknown* pUnk = (IUnknown*)((int)pThis+pEntries->dw);
pUnk->AddRef();
*ppvObject = pUnk;
return S_OK;
}
...
Len Holgate
www.jetbyte.com
The right code, right now.
|
|
|
|
|
This happens when you watch a game and surf CP. Anyway, Senegal leads 1 after first half
Tomasz Sowinski -- http://www.shooltz.com
- It's for protection
- Protection from what? Zee Germans?
|
|
|
|
|
|
Braulio Díez wrote:
Should I Release this pointer or not ?
LPDISPATCH pDisp = Fmt.GetObject();
Yes. A function has returned you an interface, it will have called AddRef() before it returned it to you, you now own a reference to the interface and should call Release() when you're done with it.
Braulio Díez wrote:
And in this case ?
BSREPORTCTRLSLib::IBsMetafile *pIBsMeta;
pDisp->QueryInterface(IID_IBsMetafile, (void **) &pIBsMeta);
Again, yes. You've called QI, that results in the interface that is returned to you being AddRef()'d, you now own a reference to the interface and should call Release().
In both cases you have bare interface pointers so you're responsible for managing the reference counts. Generally, if you have bare pointers and a function returns you an interface you need to call Release() when you're done.
Len Holgate
www.jetbyte.com
The right code, right now.
|
|
|
|
|
Every reference to an interface needs to be released...
Mauricio Ritter - Brazil
Sonorking now: 100.13560 Trank
![Beer | [beer]](https://codeproject.global.ssl.fastly.net/script/Forums/Images/beer.gif) The alcohol is one of the greatest enemys of man, but a man who flee from his enemys is a coward.
|
|
|
|
|
when I click in my editbox,I want all the contents to be
selected,I used these code:
void CCaculatorDlg::OnSetfocusEDITap1()
{
CEdit* ped=(CEdit*)GetDlgItem(IDC_EDIT_ap1);
ped->SetSel(0, -1, FALSE);
}
but it doesnt work, when I click at the editbox, it
just like havent added these code.
what could I do?
|
|
|
|
|
Did you try handling GetFocus instead of SetFocus?
modified 12-Sep-18 21:01pm.
|
|
|
|
|
but there's no message like GetFocus,
(I look it up in class wizard)
|
|
|
|
|
Use EN_SETSEL
-----
// editHWnd is the handle to your edit control
// from and to are the beginning and end of your select range
SendMessage(editHWnd, EM_SETSEL, static_cast<wparam>(from),
static_cast<lparam>(to));
-----
Kuphryn
|
|
|
|
|
There's no EN_SETSEL.
Tomasz Sowinski -- http://www.shooltz.com
- It's for protection
- Protection from what? Zee Germans?
|
|
|
|
|
I meant EM_SETSEL.
Kuphryn
|
|
|
|
|
And what do you think CEdit::SetSel does?
Tomasz Sowinski -- http://www.shooltz.com
- It's for protection
- Protection from what? Zee Germans?
|
|
|
|
|
There are more than one way to get it working. Using EM_SETSEL is another method. I recommend trying that method to see if get the design where you want it.
Kuphryn
|
|
|
|
|
Just FYI, CEdit::SetSel is a thin wrapper which sends EM_SETSEL. So there's no difference, unless you want to achieve macho-API posture. 
Tomasz Sowinski -- http://www.shooltz.com
- It's for protection
- Protection from what? Zee Germans?
|
|
|
|
|
Two things: First (as I go into Pedantic mode...)
Anonymous wrote:
CEdit* ped=(CEdit*)GetDlgItem(IDC_EDIT_ap1);<br />
ped->SetSel(0, -1, FALSE);
I would recommend that you do not get into the habit of casting the return value of GetDlgItem(...) to a CEdit* (or other class type) like that. There are certain situations where GetDlgItem(...) will return a pointer to a real CEdit (or other Control Class) object, but if you do not know what those situations are, it is best to avoid this entirely. Bind a CEdit member variable to the control, and use it instead.
True, in the case of MFC, doing that is usually safe, but in general C++ practices, it is a bad thing to do: you do not know if the pointer returned by GetDlgItem(...) is, or ever was, a pointer to an actual CEdit object.
Second, try using PostMessage(...) to send yourself the EM_SETSEL message from inside the OnSetFocus handler.
BTW: CWnd::OnSetFocus(...) is a standard function. What is OnSetfocusEDITap1 supposed to be? You may be handling the WM_SETFOCUS message incorrectly.
Peace!
-=- James.
"Some People Know How To Drive, Others Just Know How To Operate A Car."
(Try Check Favorites Sometime!)
|
|
|
|
|
yeah, I thought there must be sth wrong with the function
OnSetfocusEDITap1,I thought may be there is a function
named OnGetFocus...., but I failed to find it.
Have you met this question?
|
|
|
|
|
Hi
I have a CDialog based app which queries a data to gainthe information it requires to fill up the controls, but it takes a bit of time atm and i've not got it threaded or anything...which do people reckon is better...write a thread handler to get the info and a timer to check if the thread is finished...or use a callback function?
Bryce
I reckon callback fwiw
|
|
|
|
|
bryce wrote:
write a thread handler to get the info and a timer to check if the thread is finished
Just before returning from thread function use PostMessage to notify your dialog that processing is done.
Tomasz Sowinski -- http://www.shooltz.com
- It's for protection
- Protection from what? Zee Germans?
|
|
|
|
General 
News 
Suggestion 
Question 
Bug 
Answer 
Joke 
Praise 
Rant 
Admin 
Submit an article or tip
