C / C++ / MFC

KeithF wrote:

...in VC 1.52 you cannot declare variables on the same lin that they are used.

char **Arg1;
Arg1 = &va_arg(arglist, char *);

KeithF wrote:

char **Arg1
Arg1 = &va_arg( arglist, char *);

char **Arg1
*Arg1 = &va_arg( arglist, char *);

<br />
char* tmpArg1;<br />
char** Arg1;<br />
<br />
tmpArg1 = va_arg( arglist, char *);<br />
Arg1 = &tmpArg1;<br />

CEmboss* pEmboss = dynamic_cast<CEmboss*>(pItem);<br />
if (pEmboss)<br />
   pEmboss->GetOrientation();

piul wrote:

On the other hand, I'd considered using dynamic casting, but the book I'm reading says it is not recommendable. That it might be a sign of poor inheritance hierarchy design.

piul wrote:

On the other hand, I'd considered using dynamic casting, but the book I'm reading says it is not recommendable. That it might be a sign of poor inheritance hierarchy design.

Cedric Moonen wrote:

- virtual functions in your case make the code less readable (what is this GetOrientation function doing in my CItem class ??)

CPallini wrote:

(BTW doing nothing is one my preferred activities ).

typedef enum
{
    eIT_UNDEFINED = 0,
    eIT_ITEM,
    eIT_EMBOSS,
    eIT_ANNEAL,
} EItemType; 

EItemType m_eItemType;

int GetOrientation()
{
     int result = NO_ORIENTATION;
     switch (m_eItemType)
     {
         case eIT_EMBOSS:
         {
             result = ((CEmboss *)  m_pItem)->GetOrientation();
             break;
         }
         default:
            break;
     }
     return result;
}

class CNode
{...
int GetOrientation() const
{
  CEmboss* pEmbossItem = dynamic_cast<cemboss*>(m_pItem);

  if(pEmbossItem != NULL)
  {
    return pEmbossItem->GetOrientation();
  }
  else
  {
    // Error
    return ERROR_VALUE;
  }  
}</cemboss*>

piul wrote:

The question is, how do I implement a GetOrientation() function in CNode??

// generic class
class CNode
{
public:
	virtual bool process() = 0
	{
		// common default function
	}
};

class CEmbossNode : public CNode
{
public:
	virtual bool process()
	{
		// access CItem or CEmboss data/functions
		return CNode::process();	// or call default
	}
protected:
	int GetOrientation() const  { return mnOrient; }
private:
	int mnOrient;
	CEmboss * mpItem;
}

class CAnnealNode : public CNode
{
public:
	virtual bool process()
	{
		// access CItem or CAnneal data/functions
		// or call default
	}
private:
	CAnneal * mpItem;
};

class CList
{
	// ...
	CNode * mpListHead;
}

Hanan888 wrote:

...I get 'debug assertion failed' inside ReleaseDc().

inline void CImage::ReleaseDC() const throw()
{
	HBITMAP hBitmap;

	ATLASSUME( m_hDC != NULL );

	m_nDCRefCount--;
	if( m_nDCRefCount == 0 )
	{
		hBitmap = HBITMAP( ::SelectObject( m_hDC, m_hOldBitmap ) );
		ATLASSERT( hBitmap == m_hBitmap );
		s_cache.ReleaseDC( m_hDC );
		m_hDC = NULL;
	}
}