|
I am trying to insert data into SQL Server 2008 table using vb.net. When I try to insert the data I get the error "OleDbException was unhandled" Incorrect syntax near 'Name'. The code line MyCommand.ExecuteNonQuery is highlighted when the error is thrown. I can't find anything wrong. Can someone please help me out? Here is my code:
Dim myConnection As New OleDb.OleDbConnection<br />
myConnection.ConnectionString = "Provider=SQLNCLI10;Server=S10615-10\SQLEXPRESS;Database=Assessment; Trusted_Connection=yes;"<br />
<br />
Dim myCommand As OleDb.OleDbCommand<br />
Dim strOleDb As String<br />
<br />
myConnection.Open()<br />
<br />
strOleDb = "INSERT INTO AssessmentPage1 (Client Name, DOB, Medical Records #, Medicaid Number, Consumer's Name, Medicaid #, Consumer's ID, Clinicians, Parents/Guardians Name, Address, Clinicians(1), Phone Numbers, Date or Referral, Date of Assessment, School Name/Address/Phone #, Identifying Information, Presenting Problems, Referral Information) VALUES(" & TextBox1.Text & "," & TextBox2.Text & "," & TextBox3.Text & "," & TextBox4.Text & "," & TextBox5.Text & "," & TextBox6.Text & "," & TextBox7.Text & "," & TextBox8.Text & "," & TextBox9.Text & "," & TextBox10.Text & "," & TextBox11.Text & "," & TextBox12.Text & "," & TextBox13.Text & "," & TextBox14.Text & "," & TextBox15.Text & "," & TextBox16.Text & "," & TextBox17.Text & "," & TextBox18.Text & ")"<br />
<br />
<br />
myCommand = New OleDb.OleDbCommand(strOleDb, myConnection)<br />
myCommand.ExecuteNonQuery()<br />
<br />
'Close and clean up objects<br />
myConnection.Close()<br />
myCommand.Dispose()<br />
myConnection.Dispose()
|
|
|
|
|
That looks terrible. You should:
1.
show code in PRE tags (not in CODE tags); better formatting, better readability.
2.
give real names to all your variables and controls; a bunch of numbered textboxes is awful.
3.
not directly stuff user input into an SQL statement. Google "SQL injection" and start using parameterized SQL.
[ADDED]
4.
when you don't use parameterized SQL, then stuff string and datetime literals in appropriate delimiters.
[/ADDED]
Furthermore, I discourage the use of whitespace and special characters in database field names.
|
|
|
|
|
Looks like your field names contain spaces? e.g.
fresh1207 wrote: Client Name
I think you need to enclose these in square brackets to be handled correctly...
[Client Name]
I think it is better to use underscore instead of space or to use no space and use TheLikesOfThis
|
|
|
|
|
Thank you guys for the help. I got rid of the previous error but now I am getting the error "Invalid column name for all of my text fields. But when I enter numbers into all of the textboxes the data inserts into the database perfectly. Any ideas?
|
|
|
|
|
|
I don't think the ' is valid for example Consumer's Name is not a valid column name in your MySQL table
Steve Jowett
-------------------------
Real programmers don't comment their code. If it was hard to write, it should be hard to read.
|
|
|
|
|
Dim myConnection As New SqlClient.SqlConnection
myConnection.ConnectionString = "Data Source=S10615-10\SQLEXPRESS;InitialCatalog=Assessment;Integrated Security=SSPI;"
Dim myCommand As SqlClient.SqlCommand
Dim strSQL As String
myConnection.Open()
strSQL = "INSERT INTO AssessmentPage1 (ClientName, DOB, MedicalRecords, MedicaidNumber, ConsumersName, MedicaidNumber1, ConsumersID, Clinicians, ParentsName, Address, Clinicians1, PhoneNumbers, DateofReferral, DateofAssessment, SchoolName, IdentifyingInformation, PresentingProblems, ReferralInformation) VALUES(" & TextBox1.Text & "," & TextBox2.Text & "," & TextBox3.Text & "," & TextBox4.Text & "," & TextBox5.Text & "," & TextBox6.Text & "," & TextBox7.Text & "," & TextBox8.Text & "," & TextBox9.Text & "," & TextBox10.Text & "," & TextBox11.Text & "," & TextBox12.Text & "," & TextBox13.Text & "," & TextBox14.Text & "," & TextBox15.Text & "," & TextBox16.Text & "," & TextBox17.Text & "," & TextBox18.Text & ")"
myCommand = New SqlClient.SqlCommand(strSQL, myConnection)
myCommand.ExecuteNonQuery()
myConnection.Close()
myCommand.Dispose()
myConnection.Dispose()
|
|
|
|
|
Your insert statement is not correct. For example:
VALUES(" & TextBox1.Text & "," & TextBox2.Text & "...
If the value of TextBox1.Text is A and TextBox2.Text is B, this will give:
VALUES(A, B...
So, the SQL query goes looking for a column called A and a column called B, which don't exist so the query fails.
What you want is:
VALUES('A', 'B'...
Note the apostrophes.
As other people have pointed out, string concatenation is simple and easy but it is better to use parameterised queries for a number of reasons, one of which is that you don't have to worry about where to put the apostrophes.
|
|
|
|
|
Experts,
I have an application which takes up the whole screen (15 inches) is there any way that if i take the app on to say a smaller screen can i get the program to find out the size and basically zoom out so the application fits nicely onto the screen? (Ihaven't yet tested the app on another screen yet but am guessing that it won't fit)
Thus the same with a 17+ screen i would want the app to zoom in slightly.
Can this be done or is there any surgestions?
Many thanks
Dan
|
|
|
|
|
It is nothing to do with screen size in inches. It has all to do with the resolution e.g. 1024x768, 1280x1024, 2560x1600 etc.etc.
In vb.net, you can obtain the current screen resolution from the My.Computer.Screen, it has various things under this depending on what exactly you want to know about the display properties.
Also, if you using Anchoring and Docking of your controls in your form, when you resize the form, they will stay relative to each other in terms of size and positioning.
Dave
Don't forget to rate messages!Find Me On: Web| Facebook| Twitter| LinkedInWaving? dave.m.auld[at]googlewave.com
modified on Sunday, March 21, 2010 9:34 AM
|
|
|
|
|
Is there any way that i can get the current screen size and alter it automatically, e.g the screen size i am currently working on is 1280 by 800 pixels. If for example someone uses this program has a reolution of 1024 by 768 pixels can i alter the screen size for my program and whe they exit the program the pixels are returned to what they were at the start??
How would i go about doing this?
|
|
|
|
|
Try this...
Public Function ScreenResolution() As String
Dim iWidth as integer, iHeight as Integer
iWidth = Screen.Width \ Screen.TwipsPerPixelX
iHeight = Screen.Height \ Screen.TwipsPerPixelY
ScreenResolution = iWidth & " X " & iHeight
End Function
or
Public Function ScreenResolution() As String
Dim intX As Integer = Screen.PrimaryScreen.Bounds.Width
Dim intY As Integer = Screen.PrimaryScreen.Bounds.Height
Return intX & " X " & intY
End Function
------------------------------------
I will never again mention that I was the poster of the One Millionth Lounge Post, nor that it was complete drivel. Dalek Dave
|
|
|
|
|
Don't see why I deserved a 1 for that, it is just a way of determining the screen res.
Useful if you are trying to implement on different monitors.
Hey ho, can't please some people.
------------------------------------
I will never again mention that I was the poster of the One Millionth Lounge Post, nor that it was complete drivel. Dalek Dave
|
|
|
|
|
I'm guessing it's because you didn't answer the question that he asked. He didn't ask how to determine the screen size, he asked how to set the screen size.
|
|
|
|
|
This is what happens when you try to help on a sunday afternoon with the footy on the telly.
Still, he shouldn't try to set the resolution.
------------------------------------
I will never again mention that I was the poster of the One Millionth Lounge Post, nor that it was complete drivel. Dalek Dave
|
|
|
|
|
Did you make a response and then edit it completely? My email notifications tell me so!
Do not think about changing the users resolution to fit your application, that is bad practice, and you would soon alienate your user base.
a) The users hardware may be restricted to a given resolution, e.g. on a laptop/netbook etc.
b) The user may have disabilities that require them to use a particular resolution.
So, don't think about it.
Design you application at a 'general' resolution, and as i say use docking/anchoring to keep the layout proportional regardless of the true resolution.
|
|
|
|
|
daveauld wrote: Did you make a response and then edit it completely?
Yes i think i did by accident. I was looking at this and posted a message through my phone. I then checked it out when i got home on my computer. I am now going to test the app on a bigger screen that i managed to borrow and think that what you said about the disabilites and hardware is a good point. I was just concerned that because my form in vb.net covers most of the 15 inch screen i didn't want it to look horrible on a 13 inch screen, thus the screen resolution option.
Thanks for the suggestions and sorry for the email notification.
|
|
|
|
|
I find the problem the other way round.
I design on my laptop (1920x1200) primarily and my home pc (2560x1600). As you can see these resolutions are are bigger than the average joe's. They look fine on these, but when i run them on things with smaller resolution, i always find they look terrible.
Nobody said it would be easy! I tend to start at an 800x600 or 1024x768 window size, depending on what i am doing, and see how they look.
|
|
|
|
|
I just tried the program on the 17 inch and it has done what i thought it would and it is basically to far "zoomed in" I just tried to dock the items however it messes up the order i have them in. What is the best way to dock items?
|
|
|
|
|
Getting a form to behave reasonably at different screen resolutions can be tricky, I use a combination of docked panels and anchored controls. Pick the control to dock as fill, usually a list control. You also need to be aware of the z order of the controls when docking (bring to front and send to back) as these will seriously screw with your layout.
Design for the smallest reasonable screens resolution, don't force full screen, let the user do that.
Never underestimate the power of human stupidity
RAH
|
|
|
|
|
I was hoping if anyone can help me with parallel port interfacing using Visual Basic, I have done some research on the internet and found a few good sites. However since I don't know much about Visual Basic I was wondering if anyone can help me get started with it. Firstly I am going to try to communicate through the parallel port to light up a few LEDs, anyone know how to do this? And also does anyone know how to start a normal 3v DC Motor using Visual Basic programming? Your help will be much appreciated
|
|
|
|
|
Hi,
PC ports are dealing with information, not power. They can't supply enough power to directly drive a motor or a lamp, a LED would be fine though.
Parallel port isn't extremely easy, as it is a shared resource, and .NET does not provide a class for it.
It is much easier to use a serial port; see the SerialPort class (since .NET 2.0). The typical serial port has 2 data lines, and some 6 control lines (some inputs, some outputs). The latter are the easiest to use, just hook up an LED (with appropriate series resistor, say 1000 ohm), and start setting the control outputs either high or low, using properties such as DtrEnable and RtsEnable.
BTW: there are some articles here on CP about the subject.
|
|
|
|
|
Hi,
so can the pc port not send a signal to the motor in the same way it does to the LEDs. In addition I have looked on the internet and found some articles which use DLL files such as inpout.dll so I don't think you need a class for it. As this is part of my project we have already built the hardware based on the parallel port so hopefully I can find some info on that. Is there anything you advise or suggest on interfacing parallel port? Also is there another way you would recommend to start up the motor using programming?
|
|
|
|
|
Every PC port can send a signal, none of them can provide hundreds of milliamps to drive anything. A LED is the maximum load you should apply; for heavier loads, you need electronics and/or relays. If you try nonetheless, you will probably fry your port. Beware of starting currents, they are even higher as the steady-state current. Furthermore, most motors will require a higher voltage, maybe 12 Volt or more. That too is beyond the capabilities of most ports.
Check the article referred to by Lloyd (which deals with LEDs!), and look for some others for higher voltages and currents.
|
|
|
|
|
Hi
Will I/O Ports with C# help? I know it's written in C#, but the code won't be too hard to convert to VB, as it will probably be mainly Windows API calls
|
|
|
|
|
General 
News 
Suggestion 
Question 
Bug 
Answer 
Joke 
Praise 
Rant 
Admin 
Submit an article or tip
