Click here to Skip to main content
15,891,607 members
Articles / Programming Languages / C#

Asynchronous Multi-threaded ObservableCollection

Rate me:
Please Sign up or sign in to vote.
4.85/5 (18 votes)
9 May 2014CPOL6 min read 124.7K   4.4K   112   40
An implementation of of a multi-threaded ObservableCollection.

Update 2014-04-18

  • Updated with .net Framework 4.5 (Now required)
  • Support some functionnalities to manage the collection as a recorder of changes (added/removed items): IsRecording, GetCopyOfRecordedItemsNew, GetCopyOfRecordedItemsRemoved
  • Support the new .net 4.5 interface: IReadOnlyList
  • Support usage of the collection as a stack with: Push and TryPop
  • Support usage of the collection as a queue with: Enqueue and TryDequeue (not optimized for queue but works)
  • Fixed some minors bugs

Update 2013-01-18 / Important note before usage...

My original implementation had some bugs that could happen in rare circumstances. But it could happen. In fact a real MT ObservableCollection (ObsCollMt) is impossible to my opinion due to this two interdependent points:

- To benefits of MT, you should not wait for any event handlers
- Not waiting for event handlers would compromise the expected behavior --> for example, a ui control implementation (grid) that would receive an event "ItemAdd" would expect the collection to be the same as it was before the event with and only the newly added item, which is not the case in MT.

Because of this. If hi performance is the target and you could live with two constraints : UI view of the obs coll could be readonly and duplicate of item is acceptable (I maintain a list and an observable collection at the ~ same time)... I would highly recommend the usage of: "CollectionMtWithAsyncObservableCollectionReadOnlyCopy" which I made it available here. Some explanation of the usage is available at the beginning of the class definition. I personnally use it at many places with no problem. I changed every usage of ObservableCollectionMt to CollectionMtWithAsyncObservableCollectionReadOnlyCopy. There is impacts but they are low. But don't forget to bind to the ObsColl property instead of binding directly to the instance.

The way CollectionMtWithAsyncObservableCollectionReadOnlyCopy works is modifying an internal list but synchronously add task to the queue of the dispatcher to duplicate the same action (add/remove) on the internal ObsColl. ObsColl will be updated whenever the dispatcher will reach the task. Both collection should be in sync when the dispatcher queue has processed every tasks (verified).

Introduction

ObservableCollections are mainly used in WPF to notify bound UI components of any changes. Those notifications usually translate to UI component updates, normally due to binding. UI component changes could only occur in a UI thread. Whenever you have lengthy work to do, you should do those jobs on a worker thread to improve the responsiveness of the UI. But sometimes, UI updates are very lengthy too. In order to decouple the worker thread from the UI thread, I created a collection which has in its internal 2 collections:

  • A list which could be accessed in a multithreaded context. Major properties/functions of a regular collection are supported. Major properties/functions are the same as a regular collection. Some functions that could potentially be thread unsafe are clearly indicated (start with 'Unsafe').
  • An ObservableCollection which should be used as read only from the UI. This collection is accessible through the ObsColl property. This ObsColl should be threaded as readonly otherwise it could lead to inconsitent data between both the list and the ObsColl.

Every modifications done to the ObsCollMt are done to the first internal list but are also queued to the dispatcher in the exact same order as they happen in the MT context (lock ensures this). The ObsColl should be an exact copy of the first internal list after UI would have processed all of its messages. But accessing the ObsCollMt would not suffer of waiting UI updates because of usage of Dispatcher.BeginInvoke.

Background

I found a few things but never exactly what I wanted. This is why I’m writing this article now. I took a look at: http://www.codeproject.com/KB/dotnet/MTObservableCollection.aspx (Paul Ortiz solution). And also http://powercollections.codeplex.com/. They weren’t what I expected. I also had some concerns about the first link (explained later).

Details

I decided to write my own multi-threaded ObservableCollection, but I got an unexpected major problem:

  • The major one was discovered after few attempts of making an ObservableCollection MT without dual copy of the data. I think, as explained at the beginning, to decouple UI from MT worker thread and keep data coherent, we should have dual list of the data, one for workers and one for UI. Also, the copy used for the UI should not be modify of if so, then is should be not used by any workers.

* An asynchronous update means, as a difference from the Paul Ortiz solution, that the worker thread does not have to wait on the UI to update before continuing to process other things. My solution uses Dispatcher.BeginInvoke instead of Disptacher.Invoke.

I also had a few other problems in testing when I realised that CollectionView had one major constraint and a bug. CollectionView does not support range modification. CollectionView also has a bug in it because it does not use a “using” block around an iterator to ensure that Dispose is called (or use a foreach loop which is fine too). (See: https://connect.microsoft.com/VisualStudio/feedback/details/513500/collectionview-does-not-dispose-sourcecollection-enumerator-synchronously for those who have access.)

This is a list of many problems I had with the actual implementation of the ObservableCollection:

  1. Function Clear does not notify
  2. Unable to override critical functions
  3. No multi-threaded safe access
  4. Needs possibility to get blocking and unblocking iterators
  5. Possibility to get either “blocking” or “list copy” iterator

Solution

I then decided to program my Swiss army knife collection. In fact, it is one collection for the multi-threaded, and a regular ObservableCollection. When accessing the ObsCollMt, you modify a regular list (with MT safe lock) and add notification to update the regular ObsColl in the UI thread.

The way I did it was a complete writing of the new class “ CollectionMtWithAsyncObservableReadOnlyCopy” not inheriting from Collection, with a “List<T>” member containing every item. The class supports most interface the standard ObservableCollection supports.

I have included a sample with threading access to show the main usage.

Do not forget to bind to "ObsColl" property instead of bind directly to the collection itself.

Hope you will like it.

History

  • April, 28, 2014, Made some corrections in text.
  • June, 03, 2013, Made a requested correction about verification of "Application.Current" not being null. Removed old source code which is a little bugged to remove confusion and to ensure to only use the new version with copy.
  • Mai, 31, 2013, Put code in a little lib, added a little test project, make project for VS2010 instead of VS 2012 (easier for more people to try)
  • Jan 18, 2013: Added information about "CollectionMtWithAsyncObservableCollectionReadOnlyCopy"
  • Apr 28, 2011: Updated source code. Updated the Introduction section.
  • Jun 23, 2011: Updated source code.

License

This article, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)


Written By
Software Developer IREQ - Hydro-Quebec
Canada Canada
Hi,

I'm a french Canadian software developer.
Work at Hydro-Quebec / IREQ.
Live in Sainte-Julie, Quebec, Canada (South shore of Montreal)

WebPage: http://www.ericouellet.com
GMail: ericouellet2

Salut!

Comments and Discussions

 
GeneralRe: I do it this way (may be of interest) Pin
Eric Ouellet18-Apr-11 9:31
professionalEric Ouellet18-Apr-11 9:31 
GeneralRe: I do it this way (may be of interest) Pin
Sacha Barber18-Apr-11 9:37
Sacha Barber18-Apr-11 9:37 
GeneralRe: I do it this way (may be of interest) Pin
Eric Ouellet21-Apr-11 11:41
professionalEric Ouellet21-Apr-11 11:41 
GeneralRe: I do it this way (may be of interest) Pin
Sacha Barber21-Apr-11 20:35
Sacha Barber21-Apr-11 20:35 
GeneralRe: I do it this way (may be of interest) Pin
KenBeckett30-Oct-11 16:44
KenBeckett30-Oct-11 16:44 
GeneralRe: I do it this way (may be of interest) Pin
Sacha Barber30-Oct-11 21:34
Sacha Barber30-Oct-11 21:34 
GeneralRe: I do it this way (may be of interest) Pin
Eric Ouellet31-Oct-11 2:53
professionalEric Ouellet31-Oct-11 2:53 
GeneralRe: I do it this way (may be of interest) Pin
KenBeckett31-Oct-11 11:47
KenBeckett31-Oct-11 11:47 
I specifically addressed Sasha regarding his posted code, not yours. I just wanted to help by letting people know the dangers of that method, since I had problems with it myself.

I looked at your sources, and you indeed seem to be making all changes on the UI thread, so that's good. However, you are using BeginInvokes, which is dangerous because of the queuing. So, it's probably OK as you say if the worker thread only does writes, but could easily fail if it ever tries to read back or remove any recently added items. That being the case, I guess I don't really understand all of the locks that you have in there... they don't seem necessary to me. The code on the page I posted the link to works just fine (with my posted changes) and is very simple compared to yours. In either case, BeginInvoke can be used for better performance if the background thread only writes, or Invoke otherwise. It appears you were trying to make the collection safe for changes by multiple threads - perhaps before marshalling all changes to the UI thread? But, since all changes are made on the UI thread, there is no reason to lock, and if the worker thread makes changes, the locks aren't really going to help much (there will be plenty of problems).

The real mess with threading and collections is that there is NO SUCH THING as a "thread safe collection". Few programmers seem to understand that properly. It's all about how the code using the collection is written, which is why some people argue against adding thread safety to collections at all - just putting locks in the code that uses them. For example, any code can request the count of a collection, then iterate through the items using that count, or otherwise be written such that it is vulnerable to changes, and no amount of locking inside the collection class will ever prevent problems when multiple threads are involved. This is the case with WPF binding to ObservableCollection{T} without doing any locking while updating the UI - which is why the only real "fix" is to make sure that ALL modifications to the collection occur on the UI thread. It's very far from the ideal solution for using multiple threads with a collection, but there is no alternative in this specific case.
GeneralRe: I do it this way (may be of interest) Pin
Eric Ouellet1-Nov-11 3:30
professionalEric Ouellet1-Nov-11 3:30 

General General    News News    Suggestion Suggestion    Question Question    Bug Bug    Answer Answer    Joke Joke    Praise Praise    Rant Rant    Admin Admin   

Use Ctrl+Left/Right to switch messages, Ctrl+Up/Down to switch threads, Ctrl+Shift+Left/Right to switch pages.