C / C++ / MFC

6-May-12 6:32

Hi,

As some of you may already be aware from some of my post I am a MainFrame Assembler programmer trying to get into the Windows MFC platform

This presented me with a number of challanges to name two

1) Understanding Object Oriented as opposed to procedural coding

2) thinking of text as fonts instead of bytes oriented characters

Well it seems that RichEdit interface deals with characters e.g ( SetSel API) instead

of fonts

So Here is my problem listed below is the text I am displaying in a RichEdit window

  000000                00000 004A4    10 TESTA CSECT
                                      11 TESTA AMODE 31
                                      12 TESTA RMODE ANY
                                      13         YREGS
0                      00000          15+R0       EQU   0                                                        01-YREGS
                       00001          16+R1       EQU   1                                                        01-YREGS
                       00002          17+R2       EQU   2                                                        01-YREGS
                       00003          18+R3       EQU   3                                                        01-YREGS
                       00004          19+R4       EQU   4                                                        01-YREGS
                       00005          20+R5       EQU   5                                                        01-YREGS
                       00006          21+R6       EQU   6                                                        01-YREGS
                       00007          22+R7       EQU   7                                                        01-YREGS
                       00008          23+R8       EQU   8                                                        01-YREGS
                       00009          24+R9       EQU   9                                                        01-YREGS
                       0000A          25+R10      EQU   10                                                       01-YREGS
                       0000B          26+R11      EQU   11                                                       01-YREGS
                       0000C          27+R12      EQU   12                                                       01-YREGS
                       0000D          28+R13      EQU   13                                                       01-YREGS
                       0000E          29+R14      EQU   14                                                       01-YREGS
                       0000F          30+R15      EQU   15                                                       01-YREGS
0                      00007          32 XLNK    EQU    R7
 _ 000000                               33 ARNDCOPY DS    0H
 _ 000000 90EC D00C            0000C    34         STM    R14,R12,12(R13)
 _ 000004 18CF                          35         LR     R12,R15
                  R:C  00000          36         USING  TESTA,R12
                                      37 *       HERCDIE LINKAGE=SVC
_ 000006 18ED                          38         LR     R14,R13
_ 000008 41D0 C314            00314    39         LA     R13,SAVEAREA
_ 00000C 50E0 C318            00318    40         ST     R14,SAVEAREA+4
_ 000010 50C0 C38C            0038C    41          ST    R12,WORKFLD
_ 000014 F384 C391 C38C 00391 0038C    42          UNPK  WORFLD1,WORKFLD(5)
_ 00001A DC08 C391 C39A 00391 0039A    43          TR    WORFLD1,TR_TBL
                                      44          LOAD  EP=TESTB
_ 000020                               46+         CNOP  0,4                                             @YA29363 01-LOAD
_ 000020 4DF0 C02C            0002C    47+         BAS   15,LOAD2_0002      BRANCH AROUND CONSTANT(S)             01-LOAD
 000024                               48+LD2_0002    DS 0H                                                       01-LOAD
 000024 E3C5E2E3C2404040              49+LE2_0002    DC CL8'TESTB'         ENTRY POINT NAME                      01-LOAD
 00002C                               50+LOAD2_0002    DS 0H                                                     01-LOAD
_ 00002C 4100 F000            00000    51+         LA    0,LE2_0002-LD2_0002(,15)         ADDR OF PARAMETER       01-LOAD
_ 000030 1B11                          52+         SR    1,1                SHOW NO DCB PRESENT                   01-LOAD
_ 000032 0A08                          53+         SVC   8                                                        01-LOAD
_ 000034 D207 C37B C391 0037B 00391    54          MVC   STARTS,WORFLD1
                                      55 *        WTOR  TEXT=(START_ADDR,REPLY,1,ECB_REPLY)
                                      56 *        WAIT  ECB=ECB_REPLY
1                                                                                                               Page    4

C++

I am trying to highlight the first Mainframe executable line which is the line with 
the following text    STM  R14,R12,12(R13)

Here is the code I use to that 
	// LOOK for the irst executable instruction 
SetSel(0,0);         // start at the beginig

FINDTEXTEX ft;
ft.chrg.cpMin = 0;
ft.chrg.cpMax = -1;
ft.lpstrText = (LPSTR) "_ ";

long n = FindText(FR_DOWN|FR_MATCHCASE | FR_WHOLEWORD, &ft);

long l = LineLength(n);

From my understanding all return codes from the richedit api 0 character based
however When step thru the code of the FindText api the return code is some huge number X'830' decimal 2096 this what is in the AX register which typically is where the return code is

It seems obvious to me that the first under score is about 150 characters away ( I didn't do a exact count ) but it is in that range

Anyway if someone could explain I would apprecaite it

enhzflep6-May-12 7:21

6-May-12 7:21

Howdy again, I just cut and past the asm listing into notepad++ to find the location of the first "_ " - in my case it was character 2258 - 0x8D2.

Don't know where the extra 162 extra bytes come from, though they seem likely to be unimportant to the discussion at this point.

Hey, what sort of machine is that ASM for? I'm curious, not recognizing the opcodes as belonging to any of the variants I've coded for.

ForNow6-May-12 9:07

Re: CRichEditCtrl interface question [modified]

6-May-12 9:07

MainFrame Assembler as I said I am MainFrame Assembler programmer

So if the the first "_ " is 2258 from the Richeditctrl

then the following code should color the line with the STM red

C++

CHARFORMAT cfm;

long n = FindText(FR_DOWN|FR_MATCHCASE | FR_WHOLEWORD, &ft);

long l = LineLength(n);

   SetSel(n,l);

    cfm.cbSize = sizeof(CHARFORMAT);
    cf.dwMask = CFM_COLOR;
    cf.crTextColor  = RGB(255,0,0);

      SetDefaultCharFormat(cfm);

enhzflep6-May-12 10:14

6-May-12 10:14

Indeed. I was actually thinking more along the lines of what sort of mainframe? e.g US Military, CRAY, and a couple of other whose name escapes me just now. I played with DEC Alphas a million years ago, MIPS before the orig PlayStation implemented it, Had a couple of old SuperSparc's sitting in cases in the CS building in uni. Perhaps I was simply too inarticulate. No matter. Sorry for my intrusiveness. Blush | :O

Yeah, one would certainly think that your code would colour the line red - though I've been spectacularly unsuccessful at changing the text colour using MFC. I can make the line bold, underlined or whatever - but I can't color the text. The same task I have easily achieved in native code in the past and cant see any special colour handling functions that seem relevant. I'm more than a little perplexed just now. Here's the (hacked together)code I have for Bolding the target line.

Also, for some reason I had to remove the other flags you'd used in FindText. It wouldn't return a valid hit for the text "_ " unless I did so, too tired to read help docs just at the moment, no doubt such limitations are mentioned in there somewhere.

~~Of course, if you change the "or equals" to "xor equals" you can toggle the state, rather than just setting it.~~
Oops! I mean, if you xor the dwEffects with CF_BOLD, instead of setting it - you'll toggle the state of the char formatting.

Also, you should be using SetSelectionCharFormat, SetDefaultCharFormat acts on the whole control, not just the selection.

C++

void CmfcRichEditDlg::OnBnClickedButton3()
{
    // TODO: Add your control notification handler code here
    FINDTEXTEX ft;
    CHARFORMAT cfm;

    ft.chrg.cpMin = 0;
    ft.chrg.cpMax = -1;
    ft.lpstrText = "_ ";

    long n = m_RichEdit.FindText(FR_DOWN, &amp;ft);
    long l = m_RichEdit.LineLength(n);

    m_RichEdit.SetSel(n,l);

    m_RichEdit.GetSelectionCharFormat(cfm);

    cfm.dwMask |= CFM_BOLD;
    cfm.dwEffects = CFE_BOLD;

    m_RichEdit.SetSelectionCharFormat(cfm);
}

modified 6-May-12 16:32pm.

enhzflep6-May-12 11:01

6-May-12 11:01

Thought I'd add another reply so that you get a notification.

Just solved the question of why no colouring?

I tried it as a release-mode app and voila! Tried again as a debug, Nada!

Anyways, here's a function that will flip the line back and forth between
std-weight black text & bold red text.

C++

void CmfcRichEditDlg::OnBnClickedButton3()
{
	// TODO: Add your control notification handler code here
	FINDTEXTEX ft;
	CHARFORMAT cfm;
	
	ft.chrg.cpMin = 0;
	ft.chrg.cpMax = -1;
	ft.lpstrText = "_ ";

	long n = m_RichEdit.FindText(FR_DOWN, &ft);
	long l = m_RichEdit.LineLength(n);

	m_RichEdit.SetSel(n,l);

	m_RichEdit.GetSelectionCharFormat(cfm);
	cfm.cbSize = sizeof(cfm);
	cfm.dwMask = CFM_BOLD;
	cfm.dwEffects ^= CFE_BOLD;
 	m_RichEdit.SetSelectionCharFormat(cfm);


	cfm.cbSize = sizeof(cfm);
	if (cfm.crTextColor == RGB(0,0,0))
		cfm.crTextColor = RGB(200,0,0);
	else
		cfm.crTextColor = RGB(0,0,0);

	cfm.dwMask = CFM_COLOR;
	cfm.dwEffects = NULL;
	m_RichEdit.SetSelectionCharFormat(cfm);
}

ForNow7-May-12 7:24

CRichEditCtrl FindText problem

7-May-12 7:24

thnaks

tried one minor modification

after

long l = m_RichEdit.LineLength(n);

l = l + n;

ForNow5-May-12 20:24

Re: CRichEditCtrl FindText problem

5-May-12 20:24

Hi,

I have a text file that at certain lines I insert a "_" as the first character

Here is a example

_ 000000 90EC D00C 0000C 34 STM R14,R12,12(R13)

This works fine ..

I would like to highlight the first such line in Bold Red to do this i use the FindText function however for some reason this return a -1

C++

CHARFORMAT cfm;


   SetSel(0,-1);                       // make the selection everything

   cfm.cbSize = sizeof(CHARFORMAT);
   cfm.dwMask = CFM_FACE | CFM_SIZE | CFM_BOLD |

   CFM_ITALIC | CFM_UNDERLINE | CFM_STRIKEOUT | CFM_PROTECTED;
   cfm.dwEffects = 0;
   cfm.yHeight = 240;
   ::lstrcpy(cfm.szFaceName, "Times New Roman");

   SetDefaultCharFormat(cfm);

// LOOK for the first executable instruction
SetSel(0,0); // start at the beginig

FINDTEXTEX ft;
ft.chrg.cpMin = 0;
ft.chrg.cpMax = -1;
ft.lpstrText = (LPSTR) "_ ";

long n = FindText(FR_MATCHCASE|FR_WHOLEWORD, &ft);

C++

long l = LineLength(n);

   SetSel(n,l);

    cfm.cbSize = sizeof(CHARFORMAT);
    cf.dwMask = CFM_COLOR;
    cf.crTextColor  = RGB(255,0,0);

      SetDefaultCharFormat(cfm);

       SetSel(0,0);

enhzflep5-May-12 21:44

Re: CRichEditCtrl FindText problem

5-May-12 21:44

It's a very simple fix. I must have spent 1/2 an hour looking over it until it hit me - you're missing a flag from the call to FindText.

C++

long n = FindText(FR_MATCHCASE|FR_WHOLEWORD, &ft);

C++

long n = FindText(FR_DOWN | FR_MATCHCASE|FR_WHOLEWORD, &ft);

ForNow6-May-12 5:41

Re: CRichEditCtrl FindText problem

6-May-12 5:41

Thanks worked howeever the return code from FindText was a big number X'00000830'

This is what I observed in the AX register which is always the return code from a API

I thought the return code would be the zero based character which is alot smaller

if you have any clues Please Let me know

I am going to Start another thread reagarding this question as may be I am

misunderstanding the concept

thanks

enhzflep6-May-12 5:54

Looping when you need user input

6-May-12 5:54

That's okay.

It's a bit hard to tell without seeing the data that you've got in the control. From your number X'00000830', I don't know if you mean 830 or 0x830.

In either case, it's indicating that the (0x?)830th character is the start of the sequence you're searching for.

Assuming (say) 20 chars per line & 830 decimal, this would correspond to the 10th char of the 42nd line in the control.

abollmeyer5-May-12 19:25

abollmeyer

5-May-12 19:25

Hello,

I am working on a math program for my daughter in C# using a Form. Here is the gist of my program:

1) Create random numbers.
2) Add numbers together. Compare to user input.
3) Tell user if question was answered correctly.

I can get the program to cycle through once successfully. I can't figure out how to loop through a series of 50 questions though. When I've tried to loop it, I either end up on question 50 or suffer through an infinite loop.

If anyone could point me in the right direction, I would greatly appreciate it. Also, this is the first time I've posted in a programming forum so I've left out any pertinent info please let me know!!!

using System;
using System.Collections.Generic;
using System.ComponentModel;
using System.Data;
using System.Drawing;
using System.Linq;
using System.Text;
using System.Windows.Forms;

namespace Math
{
    public partial class NewMathForm : Form
    {
        public NewMathForm()
        {
            InitializeComponent();
            int questionCounter = 1;
            
            addition();
        }


        private void sumTextBox_KeyPress(object sender, KeyPressEventArgs e)
        {
            sumTextBox.SelectionStart = 0;
        }

        public void shuffle(ref int[] array)
        {
            Random rng = new Random();       // i.e., java.util.Random. 
            int count = array.Length;        // The number of items left to shuffle (loop invariant). 

            while (count > 1)
            {
                int k = rng.Next(count);     // 0 <= k < n. 
                count--;                     // count is now the last pertinent index; 
                int temp = array[count];     // swap array[n] with array[k] (does nothing if k == n). 
                array[count] = array[k];
                array[k] = temp;
            }
        }

        private void parseNumbers(ref int[] array)
        {
            double addend1 = 0;
            double addend2 = 0;

            string number;

            char num1;
            char num2;

            for (int count = 0; count < 50; count++)
            {
                number = array[count].ToString();
                num1 = number[0];

                int length = number.Length;

                if (length < 2)
                {
                    char zero = '0';
                    num2 = zero;
                }

                else
                    num2 = number[1];

                addend1 = System.Char.GetNumericValue(num1);
                addend2 = System.Char.GetNumericValue(num2);

                array[count] = Convert.ToInt32(addend1);
                count++;
                array[count] = Convert.ToInt32(addend2);
            }
        }

        private void addition()
        {
            int[] numbers = new int[100];
            int counter = 0;
            int questionCounter = 1;
            int numberOfQuestions = 50;

            // Read numbers 0 to 99 into an array.
            for (counter = 0; counter < 100; counter++)
            {
                numbers[counter] = counter;
            }

            // Randomly shuffle the array of numbers
            shuffle(ref numbers);

            // Parse the first 50 numbers into tens and ones digits, then use those numbers for the problem.
            parseNumbers(ref numbers);

            //int counter = 0;
            addendOneLabel.Text = numbers[questionCounter].ToString();
            addendTwoLabel.Text = numbers[questionCounter + 1].ToString();
        }

        private void checkAnswerButton_Click(object sender, EventArgs e)
        {
            checkAnswer();
        }

        public void checkAnswer()
        {
            int sum = Convert.ToInt32(sumTextBox.Text);
            int number1 = Convert.ToInt32(addendOneLabel.Text);
            int number2 = Convert.ToInt32(addendTwoLabel.Text);
            int answer = number1 + number2;

            if (answer == sum)
                correctAnswer();
            else
                incorrectAnswer(answer);          
        }  

        private void correctAnswer ()
        {
            MessageBox.Show ("That is correct!");
        }

        private void incorrectAnswer (int sum)
        {
            MessageBox.Show ("That is incorrect! The correct answer is " + sum + ".");
        }

    }
}

Code-o-mat5-May-12 23:08

Code-o-mat

5-May-12 23:08

First of all, you got the wrong forum, this message board is for C++/MFC related topics, you should have asked this on the C# dedicated message board.
Secondly, i am not sure i understand your problem, but as much as i can gather, you have a "check answer" button, so, why don't you define a counter of type e.g. int in the class and increase it every time the button is pressed, each time generating a new "problem" to solve, once it reaches 50, you're (or your doughter for that matter) is done. Am i misunderstanding you?

> The problem with computers is that they do what you tell them to do and not what you want them to do. <
> If it doesn't matter, it's antimatter.<

abollmeyer6-May-12 3:37

abollmeyer

6-May-12 3:37

Sorry, I saw the title C/C++/MFC and assumed it was also for C programming. You are correct in what I am trying to accomplish. The 'checkAnswer' button should tell the user if she is right or wrong, and then cycle to the next question. The problem I am having is figuring out where (and how) to implement the loop. It's not in the code provided, as I was testing before posting, but I previously had it in the addition() function. What I can't see how to do is how do I implement a return value to increase the counter when the 'checkAnswer' button is pressed?

If I increment the loop in the addition() function, then I end up on question 50 and only 1 question gets asked. I've thought, well just provide a bool flag in the 'checkAnswer' button event handler, and only increment the loop counter if that flag is true. But I can't figure out how to return that value. Or am I going about this the wrong way?

enhzflep6-May-12 4:15

6-May-12 4:15

Not really able to acertain your level of programming experience, though it does sound like perhaps you're coming from a background in DOS or console app programming - not the event driven model that's used in windows.

I say that in reference to your mention of loops.

For this kind of a question, a loop in the classic sense is not appropriate. Think of your code as a state-machine. Every time something happens on the form, windows calls the appropriate function in your code and you handle it. Rather than looping, you should increment a counter that indicates the current question. If you then use this counter in all of your functions that display num1 & num2, or check for the correct answer you're done.

Here's something I just had a play with. It should be enough to demonstrate the ideas you need.

using System;
using System.Collections.Generic;
using System.ComponentModel;
using System.Data;
using System.Drawing;
using System.Linq;
using System.Text;
using System.Windows.Forms;

namespace mathProj
{
    public partial class Form1 : Form
    {
        private const int maxQuestions = 50;
        private int curQuestion;
        private int[] num1 = new int[maxQuestions];
        private int[] num2 = new int[maxQuestions];

        public Form1()
        {
            InitializeComponent();
        }

        private void button1_Click(object sender, EventArgs e)
        {
            bool isCorrect;
            textBox1.Text = curQuestion.ToString();
            if (curQuestion < maxQuestions-1)
                curQuestion++;
            else
            {
                initNumbers();
                curQuestion = 0;
            }
            setNumberLabels();
        }

        private void Form1_Load(object sender, EventArgs e)
        {
            initNumbers();
            setNumberLabels();
        }

        private void setNumberLabels()
        {
            lblNum1.Text = num1[curQuestion].ToString();
            lblNum2.Text = num2[curQuestion].ToString();
        }

        private void initNumbers()
        {
            curQuestion = 0;
            int i;
            for (i = 0; i < maxQuestions; i++)
            {
                num1[i] = i*2;
                num2[i] = i*3;
            }
        }
    }
}

abollmeyer6-May-12 7:32

abollmeyer

6-May-12 7:32

Hi and thanks for the help. My level of programming experience goes as far as C++ console programming classes in high school and college (for a whopping total of 2). C# seems more intuitive to me, and I have picked up several books to help me learn. I have written several basic programs for my own use, I just got stumped here. I guess looking at it for hours on end caused me to take too many wrong turns.

Of course you are right, enhzflep. I should have concentrated more on what would happen when I pressed the button instead of how to feedback that input to the main program. After integrating your code with mine, and after I finish making a few last tweaks to suit my needs, it will work great!

Thank you again.

For anyone else:

using System;
using System.Collections.Generic;
using System.ComponentModel;
using System.Data;
using System.Drawing;
using System.Linq;
using System.Text;
using System.Windows.Forms;

namespace Math
{
    public partial class SimpleAdditionMathForm : Form
    {
        private const int maxQuestions = 50;
        private int currentQuestion;
        private int arrayCounter;
        int[] numbers = new int[100];
        int timerRecord;

        public SimpleAdditionMathForm()
        {
            InitializeComponent();
            questionTimer.Start ();
            initNumbers();
            setNumberLabels();          
        }

        private void initNumbers()
        {
            timerRecord = 31;

            currentQuestion = 1;

            for (int counter = 0; counter < 100; counter++)
            {
                numbers[counter] = counter;
            }

            shuffle(numbers);

            parseNumbers(numbers);
        }

        private void setNumberLabels()
        {
            addendOneLabel.Text = numbers[arrayCounter].ToString();
            addendTwoLabel.Text = numbers[arrayCounter + 1].ToString();

            questionTimer.Start();
        }

        public void shuffle(int[] array)
        {
            Random rng = new Random();

            // The number of items left to shuffle (loop invariant).
            int count = array.Length;         

            while (count > 1)
            {
                // 0 <= k < n.
                int k = rng.Next(count);           
                count--;
                // count is now the last pertinent index;
                int temp = array[count];
                // swap array[n] with array[k] (does nothing if k == n).
                array[count] = array[k];
                array[k] = temp;
            }
        }

        private void parseNumbers(int[] array)
        {
            double addend1 = 0;
            double addend2 = 0;

            string number;

            char num1;
            char num2;

            for (int count = 0; count < 100; count++)
            {
                number = array[count].ToString();
                num1 = number[0];

                int length = number.Length;

                if (length < 2)
                {
                    char zero = '0';
                    num2 = zero;
                }

                else
                    num2 = number[1];

                addend1 = System.Char.GetNumericValue(num1);
                addend2 = System.Char.GetNumericValue(num2);

                array[count] = Convert.ToInt32(addend1);
                count++;
                array[count] = Convert.ToInt32(addend2);
            }
        }

        private void checkAnswerButton_Click(object sender, EventArgs e)
        {
            questionTimer.Stop();

            timerRecord = 31;

            if (currentQuestion < maxQuestions - 1)
            {
                int sum; 

                if (sumTextBox.Text != "")
                {
                    sum = Convert.ToInt32(sumTextBox.Text);
                }
                else
                    sum = 0;

                int number1 = Convert.ToInt32(addendOneLabel.Text);
                int number2 = Convert.ToInt32(addendTwoLabel.Text);
                int answer = number1 + number2;

                if (answer == sum)
                    correctAnswer();
                else
                    incorrectAnswer(answer);

                sumTextBox.Text = "";

                currentQuestion++;

                arrayCounter = arrayCounter + 2;

                questionCounterLabel.Text = currentQuestion.ToString();

                sumTextBox.Focus();
            }

            else
            {
                MessageBox.Show("You have completed all 50 questions!");
                this.Close();
            }

            setNumberLabels();
        }

        private void correctAnswer ()
        {
            MessageBox.Show ("That is correct!");
        }

        private void incorrectAnswer (int sum)
        {
            MessageBox.Show ("That is incorrect! The correct answer is " + sum + ".");
        }

        private void questionTimer_Tick(object sender, EventArgs e)
        {
            timerRecord--;
            tickLabel.Text = timerRecord.ToString();
        }

        private void sumTextBox_KeyPress(object sender, KeyPressEventArgs e)
        {

        }
    }
}

enhzflep6-May-12 7:40

6-May-12 7:40

That's a real pleasure abollmeyer. To be honest, you had me with:

abollmeyer wrote:
Hello,

I am working on a math program for my daughter in C#

It was absolutely impossible to avoid trying help. Thumbs Up | :thumbsup:

Simon.