|
Now, I'm no JavaScript guru, but...
if ((nameArray[i] != "") && (codeArray[i] != ""))
Here I would also add a jQuery.trim() on nameArray[i]. You may have values that are simply spaces, and checking for empty string will return false
Also, in the for you could dump nameCount and codeCount. Maybe you didn't post the full function, but nameCount is used only for upper bound limit (which could be replaced with parseInt($("._name_Field").length)), and codeCount isn't used at all.
Other than that, seems to be fine. Also, it's good that you are commenting your code. I've been through some situations in my (relatively short) career when I banged my hand on a wall for not commenting my code a few months earlier.
And if it works for you the way you want it, it's all good. I may get burned for this, but I have a saying:
Make it work. Then do it better
Wrapping it all up, the final function would be:
var elements = [];
var nameArray = [];
$("._name_Field").each(function () { nameArray.push($(this).val()) });
var codeArray = [];
$("._code_Field").each(function () { codeArray.push($(this).val()) });
var jdx = 0;
for (i = 0; i <= parseInt($("._name_Field").length) - 1; i++) {
if ($.trim(nameArray[i]) != ""
&& $.trim(codeArray[i]) != "") {
elements[jdx] = [];
elements[jdx]["name"] = nameArray[i];
elements[jdx]["code"] = codeArray[i].toUpperCase();
jdx++;
}
}
Full-fledged Java/.NET lover, full-fledged PHP hater.
Full-fledged Google/Microsoft lover, full-fledged Apple hater.
Full-fledged Skype lover, full-fledged YM hater.
|
|
|
|
|
Just like in c++, you have to conserve resources, so I dumped the namecount, I thought about it, just didn't do it.
Glad the code is readable, know anything about consuming the eArray in a Web Service?, I posted it in the asp.net disscussion
var nameArray = [];
$("._name_Field").each(function () { nameArray.push($(this).val()) });
var codeArray = [];
$("._code_Field").each(function () { codeArray.push($(this).val()) });
var jdx = 0
for (i = 0; i <= parseInt($("._name_Field").length) - 1; i++) {
if ((nameArray[i].trim() != "") && (codeArray[i].trim() != "")) {
elements[jdx] = [];
elements[jdx]["name"] = nameArray[i].trim();
elements[jdx]["code"] = codeArray[i].trim().toUpperCase();
jdx++;
}
}
var eArray = "";
for (e = 0; e <= elements.length - 1; e++) {
eArray = eArray + "{\"name\" : \"" + elements[e].name + "\", \"code\" : \"" + elements[e].code + "\"}";
if (e <= elements.length - 2) { eArray = eArray + "," };
}
var send_Data =
"{" +
"\"template_Name\" : \"" + template_Name + "\", " +
"\"template_Array\" : [" + eArray + "]" +
"}";
alert(send_Data);
$.ajax({
type: "POST",
contentType: "application/json; charset=utf-8",
url: "productEditor.asmx/create_DynamicCart_Template",
data: send_Data,
dataType: "json",
error: function (xhr, status, error) {
exitCode = 2;
alert(xhr.responseText);
},
success: function (responseText) {
try {
eval('(' + responseText.d + ')');
}
catch (err) {
}
alert(responseText.d);
var objB = jQuery.parseJSON(responseText.d);
exitCode = objB.template_ExitCode;
}
});
});
|
|
|
|
|
jkirkerx wrote: know anything about consuming the eArray in a Web Service?,
I don't have that much experience with json in .NET, as my development work in it has been mostly desktop and DB.
For the few occasions I've needed json, I've used JSON.NET[^] and was ok with it, did its job well. Now, if other members know of better libraries than this, I believe all suggestions are welcome.
Full-fledged Java/.NET lover, full-fledged PHP hater.
Full-fledged Google/Microsoft lover, full-fledged Apple hater.
Full-fledged Skype lover, full-fledged YM hater.
|
|
|
|
|
Your other solution worked. You could also have done $($elements[i]).find("_name_Field").val() because the jquery indexer returns the dom element not the jquery wrapper to the dom element.
|
|
|
|
|
Oh this is getting exciting now!
var name = $elements[i].find("_name_Field").val(); <-Bombs here
So the first one worked?, yes I know it was working, I just couldn't figure out how to access the name. And I couldn't find any information on it that night, and just wanted to move forward.
I tried many different ways using alert as a test, thought name[i].val() would do the trick. I have no clue what the structure of name looks like. I sure would like know, I thought my first post was clean and simple.
Oh, I saw the hammer next to your name, and knew you were one of the big guns here on the CJ.
Any of the wisdom you choose to share with me would be appreciated. Thanks for reading my post!
|
|
|
|
|
You were close, but not quite there.
var name = $($elements[i]).find("_name_Field").val();
Notice the extra $() around the element you are accessing. That's because $elements[i] is a raw DOM object not a jQuery object and doesn't have a find method.
jkirkerx wrote: Oh, I saw the hammer next to your name, and knew you were one of the big guns here on the CJ.
Thanks for the flattery, but I just did a favor for Chris about 10 years ago to get that little icon, nothing really special there.
|
|
|
|
|
Oh I get it now. I was thinking about the wrapping it again, but was more focused on the name.
Thanks, That was still big gun help there!
|
|
|
|
|
Well I'm getting bolder here with Javascript.
This eludes me, I can create a element and set the value no problem, I can get the value via Jquery no problem if the element is pre-dom, but if I create an element with createElement, I was thinking since my element is new in the DOM, it would be easy to retrieve the value via function. I'm missing something really basic here in principal, and this is the first time I have created a textbox this way.
It's written to be compatible with IE and Firefox browsers at the same time, in a single version.
I keep getting 'undefined' as the value of the code textbox. The function works, I just can't the appendCode from the textbox.
I've tried 3 versions so far. Just thought I'd ask, tomorrow I will have a fresh hat on to think with.
The Element
var txt_Element_L1_Code_Field = document.createElement("input");
txt_Element_L1_Code_Field.id = "_txt_Element_L1_Code_Field_" + dynamicCart_Element1.idx;
txt_Element_L1_Code_Field.type = "text";
txt_Element_L1_Code_Field.style.paddingLeft = "5px";
txt_Element_L1_Code_Field.style.width = "90%";
txt_Element_L1_Code_Field.style.backgroundColor = "rgb(255,255,255)";
td_Element_L1_Code_Field.appendChild(txt_Element_L1_Code_Field);
Version 1 function that is binded
txt_Element_L1_Code_Field.onkeydown = function () {
var appendCode;
if (txt_Element_L1_Code_Field.innerText != "") {
appendCode = txt_Element_L1_Code_Field.value;
}
span_Element_L1_CPN_Field.innerText = appendCode;
span_Element_L1_CPN_Field.innerHTML = appendCode;
};
Version 2: function that is binded
txt_Element_L1_Code_Field.onkeydown = function () {
var appendCode;
if (txt_Element_L1_Code_Field.innerText != "") {
appendCode = txt_Element_L1_Code_Field.innerText;
}
else if (txt_Element_L1_Code_Field.innerHTML != "") {
appendCode = txt_Element_L1_Code_Field.innerHTML;
}
span_Element_L1_CPN_Field.innerText = appendCode;
span_Element_L1_CPN_Field.innerHTML = appendCode;
};
Version 3:
I lost it, gone
|
|
|
|
|
Just use textBox.value. innerText and innerHTML will typically be empty for an <input>, for obvious reasons if you think about the markup.
|
|
|
|
|
It took a while to test, but ended up very simplistic using .value
Thanks for the extra eyes, been awhile since I've used pure Javascript to get values.
|
|
|
|
|
Maybe this
IE 8 needs
var pointer=createElement(');
var pointer1=pointerOfObject.appendChild(pointer);
but not pointer1.type="here_the_kind_of_button";
Opera needs
var pointer=createElement('INPUT');
var pointer1=pointerOfObject.appendChild(pointer);
pointer1.type="here_the_kind_of_button";
innerText not possible for Mozilla.
Please use .innerHTML
.innerText contains only plain text.
.innerHTML contains e.g. HTML tags like
|
|
|
|
|
I ended up writing this, but I do need to go back and see if IE can just use innerHTML. I'm still messing around between IE, Firefox, and I need to do opera as well.
onkeyup element is created with createElement('input');
var txt_Element_L1_Code_Field = document.createElement("input");
txt_Element_L1_Code_Field.id = "_txt_Element_L1_Code_Field_" + dynamicCart_Element1.idx;
txt_Element_L1_Code_Field.type = "text";
txt_Element_L1_Code_Field.style.paddingLeft = "5px";
txt_Element_L1_Code_Field.style.width = "90%";
txt_Element_L1_Code_Field.style.backgroundColor = "rgb(255,255,255)";
txt_Element_L1_Code_Field.style.border = "solid 1px rgb(255,228,225)";
txt_Element_L1_Code_Field.maxLength = 8;
td_Element_L1_Code_Field.appendChild(txt_Element_L1_Code_Field);
txt_Element_L1_Code_Field.onkeyup = function () {
var appendCode = txt_Element_L1_Code_Field.value;
span_Element_L1_CPN_Field.innerText = partNumber.toUpperCase() + "-" + appendCode.toUpperCase();
span_Element_L1_CPN_Field.innerHTML = partNumber.toUpperCase() + "-" + appendCode.toUpperCase();
};
|
|
|
|
|
I want to adapt this datatable: http:
I spent a lot of time researching how to use it but always without result I managed to adapt this one: http:
thank you very much
|
|
|
|
|
There are lots of Database articles here[^] on CodeProject.
One of these days I'm going to think of a really clever signature.
|
|
|
|
|
Dear All,
I have problem , I am trying to use showmodaldialog javascript.
it always return undefined if you call page from out of domain,while if try to call page inside domain will return result
Yes. CreatiVity withOuT limiTs
|
|
|
|
|
Some Javascript and Jquery in same domain only, like $.AJAX
You would have to post code for a better anwser
|
|
|
|
|
could u check next reply
Yes. CreatiVity withOuT limiTs
|
|
|
|
|
You can't use AJAX across domains. If this script is using AJAX under the covers then it won't work with a cross-domain URL.
|
|
|
|
|
No I am just call from site ZZZ
var dlgResult = showModalDialog("YYYYY.aspx", '', "dialogWidth:880px;dialogHeight:400px;status:1");
In site YYYYY
YYYYY.aspx
return
function ExitPage(UserName,CardSerial)
{
var dlgResult = new Array();
dlgResult["UserName"] = UserName;
window.returnValue = dlgResult;
window.close();
}
but alway return undefined
I test same procedure in pages in save domain ZZZ
,and return correct result
Yes. CreatiVity withOuT limiTs
|
|
|
|
|
I'm working on a color picker, to alter the canvas color of images uploaded.
So I have a manual RGB input, 3 textboxes
I wrote a program to evaulate the keydown, and can capture BS, DEL 0-9, but I also need to check that the whole number is 0-255.
I'd like to do it in one shot, but I'm not sure if it's possible, and where to implement it.
Just looking for suggestions.
$('[id*="_txt_Red"]').keydown(function (e) {
return evaulateKeyDown_RGB(e);
});
function evaulateKeyDown_RGB(e) {
var charCode = e.keyCode || e.which;
if (charCode == 8 || charCode == 37 || charCode == 39 || charCode == 46 || ( charCode >= 48 && charCode <= 57 )) {
return true;
}
else if (charCode >= 96 && charCode <= 105) {
return true;
}
else {
return false;
}
}
|
|
|
|
|
Rather than evaluate the keystrokes themselves, I'd probably be tempted to try to just evaluate the text in an input control. You could create a validation function that was called in response to key-up/mouse-up/onchange events (not sure if mouse-up will catch pasting with the mouse)
Let's say you've got a string that represents the number 255.
var myStr = '255';
var myInt = parseInt(myStr);
if ((myInt != NaN) && (myInt < 256))
{
doSomething();
}
else
alert("Error\nYou must enter a number between 0 and 255");
If I've misunderstood your needs, sorry!
(still jealous you were at Xerox at such a pivotal time in PC history)
|
|
|
|
|
You right on, and I have stuff for onChange binded to a function.
So I'm using 2 events then, to separate them.
(I was too young to translate it into wealth, and on the wrong end of CA.)
|
|
|
|
|
If you're going to do live validation, make sure it's not annoying ... i.e. make sure you can delete everything and start typing, that you can paste into it, and that normal patterns of modification still work. For example to change 192 to 196, people might go to the end and press 'backspace, 6' (which would be fine), or they might go in front of the 2 and type '6, delete' which would produce an intermediate of 1962.
Generally you should only adjust the display to indicate a valid or invalid value, instead of actually rejecting keystrokes, if that character can ever be part of a valid input.
|
|
|
|
|
So I did filter the keystokes, and then ran the validation on the update image button, when you work with rgb, I update the hex, update the hex, I update the rgb, and the sample color swatch.
Ended up with this so far, without the copy and paste functionality. I need to go back and add that. Still testing the full functionality, and taking note of any errors.
My validate_HEX is not working right, I need to check the regex, or my use of .test is not correct.
Tell me what you think. I'm getting better at writing javascript.
Oh, Thanks for your comment, I pretty much got crickets on this one.
function evaulateKeyDown_RGB(e, targetObj) {
var charArray = [8, 9, 17, 18, 37, 39, 46, 48, 49, 50, 51, 52, 53, 54,
55, 56, 57, 96, 97, 98, 99, 100, 101, 102, 103, 104, 105];
var charCode = parseInt(e.keyCode || e.which);
for (var i = 0; i < charArray.length; i++) {
if ((charCode != NaN) && (charArray[i] == charCode)) {
return true
}
}
return false;
}
function evaulateKeyDown_HEX(e, targetObj) {
var charArray = [8, 9, 17, 18, 37, 39, 46, 65, 66,
67, 68, 69, 70, 97, 98, 99, 100, 101, 102,
48, 49, 50, 51, 52, 53, 54, 55, 56, 57,
96, 97, 98, 99, 100, 101, 102, 103, 104, 105];
var charCode = parseInt(e.keyCode || e.which);
for (var i = 0; i < charArray.length; i++) {
if ((charCode != NaN) && (charArray[i] == charCode)) {
return true
}
}
return false;
}
function validate_RGB(targetObj) {
var charFlag = false;
var value = parseInt(targetObj.val());
if ((value != NaN) && (value <= 255)) {
targetObj.css("border", "solid 1px rgb(140,140,140)");
return true;
}
else {
targetObj.focus().select();
targetObj.css("border", "solid 1px rgb(255,0,0)");
return false;
}
}
function validate_HEX(targetObj) {
var hValue = targetObj.val();
var regColorcode = /^(#)?([0-9a-fA-F]{3})([0-9a-fA-F]{3})?$/;
if (regColorcode.test("#"+hValue) == false) {
targetObj.focus().select();
targetObj.css("border", "solid 1px rgb(255,0,0)");
return false;
}
else {
targetObj.css("border", "solid 1px rgb(140,140,140)");
return true;
}
}
|
|
|
|
|
The regex looks okay. What's .val()? Text boxes have a .value in normal DOM object speak.
|
|
|
|
|
General 
News 
Suggestion 
Question 
Bug 
Answer 
Joke 
Praise 
Rant 
Admin 
Submit an article or tip
