Click here to Skip to main content
15,922,419 members

Welcome to the Lounge

   

For discussing anything related to a software developer's life but is not for programming questions. Got a programming question?

The Lounge is rated Safe For Work. If you're about to post something inappropriate for a shared office environment, then don't post it. No ads, no abuse, and no programming questions. Trolling, (political, climate, religious or whatever) will result in your account being removed.

 
GeneralRe: That's not the same project Pin
mikepwilson16-Oct-14 10:51
mikepwilson16-Oct-14 10:51 
GeneralRe: That's not the same project Pin
User 1013254616-Oct-14 20:29
User 1013254616-Oct-14 20:29 
GeneralRe: That's not the same project Pin
daleofcourse16-Oct-14 21:46
daleofcourse16-Oct-14 21:46 
GeneralRe: That's not the same project Pin
Jonas Hammarberg16-Oct-14 22:16
professionalJonas Hammarberg16-Oct-14 22:16 
GeneralRe: That's not the same project Pin
Gary R. Wheeler17-Oct-14 1:36
Gary R. Wheeler17-Oct-14 1:36 
GeneralRe: That's not the same project Pin
BrainiacV17-Oct-14 5:33
BrainiacV17-Oct-14 5:33 
GeneralRe: That's not the same project Pin
bantling17-Oct-14 8:15
bantling17-Oct-14 8:15 
GeneralRe: That's not the same project Pin
loctrice17-Oct-14 10:35
professionalloctrice17-Oct-14 10:35 
The program was written for basic file integrity. Like, do all the column headers match and do all the required fields have data all the way through. That was all it was intended for, so the processor got an email when a file was accepted and then did his/her job.

The problem is now they are wanting to add persistence. Like is all the data in the same order as the previous load(s), and have we already processed this file into our (completely separate) data system. Which is part of two other planned projects, but don't fit in here.

I was using a factory to get an object, per client, that implemented the command pattern for the rulesets. The list of command objects was injected via another factory. Made things pretty simple. Those objects all just took in a list of the data.

My frustration also has to do with the fact that later with another planned project, I'll have to reimplement this properly (which is how you were talking about another set of code).

The idea is that we will automatically process these files as well,but they are getting impatient and just wanting things hacked onto this project because it will take time to develop the other two pieces.

If it interests you, I just changed the top level command object that comes back from the factory to be a container object, and take a second argument containing the user data needed for previous lookups. It breaks my idea of clean code because a) it no longer implements the uniform command pattern, and b) the top level objects now take an argument that aren't used by the other implementations.

I decided I would leave it the way it was, because a) We're going to do the next step soon and it will make this code irrelivant and b) without more instances I don't see a clear/clean way to refactor it.
Elephant elephant elephant, sunshine sunshine sunshine

RantTesters Pin
Colin Mullikin16-Oct-14 2:56
professionalColin Mullikin16-Oct-14 2:56 
GeneralRe: Testers PinPopular
chriselst16-Oct-14 2:59
professionalchriselst16-Oct-14 2:59 
GeneralRe: Testers Pin
Mike Hankey16-Oct-14 3:04
mveMike Hankey16-Oct-14 3:04 
GeneralRe: Testers Pin
Maximilien16-Oct-14 3:13
Maximilien16-Oct-14 3:13 
GeneralRe: Testers PinPopular
Mladen Janković16-Oct-14 3:14
Mladen Janković16-Oct-14 3:14 
GeneralRe: Testers Pin
Nagy Vilmos16-Oct-14 3:16
professionalNagy Vilmos16-Oct-14 3:16 
GeneralRe: Testers Pin
megaadam16-Oct-14 3:32
professionalmegaadam16-Oct-14 3:32 
GeneralRe: Testers Pin
PIEBALDconsult16-Oct-14 5:28
mvePIEBALDconsult16-Oct-14 5:28 
GeneralRe: Testers Pin
Nagy Vilmos16-Oct-14 5:44
professionalNagy Vilmos16-Oct-14 5:44 
GeneralRe: Testers Pin
Roger Wright16-Oct-14 10:23
professionalRoger Wright16-Oct-14 10:23 
GeneralRe: Testers Pin
Slacker00716-Oct-14 4:17
professionalSlacker00716-Oct-14 4:17 
GeneralRe: Testers Pin
Bassam Abdul-Baki16-Oct-14 4:39
professionalBassam Abdul-Baki16-Oct-14 4:39 
GeneralRe: Testers Pin
PIEBALDconsult16-Oct-14 5:29
mvePIEBALDconsult16-Oct-14 5:29 
GeneralRe: Testers Pin
Fredrik Bornander16-Oct-14 6:32
professionalFredrik Bornander16-Oct-14 6:32 
GeneralRe: Testers Pin
Suraj Sahoo | Coding Passion16-Oct-14 6:56
professionalSuraj Sahoo | Coding Passion16-Oct-14 6:56 
GeneralNNOTD Pin
chriselst16-Oct-14 2:28
professionalchriselst16-Oct-14 2:28 
GeneralRe: NNOTD PinPopular
MehGerbil16-Oct-14 2:38
MehGerbil16-Oct-14 2:38 

General General    News News    Suggestion Suggestion    Question Question    Bug Bug    Answer Answer    Joke Joke    Praise Praise    Rant Rant    Admin Admin   

Use Ctrl+Left/Right to switch messages, Ctrl+Up/Down to switch threads, Ctrl+Shift+Left/Right to switch pages.