C / C++ / MFC

Re: Having issues with the cin.getline() function in C++

8-Mar-20 14:29

for a short test in my class, we had to write code about pigs that allowed the user to enter information about a set of pigs (e.g. the pigs' names, breed, weight, gender, etc.). We were to create a class called pigs that would be able to hold the pigs' information. There was nothing wrong with the class itself, the problem I'm having is actually in the main function.

cout << "Enter the pig gender (\'m\'/\'f\')(if not press \'enter\' for none): ";
cin.getline(pigGender, 10);
if(pigGender != "\n")
{
    while(pigGender != "m" && pigGender != "f")
    {
        cout << "Invalid gender, please enter a valid gender m or f(if not press \'Enter\'): ";
        cin.getline(pigGender, 10);
        if(pigGender != "\n")
        {
            //cout << "if branch, pigGender:" << pigGender;
            gender = pigGender[0];
        }
        else
        {
            //cout << "else branch, pigGender:" << pigGender;
            gender = ' ';
            break;
        }
    }
    pigs[i].SetPigGender(gender);
}

The piece of code above, shows how I'm trying to obtain the pig's gender from the user. I made it so that if the user doesn't know the gender, they can just hit enter to move on (as I did with other features that worked fine). The problem is that when you hit enter, the pigGender string doesn't seem to take the newline character. Also, I understand how the getline function works (takes in a newline and stops), hence I believe when you hit enter, the getline will take in the newline and stop, but here it does not seem to take it in at all. I also made it so that if the user enters a wrong letter (not m or f), then they can still hit enter if they do not know. The commented out codes are checks I implemented to see exactly what was in pigGender. When I enter a charcter that is not a newline it will go to the if branch and dislpay my error message, however, when I hit only enter, it still goes through that if branch instead of the else branch. the checks i commented out show me which branch I am in and the charcter in the pigGender string, and when I hit enter for the newline, there seems to be nothing in the pigGender string. What seems even more bizarre, is that the following code is very similar to what I did above (I actually copied and pasted it and made some changes to make the one above) and it works perfectly.

cout << "Enter the pig weight(if not press \'Enter\'): ";
cin.getline(weight, 10);
if(weight != "\n")
{
    float pigWeight = atof(weight);
    while(pigWeight < 0)
    {
        cout << endl;
        cout << "Invalid weight, please enter a valid weight(if not press \'Enter\'): ";
        cin.getline(weight, 10);
        if(weight != "\n")
        {
            pigWeight = atof(weight);
        }
        else
        {
            pigWeight = 0;
        }
    }
    pigs[i].SetPigWeight(pigWeight);
}

Is there something I'm just not seeing here, because I have been looking at this code since yesterday and have tried a bunch of stuff to fix it but can't. Of course, I do know of many other ways to tackle this problem (like comparing string size instead), but I started with this and its really bugging me that it does not work, so I just want to figure it out just so I can know. If you can help me understand, please respond, I really want to figure this thing out, thank you!

k50548-Mar-20 15:37

Re: Having issues with the cin.getline() function in C++

8-Mar-20 15:37

iostream::getline() strips the trailing delimiter from input. That means that when you hit return only, the string is empty (e.g = "").

You also have an error in all your string comparisons:

C++

if(weight != "\n")

is always true (this actually compares the address of weight to the address of the static object "\n". To compare objects of type char * (or char[]), you must use strcmp(). In this case, since you are just interested to see if the only char in the string is '\n' you could say

C++

if(weight[0] != '\n')

(note that this still won't work because iostream::getline() strips the newline delimiter from the input.

It only looks like the weight is being skipped. As explained above the comparison is always true, so the code block following the comparison is always executed. What is happening is that

C++

pigweight = atof(weight)

evaluates with weight = "", which evaluates to zero, so it only seems like the code block was skipped. If you were to change the code to, say

C++

if(weight != "\n") // This is always true ...
{
    cerr << "checking weight from user\n";
    // rest of block 
}

You would always see the "checking weight from user" message, whether you hit return or not.

Member 147670009-Mar-20 10:55

Re: Having issues with the cin.getline() function in C++

9-Mar-20 10:55

But when I enter a valid weight and hit enter, the program moves on to the next feature (it doesnt go through the if branch).

Member 147670009-Mar-20 11:01

Re: Having issues with the cin.getline() function in C++

9-Mar-20 11:01

I think I get what you are saying, but I just ran the program again and if I enter a valid weight (positive number) everything runs normally and at the end it displays the number I entered.

k50549-Mar-20 12:12

Re: Having issues with the cin.getline() function in C++

9-Mar-20 12:12

Sure, but if you do this

C++

if(weight != "\n")
{
  // ... 
  pigs[i].SetPigWeight(pigWeight);
}
else
    pigs[i].SetPigWeight(100.0); // Set default weight to 100.0
// ...

Now, when you hit enter, you would expect that the default weight would be used (i.e. set to 100.0), if the comparison is working as you expect. But it won't be, it will be set to zero. Believe me when I tell you that

C++

if (weight != "\n")

does not compare objects of type char* (ie c-style strings). You must use strcmp() to compare c-style strings. Better than using iostream::getline, take a look at std::getline. Your code might then look something like

C++

#include <string>
// ...
string input_string;
// ...
getline(cin, input_string);
if(input_string.length() != 0) // User entered a value
{
    // ...
}

Furthermore, what happens if you enter one hundred for the weight? It doesn't get set to 100, but zero, since atof("one hundred") == 0.0. A good solution should check that the input is a number. At the very least that the input string contains only the characters "0123456789.". Ideally you would check that there was only one decimal point, too.

Member 1476700010-Mar-20 8:49

Re: Having issues with the cin.getline() function in C++

10-Mar-20 8:49

You're right, I copied and pasted that code to try it and it set the pig weight to the default of 0 instead of 100. I understand what you are saying now. Thank you so much for taking out the time to explain this to me in detail. This thing was really frustrating me and you really cleared it up for me, I really appreciate this!

k505410-Mar-20 9:04

Re: Having issues with the cin.getline() function in C++

10-Mar-20 9:04

You're very welcome.

String comparisons can be tricky in C/C++. I have over 30 years experience with C and it took me a couple of readings of your code to realize

C++

if(weight != "\n")

did not do what it looks like it should! I'm sure I'm not the only one who looked at that and didn't twig right away that the string comparisons were incorrect.

Stefan_Lang8-Mar-20 22:26

Stefan_Lang

8-Mar-20 22:26

k5054 already said it all.

But I'd like to add the general advice that you read up on the description of all I/O functions rather than making assumptions about what they return. Especially input functions.

Also, it is usually easier to read std::string objects rather than reading input of unknown length into limited size buffers. You can use the function getline(istream&, string) for that. See getline (string) - C++ Reference[^]

GOTOs are a bit like wire coat hangers: they tend to breed in the darkness, such that where there once were few, eventually there are many, and the program's architecture collapses beneath them. (Fran Poretto)

Re: Having issues with the cin.getline() function in C++

k50549-Mar-20 12:29

Re: Having issues with the cin.getline() function in C++

9-Mar-20 12:29

Stefan_Lang wrote:
Also, it is usually easier to read std::string objects rather than reading input of unknown length into limited size buffers. You can use the function getline(istream&, string) for

Additionally, you should expect your Teacher/TA/Assignment-marker to be an "evil knave of the worst kind", looking to find ways to make your program crash. For any input she/he might choose to cut/paste something like:

Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.

If you use std::getline(), rather than iostream::getline(), you should be able to handle any reasonable input sent your way.

Stefan_Lang9-Mar-20 21:41

Stefan_Lang

9-Mar-20 21:41

k5054 wrote:
Additionally, you should expect your Teacher/TA/Assignment-marker to be an "evil knave of the worst kind", looking to find ways to make your program crash

I've found I learned more from the 'evil knave' types than those who were 'playing nice'. Nothing prepares you better for the real world than nasty traps! Suspicious | :suss:

a not fun question: how to deploy a utility program written in MFC and C++

Southmountain8-Mar-20 12:56

Re: a not fun question: how to deploy a utility program written in MFC and C++

8-Mar-20 12:56

I wrote a small utility tool with MFC (for user interface) and purely C++ code.
on Windows 10 and in Visual Studio 2017 IDE, I compiled this program into .exe file (i.e. HelloX.exe) in MFC dynamic DLL option.
So I put vcruntime140.dll and mfc140u.dll at the same folder.

I test my program on Windows Vista, it works well. I just tested this program on Windows XP and it did not work(few minutes ago).

Any suggestion or comments to share? thanks a million.

diligent hands rule....

modified 8-Mar-20 22:14pm.

Jon McKee8-Mar-20 13:01

Jon McKee

8-Mar-20 13:01

C/C++/MFC forum or Quick Answers. Specific programming questions are generally frowned upon in the Lounge per the sticky post at the top.

Re: a not fun question: how to deploy a utility program written in MFC and C++

Southmountain8-Mar-20 16:06

Re: a not fun question: how to deploy a utility program written in MFC and C++

8-Mar-20 16:06

thanks

diligent hands rule....

Maximilien8-Mar-20 15:38

Maximilien

8-Mar-20 15:38

Deploy as in creating an installer ?

For small packages like yours, I would use inno setup to package your software.

I'd rather be phishing!

Re: a not fun question: how to deploy a utility program written in MFC and C++

Southmountain8-Mar-20 16:03

Re: a not fun question: how to deploy a utility program written in MFC and C++

8-Mar-20 16:03

not using installer. just xcopy command etc.

diligent hands rule....

Shao Voon Wong8-Mar-20 15:51

Shao Voon Wong

8-Mar-20 15:51

To deploy without having to install the VC++ dlls.

Linking to C runtime statically (Multithreaded (/MT) for Release build)
http://imageshack.com/a/img923/6600/ifeLcs.png

If you are using MFC, linking to MFC runtime statically.
http://imageshack.com/a/img921/1331/7eBoZW.png

The downside to linking statically is your executable size will be bigger but it only links the classes and functions your executable calls whereas, in the dynamically linkage case, the VC++ dlls have to contains all the code regardless your executable calls them or not.

Re: a not fun question: how to deploy a utility program written in MFC and C++

Southmountain8-Mar-20 16:04

Re: a not fun question: how to deploy a utility program written in MFC and C++

8-Mar-20 16:04

I plan to use MFC DLL dynamically linked option. I have several utilities to distribute in one bundle...

diligent hands rule....

Shao Voon Wong8-Mar-20 16:09

Shao Voon Wong

8-Mar-20 16:09

Then download VC++ redistributables to install on your client machine before running your utilities.

https://support.microsoft.com/en-sg/help/2977003/the-latest-supported-visual-c-downloads

Re: a not fun question: how to deploy a utility program written in MFC and C++

Southmountain8-Mar-20 16:24

Re: a not fun question: how to deploy a utility program written in MFC and C++

8-Mar-20 16:24

thank you! first to know VS 2015, VS 2017,and VS2019 have the same redistribute.

diligent hands rule....

Shao Voon Wong8-Mar-20 16:28

Shao Voon Wong

8-Mar-20 16:28

Yes, this is the future direction going forward because MS does not want the user to install many VC++ redistributables on their machine.

Re: a not fun question: how to deploy a utility program written in MFC and C++

Southmountain8-Mar-20 16:08