C / C++ / MFC

Re: Main Window Icon loading

9-May-04 13:18

Hi.
Usual question. How can I load an Icon into my main MFC window. I already searched on this web site for answers but obviously they won't work for me. I tried several differnt ways:

I then tried this :

BOOL CMyAppView::PreCreateWindow(CREATESTRUCT& cs)
{
if (!CWnd::PreCreateWindow(cs))
return FALSE;

m_hIconFrame = AfxGetApp()->LoadIcon(MAKEINTRESOURCE(IDR_MAINFRAME));

cs.lpszClass = AfxRegisterWndClass(CS_HREDRAW|CS_VREDRAW|CS_DBLCLKS,
::LoadCursor(NULL, IDC_ARROW), reinterpret_cast<hbrush>(COLOR_WINDOW+1), m_hIconFrame );

return TRUE;
}

Then I tried :

in MyApp::InitInstance()
{

AfxGetApp()->LoadIcon(MAKEINTRESOURCE(IDR_MAINFRAME)); <--- this wont work
CWinApp::LoadIcon(IDR_MAINFRAME ); <------------------------- this wont work too

m_pMainWnd = pFrame;
// create and load the frame with its resources
pFrame->LoadFrame(IDR_MAINFRAME,WS_OVERLAPPEDWINDOW | FWS_ADDTOTITLE, NULL, NULL);

}

Then I tried in int CMainFrame::OnCreate(LPCREATESTRUCT lpCreateStruct). Still no luck..
However same function call ie. AfxGetApp()->LoadIcon(IDR_MAINFRAME); in my dialog class displays the bloody icon ok.
what is going on? Why can't I see this icon in my main window caption bar? ARGH....
Can somebody help please. thank you.

Iceberg769-May-04 15:22

Iceberg76

9-May-04 15:22

I'm pretty sure you just need to add an icon as a resource and then name it:
IDR_MAINFRAME

Then when you create the mainframe it should be there. I don't think you need to manually load.

Look here to help out in MFC:
http://www.adminmod.org/karel/2/index.htm

Re: Main Window Icon loading

_foo9-May-04 18:36

_foo

9-May-04 18:36

CWnd::SetIcon

Re: Main Window Icon loading

robert_s10-May-04 4:51

std::sort( Ran first, Ran last, Cmp cmp)

10-May-04 4:51

Ok thank you. Cwnd::SetIcon() solved my problem Smile | :)

Laing,James9-May-04 11:17

9-May-04 11:17

Hi.

Can anyone please advise on how I can specify a class member function as the 'Cmp' function in the above call.
I would like to be able to call the sort() function from within a class member function and to be able to specify another class member function( of the same class and instantiation ).
I do not want to declare a struct that defines a comparison operator etc.. I would like to be able to keep the whole process private to a class that defines a 'Cmp' type function that I can provide as an argument.

Thanks in advance.
James.

Milton Karimbekallil9-May-04 19:31

Milton Karimbekallil

9-May-04 19:31

hi
Yes it is possible, provided the user-defined binary predicate function shud b static. Otherwise u know, while linking a class, every member function will get an _this pointer automatically. This changes the function signature of a predicate function and will show error while compilation. If it is static the parameter list will remain unchanged. c the sample class.

rgds..mil10

using namespace std;<br />
class TstClass<br />
{<br />
public:<br />
	vector<int> _data;<br />
	void loaddata()<br />
	{<br />
		_data.push_back(20);<br />
		_data.push_back(10);<br />
		_data.push_back(30);<br />
	}<br />
<br />
	static bool UDgreater ( int elem1, int elem2 )<br />
	{<br />
		return elem1 > elem2;<br />
	}<br />
<br />
	void displaysorted()<br />
	{<br />
		sort(v.begin(),v.end(),UDgreater);<br />
		vector<int>::iterator it;<br />
		<br />
		for( it=v.begin(); it!=v.end(); it++ )<br />
			cout<<(*it);		<br />
	}<br />
};

Maxwell Chen9-May-04 20:20

Maxwell Chen

9-May-04 20:20

Mil10 wrote:
Yes it is possible, provided the user-defined binary predicate function shud b static. Otherwise u know, while linking a class, every member function will get an _this pointer automatically. This changes the function signature of a predicate function and will show error while compilation.

From Section 11.5 in "The C++ Programming Language, 3rd":

An ordinary member function declaration specifies three logically distinct things:
(1) The function can access the private part of the class declaration, and
(2) the function is in the scope of the class, and
(3) the function must be invoked on an object (has a this pointer).

By declaraing a member function static ($10.2.4), we can give it the first two properties only. By declaring a function a friend, we can give it the first property only.

Maxwell Chen

Laing,James9-May-04 21:51

9-May-04 21:51

Thanks very much for the help.

James.

Milton Karimbekallil10-May-04 18:11

Milton Karimbekallil

10-May-04 18:11

From Section 11.5 in "The C++ Programming Language, 3rd":

An ordinary member function declaration specifies three logically distinct things:
(1) The function can access the private part of the class declaration, and
(2) the function is in the scope of the class, and
(3) the function must be invoked on an object (has a this pointer).

By declaraing a member function static ($10.2.4), we can give it the first two properties only. By declaring a function a friend, we can give it the first property only.

very nice explanation - thanx Chen.

rgds...mil10

Mike Dimmick10-May-04 1:43

Mike Dimmick

10-May-04 1:43

I think you want the mem_fun adapter function, which returns an appropriate functor object (typically a mem_fun1_t object).

Stability. What an interesting concept. -- Chris Maunder

Paul Ranson10-May-04 4:14

Paul Ranson

10-May-04 4:14

Do you mean something like,

class Sort1
{
private :
    std::vector<int> v_ ;

    static bool Cmp ( const int l, const int r )
    {
        return l > r  ;
    }
public :
    Sort1 ()
    {
        v_.resize ( 10 ) ;
        for ( int i = 0; i < 10; ++i )
        {
            v_ [ i ] = i ;
        }
    }
    void DoSomething ()
    {
        std::sort ( v_.begin (), v_.end (), Cmp ) ;
    }
    void PrintV_ ()
    {
        for ( unsigned i = 0; i < v_.size (); ++i )
        {
            std::cout << v_ [ i ] << " " ;
        }
        std::cout << "\n" ;
    }
} ;

int main()
{
    Sort1 s ;
    s.PrintV_ () ;
    s.DoSomething () ;
    s.PrintV_ () ;

    return 0;
}

Or are you trying to use a member of the sortable class as the comparison function?

class Sortable
{
private :
    int val_ ;
public :
    Sortable ()
    {
    }
    static bool Cmp ( const Sortable& l, const Sortable& r )
    {
        return l.val_ > r.val_ ;
    }
} ;
...
    std::vector<Sortable> vs ;
...
    std::sort ( vs.begin (), vs.end (), Sortable::Cmp ) ;

Paul

Laing,James10-May-04 9:42

10-May-04 9:42

Hi.

I have looked at all the updates to this thread and I am a little unsure as to how to proceed.
I appreciate all the advice and the different types of approach. However, if I may describe the problem with some additional constraints.

I cannot use the static member function approach as I need to be able to access a set of compound sort ranges defined in a vector table declared privately within the class.

I therefore need a mechanism that would allow me to specify a non-static class member function as the comparison function on the sort call.

Any more advice would be most welcome.
James.

Laing,James10-May-04 9:58

10-May-04 9:58

Hi.

If no one has a solution to this particular situation, then I might be better served by simply writing my own sort routine. That way I can provide a comparison function with the operands and access that I require. I have written numerous sort routines before, especially in the days before C++ and the STL ( as you might have guessed, I am quite new to C++). I was hoping, prehaps naively, that the STL could solve all my algorithmic problems elegantly but maybe that is just not the case.

Thanks for the contributions.
James.

Paul Ranson10-May-04 10:39

Paul Ranson

10-May-04 10:39

You may consider this too ugly...

template <typename C, typename S> struct MemFunCmp_t
{
    bool (C::*pmf_ )( const S&, const S& ) ;
    C& rC_ ;

    MemFunCmp_t ( C& rC, bool (C::*f)( const S&, const S& )) : rC_ ( rC ), pmf_ ( f )
    {
    }
    bool operator () ( const S& l, const S& r )
    {
        return (rC_.*pmf_) ( l, r ) ;
    }
} ;

template <typename C, typename S> MemFunCmp_t< C, S > MemFunCmp ( C& c, bool (C::*f)( const S&, const S&))
{
    return MemFunCmp_t <C, S>( c, f ) ;
}

class Sort2
{
private :
    std::vector<int> v_ ;

    bool Cmp2 ( const int& l, const int& r )
    {
        return l > r ;
    }
public :
    Sort2 ()
    {
        v_.resize ( 10 ) ;
        for ( int i = 0; i < 10; ++i )
        {
            v_ [ i ] = i ;
        }
    }
    void DoSomething ()
    {
        std::sort ( v_.begin (), v_.end (), MemFunCmp ( *this, Cmp2 )) ;
    }
    void PrintV_ ()
    {
        for ( unsigned i = 0; i < v_.size (); ++i )
        {
            std::cout << v_ [ i ] << " " ;
        }
        std::cout << "\n" ;
    }
} ;

int main()
{
    Sort2 s ;
    s.PrintV_ () ;
    s.DoSomething () ;
    s.PrintV_ () ;

    return 0;
}

But I think it does what you're asking for.

It builds and runs on VC7.1, I believe it's standard C++. YMMV.

Paul

Laing,James11-May-04 9:35

SetFocus for a chosen Edit Control in MFC

11-May-04 9:35

Hi.

Thanks for the update. The 'work around' is not at all ugly but prehaps slightly convoluted. Nevertheless, I have incorporated it into my application and it works prefectly. I like your solution because I have learnt something new from it.

Best Regards.
James.

Dialogs

Member 6226669-May-04 10:51

Member 622666

9-May-04 10:51

Ok, im a complete newb at C++ and am just starting off. I wanna make a program MFC of course and when i click button "Create" i want it to bring up Dialog "B" which is the other dialog besides "A" can someone tell me the quickest and eastesy way of doing this? If it wouldnt be too much trouble of course...

Thanks

Re: Dialogs

Christian Graus9-May-04 13:03

Christian Graus

9-May-04 13:03

You create a dialog in your resource editor, and then it will create a class derived from CDialog, say you call the class CNewDlg. Then the code looks like this:

OnClickCreate() // this method is created by the IDE for you on request, I'm not sure of it's signature anymore, it's been too long
{
CNewDlg dlg;

if (dlg.DoModal() == IDOK) //OK was clicked
{
//respond to the OK button being clicked. At this point, any member variables in the CNewDlg instance
// you created are still accessible, but anything in windows ( edit boxes, etc. ) isn't, as they have been destroyed.

}

}

Christian

I have drunk the cool-aid and found it wan and bitter. - Chris Maunder

snapping windows

Roman Nurik9-May-04 9:19

Roman Nurik

9-May-04 9:19

hey, I override WM_MOVING to change the drag rectangle of a moving window to "snap" to the borders of the desktop... the problem is "unsnapping" -- i can't unsnap because the original drag rectangle isn't stored and whenever i want to move the drag rectangle it keeps moving back to the snapped position:

case WM_MOVING:
{
	RECT rcWorkArea;
	if (SystemParametersInfo(SPI_GETWORKAREA,0,&rcWorkArea,0))
	{
		RECT* pRC = (RECT*)lParam;
		if (pRC->bottom >= rcWorkArea.bottom - 10) // distance before snapping = 10
			OffsetRect(pRC,0,rcWorkArea.bottom - pRC->bottom);
		else if (pRC->top <= rcWorkArea.top + 10)
			OffsetRect(pRC,0,rcWorkArea.top - pRC->top);
	}
	return TRUE;
}

also, how the hell do i get the position of the mouse! i thought there was a function GetMousePos which took in a pointer to a POINT structure but it doesn't exist... so how do i do it?

r -€

Re: snapping windows

KalliMan9-May-04 10:24

KalliMan

9-May-04 10:24

for mouse pos, try with
GetCursorPos(LPPOINT);
or
DWORD pos = GetMessagePos();
CPoint pt(LOWORD(pos), HIWORD(pos));
ScreenToClient(&pt);

KalliMan

Re: snapping windows

Antony M Kancidrowski10-May-04 2:01

Antony M Kancidrowski

10-May-04 2:01

If you want to unsnap you will need to track the direction of the mouse movement. i.e. if it is moving away from the edge then do not apply the snap criteria.

For this you will need to store the last position of the mouse then compare with current position. You can then decide whether to snap or not.

Ant.

robert_s9-May-04 9:01

Re: SetFocus for a chosen Edit Control in MFC

9-May-04 9:01

Hi.

I am writing an application where I have a dialog with one combo box and 4 edit controls. Now when I open that dialog there is always first edit control focused. How can change this behaviour so for example rather than the first I would like the third edit control to be automatically focused, so when the user opens the dialog one can start typing into that (third) edit control rather than using a mouse to click on it first.

I thought it would be as simple as that:

BOOL CTestDlg::OnInitDialog()
{
CDialog::OnInitDialog();
CtrlSourceExt.SetFocus(); // PROBLEM IS HERE - Set foucus to this edit control (this Doesn't work) (NOTE: variable CtrlSourceExt is of type CEdit)
UpdateData();
return TRUE; // return TRUE unless you set the focus to a control
}

Actually I remember in VC++ 6 I could specify the order of things to be focused in resource editor when designing a dialog. So if I had say 4 edit controls I could set focus in this order 4,2,1,3 so the first hightlighed edit control would be 4 then if the user pressed tab once it would take him to edit control 2 then 1 and 3. But now in VC++ 2003 .NET it doesnt work. Same thing with profiler I just cant find it. I dont know why they got rid of such useful thing. Anyway going back to the subject. Can anybody help?
Thanks.

KalliMan9-May-04 10:15

KalliMan

9-May-04 10:15

Perhaps u must set the focus in 'CTestDlg::OnShowWindow()'.

KalliMan

Re: SetFocus for a chosen Edit Control in MFC

toxcct9-May-04 10:23

toxcct

9-May-04 10:23

robert_s wrote:
return TRUE; // return TRUE unless you set the focus to a control

TOXCCT >>> GEII power

Re: SetFocus for a chosen Edit Control in MFC

robert_s9-May-04 12:07