I need help to find a number that contains certain digit and return true if that number contains the desired digit.

Question

0.00/5 (No votes)

See more:

Hello

I am trying to find Number that contains Digit 5.
For Example if value = 1999009, the method should return false
but if value = 501, the method should return true.
Update:
Also it should work for negative numbers too:
if value = -9005 it should return True:

I tried to complete this exercise, however when I Run Tests in Solution Explorer
Tests go through infinite Loop - Screen: 1z — ImgBB[^] . My solution should contain int property Digit and method bool Verify(int value). Also it is recommended that recursion should be used to complete the task.

Thank You

What I have tried:

public int _digit;
        public int Digit
        {
            get => _digit;
            set
            {
                if ((value == 5) // I think something is wrong here)
                {
                    _digit = value;
                }
                            }
        }

        public bool Verify(int value)
        {
            bool isFive = false;
            while (value != 0)
            {
                int _digit = value % 10;
                if (_digit == 5)
                {
                    isFive = true;
                }
                value /= 10;
            }

            return isFive;
        }

Posted 5-Feb-22 7:26am

LuckyChloe

Updated 5-Feb-22 13:07pm

v8

Add a Solution

3 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Accepted Answer · 2022-02-05T07:57:00

Look at your code:

C#

public bool Verify(int value)
{
    bool isFive = false;
    while (value != 0)
    {
        int _digit = value % 10;
        if (_digit == 5)
        {
            isFive = true;
        }
    }

    return isFive;
}

Where inside your loop do you change value?
If value doesn't change, then whenever you call Verify with a non-zero value it can never exit the loop, and thus never return.

Perhaps you want to divide value by ten inside the loop?

To be honest, 2 minutes running this with the debugger and you would have found it for yourself, and saved half an hour of your time ... if you get a problem in future, reach for the debugger first and see exactly what is happening while you code is running!

Graeme_Grant · Accepted Answer · 2022-02-05T13:07:00

To stay away from strings, like in M Imran Ansari solution, you need to do something like:

C#

int GetDigit(int number, int digit)
{
    return (number / (int)Math.Pow(10, digit - 1)) % 10;
}

To use:

C#

int x = 123456;

for (int i = 1; i <= 6; i++)
{
    Console.WriteLine(GetDigit(x, i));
}

which produces:

M Imran Ansari · Accepted Answer · 2022-02-05T08:25:00

In your code, there is a an error and that is you are taking digit = value%10 and it always same value every time and loop condition remains always true. Change your code like:

public bool Verify(int value)
{
    bool isFive = false;
    while (value != 0)
    {
        int _digit = value % 10;
        if (_digit == 5)
        {
            isFive = true;
        }
        value = value / 10;
    }

    return isFive;
}

Secondly, You can also achieve this through String function. Use Contains method of String to find your number, like:

public static bool Verify(int value, string findingNo)
{
	bool isFive = false;
	while (value != 0)
	{
		if (value.ToString().Contains(findingNo))
		{
			isFive = true;
		}
	}
	return isFive;
}

Call Function like: Verify(501, "5");

I need help to find a number that contains certain digit and return true if that number contains the desired digit.

3 solutions

Solution 1

Solution 4

Solution 2

Add your solution here

Preview 0