Windows form not responding during gridview updation

Question

0.00/5 (No votes)

See more:

Hello,
I have a gridview where some data is displayed in it. If i want to delete displayed data i will click button "btnStart". Then a class called "DeleteRows" is instantiated which will show a form dialog where i will enter number of rows to delete and then click ok. Then those many rows are removed from datatable. Because datatable is the datasource for gridview, changes made to datatable are updated in
gridview also.

With respect to logic everything is fine. But if i specify the number of rows to delete somewhere around 1000 or more, datatable.Rows.RemoveAt( ) will take some time for processing.

So Untill the delete is completed

1. my gridview form will be in "Not Responding" state ?

2. Form displayed by DeleteRows class also is not getting closed ?

So how to solve this issue ? Source code is given below

C#

gridview.datasource = datatable;

 private void btnStart_Click(object sender, EventArgs e)
 {

     int nRows = 0;

     // specify number of datarows to delete
    //this class will display a form where user will enter the number of rows to //delete

      DeleteRows deleterows = new DeleteRows( ref nRows);

      deleterows.Showdialog( );

      For(int nIndex = 0; nIndex <= nRows; nIndex++)
      {
          datatable.Rows.RemoveAt( 0 );//removes first nRows from datatable

      }
    //because datatable is gridview data source, changes made are updated in gridview also

 }

Thanks in advance,

Posted 29-Mar-12 2:49am

code4Better

Updated 29-Mar-12 3:06am

Michel [mjbohn]

v2

Add a Solution

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

bbirajdar · Answer 1 · 2012-03-29T02:58:00

Solution 1

Problem in your code

You are deleting the first row i.e. at 0th index each time

The correct code should be

C#

For(int nIndex = 0; nIndex <= nRows; nIndex++)
{
datatable.Rows.RemoveAt( nIndex  );//removes first nRows from datatable 
datatable.AcceptChanges();
 
}

Posted 29-Mar-12 2:58am

bbirajdar

Updated 29-Mar-12 2:59am

v2

Comments

[no name] 29-Mar-12 9:17am

And how exactly will that help with making the program responsive while deleting many rows?

bbirajdar 29-Mar-12 9:44am

Not required. Deleting a 1000 rows takes place within a fraction of second. It will not have any effect on responsiveness.

The major mistake you are making here is the 'delete rows' logic should be written in the Dialog OK event and not in btnStart event click

code4Better 30-Mar-12 0:11am

Hello Birajdar,
I am always deleting 0th index because i want to delete the 1st nRows. In datatable if you delete 1 row then whole rows are shifted 1 above. So there is no problem with delete part.

Deleting 1000 records will be take only fraction of seconds if the datatable from which you are deleting is not datagridview datasource. If it is datagridview datasource then it will take some time.

My issue is not logic. The grid view form gets into "Not responding" state during the deletion process. How to solve this?

code4Better 30-Mar-12 0:16am

Hello CDP1802,
When i delete some 5000rows it will take some 30 to 60 seconds to complete. During this time if i simply click anywhere in gridview form, then form goes to "Not responding" state and it continues being Not responding state untill whole rows are deleted.

Vladislav Socolov · Answer 2 · 2012-03-29T04:16:00

You could use a multi-threading approach.

C#

private void btnStart_Click(object sender, EventArgs e)
{
      int nRows = 0;
      Thread test = new Thread(()=>Foo(nRows)); 
      test.Start();
}

private void Foo(int nRows )
{
       DeleteRows deleterows = new DeleteRows(nRows);
 
       deleterows.Showdialog( );
 
       For(int nIndex = 0; nIndex <= nRows; nIndex++)
       {
           datatable.Rows.RemoveAt( 0 );//removes first nRows from datatable  

       }
}