javascript function not working

Question

0.00/5 (No votes)

See more:

I try to call a java script function from a html check box as follows

XML

<script type="text/javascript">
changeGroup=function(val){
                var check=val.checked;
                document.getElementById("toGroup").disabled=!check;
            }
</script>

<input type="checkbox" id="changeGroup" onchange="changeGroup(this);"/>

But it does not working. Can any one give me, what the problem in this code.

Posted 20-Mar-13 23:52pm

gavkk

Updated 21-Mar-13 0:16am

Tadit Dash (ତଡିତ୍ କୁମାର ଦାଶ)

v2

Add a Solution

Comments

Shubham Choudhary 21-Mar-13 6:35am

hi!!! agav try to onclick instead of onchange

4 solutions

Solution 3

Hey,

It is working fine.

I don't know the control you have taken for "toGroup".
But I have taken that as a button and tested, the code is working.

Case-1
When checkbox is checked, the below line will calculate as true.

JavaScript

var check = val.checked;

So, the button will be enabled as per the code below.

JavaScript

document.getElementById("toGroup").disabled = !check; //As !check is false

Case-2
When checkbox is un-checked, the below line will calculate as false.

JavaScript

var check = val.checked;

So, the button will be disabled as per the code below.

JavaScript

document.getElementById("toGroup").disabled = !check; //As !check is true

Check the Live Demo[^].

Thanks...

Posted 21-Mar-13 0:58am

Tadit Dash (ତଡିତ୍ କୁମାର ଦାଶ)

Comments

gavkk 21-Mar-13 10:07am

But still the problem is there.

toGroup is a select associated with bean
<html:select styleId="toGroup" property="toGroup">

The similar code working good in another jsp file.

Tadit Dash (ତଡିତ୍ କୁମାର ଦାଶ) 22-Mar-13 2:21am

I could not get you.
Is it a dropdown ?

Solution 2

hi friend toGroup is visible false then following try to

JavaScript

<script type="text/javascript">
function(val){
                var check=val.checked;
                document.getElementById("toGroup").disabled=!check;
            }
}</script>

Posted 21-Mar-13 0:28am

Arvind Zamakia

Updated 21-Mar-13 0:46am

v2

Comments

sainadh.chintha 21-Mar-13 7:11am

with out function name what it mean. His actual code is working fine.

Solution 4

try these,

XML

function changeGroup(id){
var check=id.checked;
document.getElementById("toGroup").disabled=!check;

}


<input type="checkbox" id="changeGroup" onchange="changeGroup(this.id);"/>

Posted 21-Mar-13 2:54am

vaibhav10Dec1987

Updated 21-Mar-13 20:17pm

v2

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

gavkk · Accepted Answer · 2013-03-21T20:19:00

Solution 5

the problem solved by changing function name. The function name and id of checkbox cannot be same!

Posted 21-Mar-13 20:19pm

gavkk

Comments

Tadit Dash (ତଡିତ୍ କୁମାର ଦାଶ) 22-Mar-13 3:08am

But it was working with me. You can see the demo I have provided in my answer.