Conversion failed when converting the varchar value '' to data type int

Question

0.00/5 (No votes)

See more:

Hi,

I want to execute the below query using the parameters @Data and @Id taken from the UI.

C#

query = string.Format("update tablename set Confirmed=0 where data in (@Data) and id=@Id");
                    sqlParameters = new SqlParameter[2];
                    sqlParameters[0] = new SqlParameter("@Data", SqlDbType.VarChar);
                    sqlParameters[0].Value = Convert.ToString(_data);                    
                    sqlParameters[1] = new SqlParameter("@Shopid", SqlDbType.Int);
                    sqlParameters[1].Value = Convert.ToString(_shopid);

value for the parameters from UI are given below:

@Data=123,456
@Id=1

My problem is, I get the below error message when I run the application:

"Conversion failed when converting the varchar value '123,456' to data type int."

Please help me fix this.

Thanks in advance.

Posted 1-Oct-13 19:32pm

Rahul Krishnan R

Add a Solution

Comments

Herman<T>.Instance 2-Oct-13 1:41am

change the , to a . and then you know that you're not working with a integer

Rahul Krishnan R 2-Oct-13 1:50am

123 and 456 are two different values which cannot be separated using a.

3 solutions

Solution 1

hi,
Update your query like this:

C#

query = string.Format("update tablename set Confirmed=0 where data in ('+CAST( (@Data) AS VARCHAR) +') and id=@Id");
                    sqlParameters = new SqlParameter[2];
                    sqlParameters[0] = new SqlParameter("@Data", SqlDbType.VarChar);
                    sqlParameters[0].Value = Convert.ToString(_data);                    
                    sqlParameters[1] = new SqlParameter("@Shopid", SqlDbType.Int);
                    sqlParameters[1].Value = Convert.ToString(_shopid);

Posted 1-Oct-13 19:51pm

tanweer

Solution 3

SQL

query = string.Format("update tablename set Confirmed=0 where data in ('+CAST( (@Data) AS VARCHAR(20)) +') and id=@Id");
                    sqlParameters = new SqlParameter[2];
                    sqlParameters[0] = new SqlParameter("@Data", SqlDbType.VarChar,20);
                    sqlParameters[0].Value = Convert.ToString(_data);
                    sqlParameters[1] = new SqlParameter("@Shopid", SqlDbType.Int);
                    sqlParameters[1].Value = Convert.ToString(_shopid);

Posted 2-Oct-13 22:39pm

Ranesh M Raj

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Eon Malherbe · Accepted Answer · 2013-10-01T19:54:00

Solution 2

You are atempting dynamic SQL and SQL is trying to cast the @Data parameter to an integer value. Rather try something like this:

C#

query = string.Format("update tablename set Confirmed=0 where data in ({0}) and id=@Id", Convert.ToString(_data));
                    sqlParameters = new SqlParameter[1];
                    sqlParameters[0] = new SqlParameter("@Shopid", SqlDbType.Int);
                    sqlParameters[0].Value = Convert.ToString(_shopid);

Posted 1-Oct-13 19:54pm

Eon Malherbe

Comments

Rahul Krishnan R 2-Oct-13 2:09am

Thank you very much Eon Malherbe. You reply saved my day..

Also, could you pls explain me what {0} means in the query. I am a beginner in c#.

Eon Malherbe 31-Oct-13 1:40am

The {x} is a placeholder used in string.Format. {0} is the first parameter, {1} the second etc. For example: string.Format("the {0} car drove {1} mph", "red", 30) will result in "the red car drove 30 mph".