not get all values only gets first values set

Question

0.00/5 (No votes)

See more:

I use SQL management studio and C#
So I need to get value from database and concatenate with new value and store in database
example
past value = "aaaaa"
New value = "bbbbb"
Need to store value = "aaaaa / bbbbb" like this

So I try like this but only get the last value like this
Ex
Last value sore in the database like this "ccc / bbb"
Application only get ccc but i want get all value "ccc / bbb"

this is my code get values

C#

string pastval , past;

using (SqlConnection conn = new SqlConnection(@"Data Source=MCK-PC\MCKSQL;Initial Catalog=application_database;Integrated Security=True"))
                {
                    conn.Open();
                    SqlCommand command = new SqlCommand("SELECT * FROM tbl1 WHERE id=@id", conn);
                    command.Parameters.AddWithValue("id", txt_id.Text);
                    SqlDataReader reader = command.ExecuteReader();
                    while (reader.Read())
                    {
                        pastval =reader["name"].ToString();
                        past= txtnew_name.Text +" / "+pastval.ToString();

                    }
                    reader.Close();
                    conn.Close();
                }

Thanks in advance !

Posted 3-Nov-13 5:06am

Manoj Chamikara

Add a Solution

Comments

Richard MacCutchan 3-Nov-13 11:16am

You generate the string in variable past but you then overwrite it next time round the loop. Thus you only get the last entry at the end of the loop.

Manoj Chamikara 3-Nov-13 12:46pm

@Richard
Thank Your quick response :)
OriginalGriff Solution (Solution 1) works

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Accepted Answer · 2013-11-03T05:45:00

Solution 1

You need to append the text:

C#

StringBuilder sb = new StringBuilder(textnew_name.Text);
while (reader.Read())
{
    sb.AppendFormat(" / {0}", reader["name"])
}
past = sb.Tostring();

Posted 3-Nov-13 5:45am

OriginalGriff

Comments

Manoj Chamikara 3-Nov-13 12:48pm

@OriginalGriff
Griff Thank you so much dude It works
Thank you very very very Much
:)

OriginalGriff 3-Nov-13 14:31pm

You're welcome!

Tadit Dash (ତଡିତ୍ କୁମାର ଦାଶ) · Accepted Answer · 2013-11-03T07:29:00

Quote:

C#

SqlCommand command = new SqlCommand("SELECT * FROM tbl1 WHERE id=@id", conn);

You have got your answer, but I would like to mention one point here.

You have written SELECT *, which will select all Columns of the Table and is very time consuming.
But from the code, it is clear that you only need the Column "name" as you have written like reader["name"].

So, you should change the Query to...

C#

SqlCommand command = new SqlCommand("SELECT name FROM tbl1 WHERE id=@id", conn);